1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe Gitlab::Ci::Config::Normalizer do
let(:job_name) { :rspec }
let(:job_config) { { script: 'rspec', parallel: parallel_config, name: 'rspec', job_variables: variables_config } }
let(:config) { { job_name => job_config } }
describe '.normalize_jobs' do
subject { described_class.new(config).normalize_jobs }
shared_examples 'parallel dependencies' do
context "when job has dependencies on parallelized jobs" do
let(:config) do
{
job_name => job_config,
other_job: { script: 'echo 1', dependencies: [job_name.to_s] }
}
end
it "parallelizes dependencies" do
expect(subject[:other_job][:dependencies]).to eq(expanded_job_names)
end
it "does not include original job name in #{context}" do
expect(subject[:other_job][:dependencies]).not_to include(job_name)
end
end
context "when there are dependencies which are both parallelized and not" do
let(:config) do
{
job_name => job_config,
other_job: { script: 'echo 1' },
final_job: { script: 'echo 1', dependencies: [job_name.to_s, "other_job"] }
}
end
it "parallelizes dependencies" do
expect(subject[:final_job][:dependencies]).to include(*expanded_job_names)
end
it "includes the regular job in dependencies" do
expect(subject[:final_job][:dependencies]).to include('other_job')
end
end
end
shared_examples 'parallel needs' do
let(:expanded_job_attributes) do
expanded_job_names.map do |job_name|
{ name: job_name, extra: :key }
end
end
context 'when job has needs on parallelized jobs' do
let(:config) do
{
job_name => job_config,
other_job: {
script: 'echo 1',
needs: {
job: [
{ name: job_name.to_s, extra: :key }
]
}
}
}
end
it 'parallelizes needs' do
expect(subject.dig(:other_job, :needs, :job)).to eq(expanded_job_attributes)
end
end
context 'when there are dependencies which are both parallelized and not' do
let(:config) do
{
job_name => job_config,
other_job: {
script: 'echo 1'
},
final_job: {
script: 'echo 1',
needs: {
job: [
{ name: job_name.to_s, extra: :key },
{ name: 'other_job', extra: :key }
]
}
}
}
end
it 'parallelizes dependencies' do
expect(subject.dig(:final_job, :needs, :job)).to include(*expanded_job_attributes)
end
it 'includes the regular job in dependencies' do
expect(subject.dig(:final_job, :needs, :job)).to include(name: 'other_job', extra: :key)
end
end
end
shared_examples 'needs:parallel:matrix' do
let(:expanded_needs_parallel_job_attributes) do
expanded_needs_parallel_job_names.map do |job_name|
{ name: job_name }
end
end
context 'when job has needs:parallel:matrix on parallelized jobs' do
let(:config) do
{
job_name => job_config,
other_job: {
script: 'echo 1',
needs: {
job: [
{ name: job_name.to_s, parallel: needs_parallel_config }
]
}
}
}
end
it 'parallelizes and only keeps needs specified by needs:parallel:matrix' do
expect(subject.dig(:other_job, :needs, :job)).to eq(expanded_needs_parallel_job_attributes)
end
end
end
context 'with parallel config as integer' do
let(:variables_config) { {} }
let(:parallel_config) { 5 }
let(:expanded_job_names) do
[
'rspec 1/5',
'rspec 2/5',
'rspec 3/5',
'rspec 4/5',
'rspec 5/5'
]
end
it 'does not have original job' do
is_expected.not_to include(job_name)
end
it 'has parallelized jobs' do
is_expected.to include(*expanded_job_names.map(&:to_sym))
end
it 'sets job instance in options' do
expect(subject.values).to all(include(:instance))
end
it 'parallelizes jobs with original config' do
original_config = config[job_name]
.except(:name)
.deep_merge(parallel: { total: parallel_config })
configs = subject.values.map { |config| config.except(:name, :instance) }
expect(configs).to all(eq(original_config))
end
context 'when the job is not parallelized' do
let(:job_config) { { script: 'rspec', name: 'rspec' } }
it 'returns the same hash' do
is_expected.to eq(config)
end
end
context 'when there is a job with a slash in it' do
let(:job_name) { :"rspec 35/2" }
it 'properly parallelizes job names' do
job_names = [
:"rspec 35/2 1/5",
:"rspec 35/2 2/5",
:"rspec 35/2 3/5",
:"rspec 35/2 4/5",
:"rspec 35/2 5/5"
]
is_expected.to include(*job_names)
end
end
it_behaves_like 'parallel dependencies'
it_behaves_like 'parallel needs'
end
context 'with a simple parallel matrix config' do
let(:variables_config) do
{
USER_VARIABLE: 'user value'
}
end
let(:parallel_config) do
{
matrix: [
{
VAR_1: ['A'],
VAR_2: %w[B C]
}
]
}
end
let(:expanded_job_names) do
[
'rspec: [A, B]',
'rspec: [A, C]'
]
end
let(:needs_parallel_config) do
{
matrix: [
{
VAR_1: ['A'],
VAR_2: ['C']
}
]
}
end
let(:expanded_needs_parallel_job_names) { ['rspec: [A, C]'] }
it 'does not have original job' do
is_expected.not_to include(job_name)
end
it 'sets job instance in options' do
expect(subject.values).to all(include(:instance))
end
it 'sets job variables', :aggregate_failures do
expect(subject.values[0]).to match(
a_hash_including(job_variables: { VAR_1: 'A', VAR_2: 'B', USER_VARIABLE: 'user value' })
)
expect(subject.values[1]).to match(
a_hash_including(job_variables: { VAR_1: 'A', VAR_2: 'C', USER_VARIABLE: 'user value' })
)
end
it 'parallelizes jobs with original config' do
configs = subject.values.map do |config|
config.except(:name, :instance, :job_variables)
end
original_config = config[job_name]
.except(:name, :job_variables)
.deep_merge(parallel: { total: 2 })
expect(configs).to all(match(a_hash_including(original_config)))
end
it 'has parallelized jobs' do
is_expected.to include(*expanded_job_names.map(&:to_sym))
end
it_behaves_like 'parallel dependencies'
it_behaves_like 'parallel needs'
it_behaves_like 'needs:parallel:matrix'
end
context 'with a complex parallel matrix config' do
let(:variables_config) { {} }
let(:parallel_config) do
{
matrix: [
{
PLATFORM: ['centos'],
STACK: %w[ruby python java],
DB: %w[postgresql mysql]
},
{
PLATFORM: ['ubuntu'],
PROVIDER: %w[aws gcp]
}
]
}
end
let(:needs_parallel_config) do
{
matrix: [
{
PLATFORM: ['centos'],
STACK: %w[ruby python],
DB: ['postgresql']
},
{
PLATFORM: ['ubuntu'],
PROVIDER: ['aws']
}
]
}
end
let(:expanded_needs_parallel_job_names) do
[
'rspec: [centos, ruby, postgresql]',
'rspec: [centos, python, postgresql]',
'rspec: [ubuntu, aws]'
]
end
let(:expanded_job_names) do
[
'rspec: [centos, ruby, postgresql]',
'rspec: [centos, ruby, mysql]',
'rspec: [centos, python, postgresql]',
'rspec: [centos, python, mysql]',
'rspec: [centos, java, postgresql]',
'rspec: [centos, java, mysql]',
'rspec: [ubuntu, aws]',
'rspec: [ubuntu, gcp]'
]
end
it_behaves_like 'parallel needs'
it_behaves_like 'needs:parallel:matrix'
end
context 'when parallel config does not matches a factory' do
let(:variables_config) { {} }
let(:parallel_config) {}
it 'does not alter the job config' do
is_expected.to match(config)
end
end
context 'when jobs config is nil' do
let(:config) { nil }
it { is_expected.to eq({}) }
end
end
end
|