1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe Gitlab::Ci::Pipeline::Chain::PopulateMetadata, feature_category: :pipeline_composition do
let_it_be(:project) { create(:project, :repository) }
let_it_be(:user) { create(:user) }
let(:pipeline) do
build(:ci_pipeline, project: project, ref: 'master', user: user)
end
let(:command) do
Gitlab::Ci::Pipeline::Chain::Command.new(
project: project,
current_user: user,
origin_ref: 'master')
end
let(:dependencies) do
[
Gitlab::Ci::Pipeline::Chain::Config::Content.new(pipeline, command),
Gitlab::Ci::Pipeline::Chain::Config::Process.new(pipeline, command),
Gitlab::Ci::Pipeline::Chain::EvaluateWorkflowRules.new(pipeline, command),
Gitlab::Ci::Pipeline::Chain::SeedBlock.new(pipeline, command),
Gitlab::Ci::Pipeline::Chain::Seed.new(pipeline, command),
Gitlab::Ci::Pipeline::Chain::Populate.new(pipeline, command)
]
end
let(:step) { described_class.new(pipeline, command) }
let(:config) do
{ rspec: { script: 'rspec' } }
end
def run_chain
dependencies.map(&:perform!)
step.perform!
end
before do
stub_ci_pipeline_yaml_file(YAML.dump(config))
end
shared_examples 'not breaking the chain' do
it 'does not break the chain' do
run_chain
expect(step.break?).to be false
end
end
shared_examples 'not saving pipeline metadata' do
it 'does not save pipeline metadata' do
run_chain
expect(pipeline.pipeline_metadata).to be_nil
end
end
context 'with pipeline name' do
let(:config) do
{ workflow: { name: ' Pipeline name ' }, rspec: { script: 'rspec' } }
end
it_behaves_like 'not breaking the chain'
it 'builds pipeline_metadata' do
run_chain
expect(pipeline.pipeline_metadata.name).to eq('Pipeline name')
expect(pipeline.pipeline_metadata.project).to eq(pipeline.project)
expect(pipeline.pipeline_metadata).not_to be_persisted
end
context 'with empty name' do
let(:config) do
{ workflow: { name: ' ' }, rspec: { script: 'rspec' } }
end
it_behaves_like 'not saving pipeline metadata'
context 'with empty name after variable substitution' do
let(:config) do
{ workflow: { name: '$VAR1' }, rspec: { script: 'rspec' } }
end
it_behaves_like 'not saving pipeline metadata'
end
end
context 'with variables' do
let(:config) do
{
variables: { ROOT_VAR: 'value $WORKFLOW_VAR1' },
workflow: {
name: 'Pipeline $ROOT_VAR $WORKFLOW_VAR2 $UNKNOWN_VAR',
rules: [{ variables: { WORKFLOW_VAR1: 'value1', WORKFLOW_VAR2: 'value2' } }]
},
rspec: { script: 'rspec' }
}
end
it 'substitutes variables' do
run_chain
expect(pipeline.pipeline_metadata.name).to eq('Pipeline value value1 value2')
end
end
context 'with invalid name' do
let(:config) do
{
variables: { ROOT_VAR: 'a' * 256 },
workflow: {
name: 'Pipeline $ROOT_VAR'
},
rspec: { script: 'rspec' }
}
end
it 'returns error and breaks chain' do
ret = run_chain
expect(ret)
.to match_array(["Failed to build pipeline metadata! Name is too long (maximum is 255 characters)"])
expect(pipeline.pipeline_metadata.errors.full_messages)
.to match_array(['Name is too long (maximum is 255 characters)'])
expect(step.break?).to be true
end
end
end
context 'with auto_cancel' do
let(:on_new_commit) { 'interruptible' }
let(:on_job_failure) { 'all' }
let(:auto_cancel) { { on_new_commit: on_new_commit, on_job_failure: on_job_failure } }
let(:config) { { workflow: { auto_cancel: auto_cancel }, rspec: { script: 'rspec' } } }
it_behaves_like 'not breaking the chain'
it 'builds pipeline_metadata' do
run_chain
expect(pipeline.pipeline_metadata.auto_cancel_on_new_commit).to eq('interruptible')
expect(pipeline.pipeline_metadata.auto_cancel_on_job_failure).to eq('all')
expect(pipeline.pipeline_metadata).not_to be_persisted
end
context 'with no auto_cancel' do
let(:config) do
{ rspec: { script: 'rspec' } }
end
it_behaves_like 'not saving pipeline metadata'
end
context 'with auto_cancel: nil' do
let(:auto_cancel) { nil }
it_behaves_like 'not saving pipeline metadata'
end
context 'with auto_cancel_on_new_commit and no auto_cancel_on_job_failure' do
let(:auto_cancel) { { on_new_commit: on_new_commit } }
it 'builds pipeline_metadata' do
run_chain
expect(pipeline.pipeline_metadata.auto_cancel_on_new_commit).to eq('interruptible')
expect(pipeline.pipeline_metadata.auto_cancel_on_job_failure).to eq('none')
expect(pipeline.pipeline_metadata).not_to be_persisted
end
end
context 'with auto_cancel_on_job_failure and no auto_cancel_on_new_commit' do
let(:auto_cancel) { { on_job_failure: on_job_failure } }
it 'builds pipeline_metadata' do
run_chain
expect(pipeline.pipeline_metadata.auto_cancel_on_new_commit).to eq('conservative')
expect(pipeline.pipeline_metadata.auto_cancel_on_job_failure).to eq('all')
expect(pipeline.pipeline_metadata).not_to be_persisted
end
end
context 'with auto_cancel_on_new_commit: nil and auto_cancel_on_job_failure: nil' do
let(:on_new_commit) { nil }
let(:on_job_failure) { nil }
it_behaves_like 'not saving pipeline metadata'
end
context 'with auto_cancel_on_new_commit valid and auto_cancel_on_job_failure: nil' do
let(:on_job_failure) { nil }
it 'builds pipeline_metadata' do
run_chain
expect(pipeline.pipeline_metadata.auto_cancel_on_new_commit).to eq('interruptible')
expect(pipeline.pipeline_metadata.auto_cancel_on_job_failure).to eq('none')
expect(pipeline.pipeline_metadata).not_to be_persisted
end
end
context 'with auto_cancel_on_new_commit: nil and auto_cancel_on_job_failure valid' do
let(:on_new_commit) { nil }
it 'builds pipeline_metadata' do
run_chain
expect(pipeline.pipeline_metadata.auto_cancel_on_new_commit).to eq('conservative')
expect(pipeline.pipeline_metadata.auto_cancel_on_job_failure).to eq('all')
expect(pipeline.pipeline_metadata).not_to be_persisted
end
end
context 'when auto_cancel_on_job_failure: none' do
let(:on_job_failure) { 'none' }
it 'builds pipeline_metadata' do
run_chain
expect(pipeline.pipeline_metadata.auto_cancel_on_job_failure).to eq('none')
expect(pipeline.pipeline_metadata).not_to be_persisted
end
end
context 'when auto_cancel_pipeline_on_job_failure feature is disabled' do
before do
stub_feature_flags(auto_cancel_pipeline_on_job_failure: false)
end
it 'ignores the auto_cancel_on_job_failure value' do
run_chain
expect(pipeline.pipeline_metadata.auto_cancel_on_job_failure).to eq('none')
expect(pipeline.pipeline_metadata).not_to be_persisted
end
end
end
context 'with both pipeline name and auto_cancel' do
let(:config) do
{
workflow: {
name: 'Pipeline name',
auto_cancel: {
on_new_commit: 'interruptible',
on_job_failure: 'none'
}
},
rspec: { script: 'rspec' }
}
end
it_behaves_like 'not breaking the chain'
it 'builds pipeline_metadata' do
run_chain
expect(pipeline.pipeline_metadata.name).to eq('Pipeline name')
expect(pipeline.pipeline_metadata.auto_cancel_on_new_commit).to eq('interruptible')
expect(pipeline.pipeline_metadata.auto_cancel_on_job_failure).to eq('none')
expect(pipeline.pipeline_metadata).not_to be_persisted
end
end
end
|
