1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe Gitlab::Database::AsyncForeignKeys::MigrationHelpers, feature_category: :database do
let(:migration) { Gitlab::Database::Migration[2.1].new }
let(:connection) { ApplicationRecord.connection }
let(:fk_model) { Gitlab::Database::AsyncForeignKeys::PostgresAsyncForeignKeyValidation }
let(:table_name) { '_test_async_fks' }
let(:column_name) { 'parent_id' }
let(:fk_name) { nil }
context 'with regular tables' do
before do
allow(migration).to receive(:puts)
allow(migration.connection).to receive(:transaction_open?).and_return(false)
connection.create_table(table_name) do |t|
t.integer column_name
end
migration.add_concurrent_foreign_key(
table_name, table_name,
column: column_name, validate: false, name: fk_name)
end
describe '#prepare_async_foreign_key_validation' do
it 'creates the record for the async FK validation' do
expect do
migration.prepare_async_foreign_key_validation(table_name, column_name)
end.to change { fk_model.where(table_name: table_name).count }.by(1)
record = fk_model.find_by(table_name: table_name)
expect(record.name).to start_with('fk_')
end
context 'when an explicit name is given' do
let(:fk_name) { 'my_fk_name' }
it 'creates the record with the given name' do
expect do
migration.prepare_async_foreign_key_validation(table_name, name: fk_name)
end.to change { fk_model.where(name: fk_name).count }.by(1)
record = fk_model.find_by(name: fk_name)
expect(record.table_name).to eq(table_name)
end
end
context 'when the FK does not exist' do
it 'returns an error' do
expect do
migration.prepare_async_foreign_key_validation(table_name, name: 'no_fk')
end.to raise_error RuntimeError, /Could not find foreign key "no_fk" on table "_test_async_fks"/
end
end
context 'when the record already exists' do
let(:fk_name) { 'my_fk_name' }
it 'does attempt to create the record' do
create(:postgres_async_foreign_key_validation, table_name: table_name, name: fk_name)
expect do
migration.prepare_async_foreign_key_validation(table_name, name: fk_name)
end.not_to change { fk_model.where(name: fk_name).count }
end
end
context 'when the async FK validation table does not exist' do
it 'does not raise an error' do
connection.drop_table(:postgres_async_foreign_key_validations)
expect(fk_model).not_to receive(:safe_find_or_create_by!)
expect { migration.prepare_async_foreign_key_validation(table_name, column_name) }.not_to raise_error
end
end
end
describe '#unprepare_async_foreign_key_validation' do
before do
migration.prepare_async_foreign_key_validation(table_name, column_name, name: fk_name)
end
it 'destroys the record' do
expect do
migration.unprepare_async_foreign_key_validation(table_name, column_name)
end.to change { fk_model.where(table_name: table_name).count }.by(-1)
end
context 'when an explicit name is given' do
let(:fk_name) { 'my_test_async_fk' }
it 'destroys the record' do
expect do
migration.unprepare_async_foreign_key_validation(table_name, name: fk_name)
end.to change { fk_model.where(name: fk_name).count }.by(-1)
end
end
context 'when the async fk validation table does not exist' do
it 'does not raise an error' do
connection.drop_table(:postgres_async_foreign_key_validations)
expect(fk_model).not_to receive(:find_by)
expect { migration.unprepare_async_foreign_key_validation(table_name, column_name) }.not_to raise_error
end
end
end
end
context 'with partitioned tables' do
let(:partition_schema) { 'gitlab_partitions_dynamic' }
let(:partition1_name) { "#{partition_schema}.#{table_name}_202001" }
let(:partition2_name) { "#{partition_schema}.#{table_name}_202002" }
let(:fk_name) { 'my_partitioned_fk_name' }
before do
connection.execute(<<~SQL)
CREATE TABLE #{table_name} (
id serial NOT NULL,
#{column_name} int NOT NULL,
created_at timestamptz NOT NULL,
PRIMARY KEY (id, created_at)
) PARTITION BY RANGE (created_at);
CREATE TABLE #{partition1_name} PARTITION OF #{table_name}
FOR VALUES FROM ('2020-01-01') TO ('2020-02-01');
CREATE TABLE #{partition2_name} PARTITION OF #{table_name}
FOR VALUES FROM ('2020-02-01') TO ('2020-03-01');
SQL
end
describe '#prepare_partitioned_async_foreign_key_validation' do
it 'delegates to prepare_async_foreign_key_validation for each partition' do
expect(migration)
.to receive(:prepare_async_foreign_key_validation)
.with(partition1_name, column_name, name: fk_name)
expect(migration)
.to receive(:prepare_async_foreign_key_validation)
.with(partition2_name, column_name, name: fk_name)
migration.prepare_partitioned_async_foreign_key_validation(table_name, column_name, name: fk_name)
end
end
describe '#unprepare_partitioned_async_foreign_key_validation' do
it 'delegates to unprepare_async_foreign_key_validation for each partition' do
expect(migration)
.to receive(:unprepare_async_foreign_key_validation)
.with(partition1_name, column_name, name: fk_name)
expect(migration)
.to receive(:unprepare_async_foreign_key_validation)
.with(partition2_name, column_name, name: fk_name)
migration.unprepare_partitioned_async_foreign_key_validation(table_name, column_name, name: fk_name)
end
end
end
end
|
