blob: 641dd48be364257fccf539d4079e9c804932175e (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe Gitlab::Database::Reflection, feature_category: :database do
let(:database) { described_class.new(ApplicationRecord) }
describe '#username' do
context 'when a username is set' do
it 'returns the username' do
allow(database).to receive(:config).and_return(username: 'bob')
expect(database.username).to eq('bob')
end
end
context 'when a username is not set' do
it 'returns the value of the USER environment variable' do
allow(database).to receive(:config).and_return(username: nil)
allow(ENV).to receive(:[]).with('USER').and_return('bob')
expect(database.username).to eq('bob')
end
end
end
describe '#database_name' do
it 'returns the name of the database' do
allow(database).to receive(:config).and_return(database: 'test')
expect(database.database_name).to eq('test')
end
end
describe '#adapter_name' do
it 'returns the database adapter name' do
allow(database).to receive(:config).and_return(adapter: 'test')
expect(database.adapter_name).to eq('test')
end
end
describe '#human_adapter_name' do
context 'when the adapter is PostgreSQL' do
it 'returns PostgreSQL' do
allow(database).to receive(:config).and_return(adapter: 'postgresql')
expect(database.human_adapter_name).to eq('PostgreSQL')
end
end
context 'when the adapter is not PostgreSQL' do
it 'returns Unknown' do
allow(database).to receive(:config).and_return(adapter: 'kittens')
expect(database.human_adapter_name).to eq('Unknown')
end
end
end
describe '#postgresql?' do
context 'when using PostgreSQL' do
it 'returns true' do
allow(database).to receive(:adapter_name).and_return('PostgreSQL')
expect(database.postgresql?).to eq(true)
end
end
context 'when not using PostgreSQL' do
it 'returns false' do
allow(database).to receive(:adapter_name).and_return('MySQL')
expect(database.postgresql?).to eq(false)
end
end
end
describe '#db_read_only?' do
it 'detects a read-only database' do
allow(database.model.connection)
.to receive(:execute)
.with('SELECT pg_is_in_recovery()')
.and_return([{ "pg_is_in_recovery" => "t" }])
expect(database.db_read_only?).to be_truthy
end
it 'detects a read-only database' do
allow(database.model.connection)
.to receive(:execute)
.with('SELECT pg_is_in_recovery()')
.and_return([{ "pg_is_in_recovery" => true }])
expect(database.db_read_only?).to be_truthy
end
it 'detects a read-write database' do
allow(database.model.connection)
.to receive(:execute)
.with('SELECT pg_is_in_recovery()')
.and_return([{ "pg_is_in_recovery" => "f" }])
expect(database.db_read_only?).to be_falsey
end
it 'detects a read-write database' do
allow(database.model.connection)
.to receive(:execute)
.with('SELECT pg_is_in_recovery()')
.and_return([{ "pg_is_in_recovery" => false }])
expect(database.db_read_only?).to be_falsey
end
end
describe '#db_read_write?' do
it 'detects a read-only database' do
allow(database.model.connection)
.to receive(:execute)
.with('SELECT pg_is_in_recovery()')
.and_return([{ "pg_is_in_recovery" => "t" }])
expect(database.db_read_write?).to eq(false)
end
it 'detects a read-only database' do
allow(database.model.connection)
.to receive(:execute)
.with('SELECT pg_is_in_recovery()')
.and_return([{ "pg_is_in_recovery" => true }])
expect(database.db_read_write?).to eq(false)
end
it 'detects a read-write database' do
allow(database.model.connection)
.to receive(:execute)
.with('SELECT pg_is_in_recovery()')
.and_return([{ "pg_is_in_recovery" => "f" }])
expect(database.db_read_write?).to eq(true)
end
it 'detects a read-write database' do
allow(database.model.connection)
.to receive(:execute)
.with('SELECT pg_is_in_recovery()')
.and_return([{ "pg_is_in_recovery" => false }])
expect(database.db_read_write?).to eq(true)
end
end
describe '#version' do
around do |example|
database.instance_variable_set(:@version, nil)
example.run
database.instance_variable_set(:@version, nil)
end
context "on postgresql" do
it "extracts the version number" do
allow(database)
.to receive(:database_version)
.and_return("PostgreSQL 9.4.4 on x86_64-apple-darwin14.3.0")
expect(database.version).to eq '9.4.4'
end
end
it 'memoizes the result' do
count = ActiveRecord::QueryRecorder
.new { 2.times { database.version } }
.count
expect(count).to eq(1)
end
end
describe '#postgresql_minimum_supported_version?' do
it 'returns false when using PostgreSQL 10' do
allow(database).to receive(:version).and_return('10')
expect(database.postgresql_minimum_supported_version?).to eq(false)
end
it 'returns false when using PostgreSQL 11' do
allow(database).to receive(:version).and_return('11')
expect(database.postgresql_minimum_supported_version?).to eq(false)
end
it 'returns false when using PostgreSQL 12' do
allow(database).to receive(:version).and_return('12')
expect(database.postgresql_minimum_supported_version?).to eq(false)
end
it 'returns true when using PostgreSQL 13' do
allow(database).to receive(:version).and_return('13')
expect(database.postgresql_minimum_supported_version?).to eq(true)
end
end
describe '#cached_column_exists?' do
it 'only retrieves the data from the schema cache' do
database = described_class.new(Project)
queries = ActiveRecord::QueryRecorder.new do
2.times do
expect(database.cached_column_exists?(:id)).to be_truthy
expect(database.cached_column_exists?(:bogus_column)).to be_falsey
end
end
expect(queries.count).to eq(0)
end
end
describe '#cached_table_exists?' do
it 'only retrieves the data from the schema cache' do
dummy = Class.new(ActiveRecord::Base) do
self.table_name = 'bogus_table_name'
end
queries = ActiveRecord::QueryRecorder.new do
2.times do
expect(described_class.new(Project).cached_table_exists?).to be_truthy
expect(described_class.new(dummy).cached_table_exists?).to be_falsey
end
end
expect(queries.count).to eq(0)
end
it 'returns false when database does not exist' do
database = described_class.new(Project)
expect(database.model).to receive(:connection) do
raise ActiveRecord::NoDatabaseError, 'broken'
end
expect(database.cached_table_exists?).to be(false)
end
end
describe '#exists?' do
it 'returns true if the database exists' do
expect(database.exists?).to be(true)
end
it "returns false if the database doesn't exist" do
expect(database.model.connection.schema_cache)
.to receive(:database_version)
.and_raise(ActiveRecord::NoDatabaseError)
expect(database.exists?).to be(false)
end
end
describe '#system_id' do
it 'returns the PostgreSQL system identifier' do
expect(database.system_id).to be_an_instance_of(Integer)
end
end
describe '#flavor', :delete do
let(:result) { [double] }
let(:connection) { database.model.connection }
def stub_statements(statements)
statements = Array.wrap(statements)
execute = connection.method(:execute)
allow(connection).to receive(:execute) do |arg|
if statements.include?(arg)
result
else
execute.call(arg)
end
end
end
it 're-raises exceptions not matching expected messages' do
expect(database.model.connection)
.to receive(:execute)
.and_raise(ActiveRecord::StatementInvalid, 'Something else')
expect { database.flavor }.to raise_error ActiveRecord::StatementInvalid, /Something else/
end
it 'recognizes Amazon Aurora PostgreSQL' do
stub_statements(['SHOW rds.extensions', 'SELECT AURORA_VERSION()'])
expect(database.flavor).to eq('Amazon Aurora PostgreSQL')
end
it 'recognizes PostgreSQL on Amazon RDS' do
stub_statements('SHOW rds.extensions')
expect(database.flavor).to eq('PostgreSQL on Amazon RDS')
end
it 'recognizes CloudSQL for PostgreSQL' do
stub_statements('SHOW cloudsql.iam_authentication')
expect(database.flavor).to eq('Cloud SQL for PostgreSQL')
end
it 'recognizes Azure Database for PostgreSQL - Flexible Server' do
stub_statements(["SELECT datname FROM pg_database WHERE datname = 'azure_maintenance'", 'SHOW azure.extensions'])
expect(database.flavor).to eq('Azure Database for PostgreSQL - Flexible Server')
end
it 'recognizes Azure Database for PostgreSQL - Single Server' do
stub_statements("SELECT datname FROM pg_database WHERE datname = 'azure_maintenance'")
expect(database.flavor).to eq('Azure Database for PostgreSQL - Single Server')
end
it 'recognizes AlloyDB for PostgreSQL' do
stub_statements("SELECT name FROM pg_settings WHERE name LIKE 'alloydb%'")
expect(database.flavor).to eq('AlloyDB for PostgreSQL')
end
it 'returns nil if can not recognize the flavor' do
expect(database.flavor).to be_nil
end
end
describe '#config' do
it 'returns a HashWithIndifferentAccess' do
expect(database.config)
.to be_an_instance_of(HashWithIndifferentAccess)
end
it 'returns a default pool size' do
expect(database.config)
.to include(pool: Gitlab::Database.default_pool_size)
end
it 'does not cache its results' do
a = database.config
b = database.config
expect(a).not_to equal(b)
end
end
end
|