1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe Gitlab::GithubImport::Clients::Proxy, :manage, feature_category: :importers do
subject(:client) { described_class.new(access_token, client_options) }
let(:access_token) { 'test_token' }
let(:client_options) { { foo: :bar } }
it { expect(client).to delegate_method(:each_object).to(:client) }
it { expect(client).to delegate_method(:user).to(:client) }
it { expect(client).to delegate_method(:octokit).to(:client) }
describe '#repos' do
let(:search_text) { 'search text' }
let(:pagination_options) { { limit: 10 } }
context 'when remove_legacy_github_client FF is enabled' do
let(:client_stub) { instance_double(Gitlab::GithubImport::Client) }
let(:client_response) do
{
data: {
search: {
nodes: [{ name: 'foo' }, { name: 'bar' }],
pageInfo: { startCursor: 'foo', endCursor: 'bar' },
repositoryCount: 2
}
}
}
end
it 'fetches repos with Gitlab::GithubImport::Client (GraphQL API)' do
expect(Gitlab::GithubImport::Client)
.to receive(:new).with(access_token).and_return(client_stub)
expect(client_stub)
.to receive(:search_repos_by_name_graphql)
.with(search_text, pagination_options).and_return(client_response)
expect(client.repos(search_text, pagination_options)).to eq(
{
repos: [{ name: 'foo' }, { name: 'bar' }],
page_info: { startCursor: 'foo', endCursor: 'bar' },
count: 2
}
)
end
end
context 'when remove_legacy_github_client FF is disabled' do
let(:client_stub) { instance_double(Gitlab::LegacyGithubImport::Client) }
let(:search_text) { nil }
before do
stub_feature_flags(remove_legacy_github_client: false)
end
it 'fetches repos with Gitlab::LegacyGithubImport::Client' do
expect(Gitlab::LegacyGithubImport::Client)
.to receive(:new).with(access_token, client_options).and_return(client_stub)
expect(client_stub).to receive(:repos)
.and_return([{ name: 'foo' }, { name: 'bar' }])
expect(client.repos(search_text, pagination_options))
.to eq({ repos: [{ name: 'foo' }, { name: 'bar' }] })
end
context 'with filter params' do
let(:search_text) { 'fo' }
it 'fetches repos with Gitlab::LegacyGithubImport::Client' do
expect(Gitlab::LegacyGithubImport::Client)
.to receive(:new).with(access_token, client_options).and_return(client_stub)
expect(client_stub).to receive(:repos)
.and_return([{ name: 'FOO' }, { name: 'bAr' }])
expect(client.repos(search_text, pagination_options))
.to eq({ repos: [{ name: 'FOO' }] })
end
end
end
end
describe '#count_by', :clean_gitlab_redis_cache do
context 'when remove_legacy_github_client FF is enabled' do
let(:client_stub) { instance_double(Gitlab::GithubImport::Client) }
let(:client_response) { { data: { search: { repositoryCount: 1 } } } }
before do
stub_feature_flags(remove_legacy_github_client: true)
end
context 'when value is cached' do
before do
Gitlab::Cache::Import::Caching.write('github-importer/provider-repo-count/owned/user_id', 3)
end
it 'returns repository count from cache' do
expect(Gitlab::GithubImport::Client)
.to receive(:new).with(access_token).and_return(client_stub)
expect(client_stub)
.not_to receive(:count_repos_by_relation_type_graphql)
.with({ relation_type: 'owned' })
expect(client.count_repos_by('owned', 'user_id')).to eq(3)
end
end
context 'when value is not cached' do
it 'returns repository count' do
expect(Gitlab::GithubImport::Client)
.to receive(:new).with(access_token).and_return(client_stub)
expect(client_stub)
.to receive(:count_repos_by_relation_type_graphql)
.with({ relation_type: 'owned' }).and_return(client_response)
expect(Gitlab::Cache::Import::Caching)
.to receive(:write)
.with('github-importer/provider-repo-count/owned/user_id', 1, timeout: 5.minutes)
.and_call_original
expect(client.count_repos_by('owned', 'user_id')).to eq(1)
end
end
end
context 'when remove_legacy_github_client FF is disabled' do
let(:client_stub) { instance_double(Gitlab::LegacyGithubImport::Client) }
before do
stub_feature_flags(remove_legacy_github_client: false)
end
it 'returns nil' do
expect(Gitlab::LegacyGithubImport::Client)
.to receive(:new).with(access_token, client_options).and_return(client_stub)
expect(client.count_repos_by('owned', 'user_id')).to be_nil
end
end
end
end
|
