1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe Gitlab::GithubImport::Importer::ReleasesImporter do
let(:project) { create(:project) }
let(:client) { double(:client) }
let(:importer) { described_class.new(project, client) }
let(:github_release_name) { 'Initial Release' }
let(:created_at) { Time.new(2017, 1, 1, 12, 00) }
let(:released_at) { Time.new(2017, 1, 1, 12, 00) }
let(:github_release) do
double(
:github_release,
tag_name: '1.0',
name: github_release_name,
body: 'This is my release',
created_at: created_at,
published_at: released_at
)
end
describe '#execute' do
it 'imports the releases in bulk' do
release_hash = {
tag_name: '1.0',
description: 'This is my release',
created_at: created_at,
updated_at: created_at,
released_at: released_at
}
expect(importer).to receive(:build_releases).and_return([release_hash])
expect(importer).to receive(:bulk_insert).with(Release, [release_hash])
importer.execute
end
it 'imports draft releases' do
release_double = double(
name: 'Test',
body: 'This is description',
tag_name: '1.0',
description: 'This is my release',
created_at: created_at,
updated_at: created_at,
published_at: nil
)
expect(importer).to receive(:each_release).and_return([release_double])
expect { importer.execute }.to change { Release.count }.by(1)
end
it 'is idempotent' do
allow(importer).to receive(:each_release).and_return([github_release])
expect { importer.execute }.to change { Release.count }.by(1)
expect { importer.execute }.to change { Release.count }.by(0) # Idempotency check
end
end
describe '#build_releases' do
it 'returns an Array containing release rows' do
expect(importer).to receive(:each_release).and_return([github_release])
rows = importer.build_releases
expect(rows.length).to eq(1)
expect(rows[0][:tag]).to eq('1.0')
end
it 'does not create releases that already exist' do
create(:release, project: project, tag: '1.0', description: '1.0')
expect(importer).to receive(:each_release).and_return([github_release])
expect(importer.build_releases).to be_empty
end
it 'uses a default release description if none is provided' do
expect(github_release).to receive(:body).and_return('')
expect(importer).to receive(:each_release).and_return([github_release])
release = importer.build_releases.first
expect(release[:description]).to eq('Release for tag 1.0')
end
it 'does not create releases that have a NULL tag' do
null_tag_release = double(
name: 'NULL Test',
tag_name: nil
)
expect(importer).to receive(:each_release).and_return([null_tag_release])
expect(importer.build_releases).to be_empty
end
it 'does not create duplicate release tags' do
expect(importer).to receive(:each_release).and_return([github_release, github_release])
releases = importer.build_releases
expect(releases.length).to eq(1)
expect(releases[0][:description]).to eq('This is my release')
end
end
describe '#build' do
let(:release_hash) { importer.build(github_release) }
it 'returns the attributes of the release as a Hash' do
expect(release_hash).to be_an_instance_of(Hash)
end
context 'the returned Hash' do
it 'includes the tag name' do
expect(release_hash[:tag]).to eq('1.0')
end
it 'includes the release description' do
expect(release_hash[:description]).to eq('This is my release')
end
it 'includes the project ID' do
expect(release_hash[:project_id]).to eq(project.id)
end
it 'includes the created timestamp' do
expect(release_hash[:created_at]).to eq(created_at)
end
it 'includes the updated timestamp' do
expect(release_hash[:updated_at]).to eq(created_at)
end
it 'includes the release name' do
expect(release_hash[:name]).to eq(github_release_name)
end
end
end
describe '#each_release' do
let(:github_release) { double(:github_release) }
before do
allow(project).to receive(:import_source).and_return('foo/bar')
allow(client)
.to receive(:releases)
.with('foo/bar')
.and_return([github_release].to_enum)
end
it 'returns an Enumerator' do
expect(importer.each_release).to be_an_instance_of(Enumerator)
end
it 'yields every release to the Enumerator' do
expect(importer.each_release.next).to eq(github_release)
end
end
describe '#description_for' do
it 'returns the description when present' do
expect(importer.description_for(github_release)).to eq(github_release.body)
end
it 'returns a generated description when one is not present' do
allow(github_release).to receive(:body).and_return('')
expect(importer.description_for(github_release)).to eq('Release for tag 1.0')
end
end
end
|