1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe Gitlab::ImportExport::Project::ObjectBuilder do
let!(:group) { create(:group, :private) }
let!(:subgroup) { create(:group, :private, parent: group) }
let!(:project) do
create(
:project,
:repository,
:builds_disabled,
:issues_disabled,
name: 'project',
path: 'project',
group: subgroup
)
end
let(:lru_cache) { subject.send(:lru_cache) }
let(:cache_key) { subject.send(:cache_key) }
context 'request store is not active' do
subject do
described_class.new(Label, 'title' => 'group label', 'project' => project, 'group' => project.group)
end
it 'ignore cache initialize' do
expect(lru_cache).to be_nil
expect(cache_key).to be_nil
end
end
context 'request store is active', :request_store do
subject do
described_class.new(Label, 'title' => 'group label', 'project' => project, 'group' => project.group)
end
it 'initialize cache in memory' do
expect(lru_cache).not_to be_nil
expect(cache_key).not_to be_nil
end
it 'cache object when first time find the object' do
group_label = create(:group_label, name: 'group label', group: project.group)
expect(subject).to receive(:find_object).and_call_original
expect { subject.find }
.to change { lru_cache[cache_key] }
.from(nil).to(group_label)
expect(subject.find).to eq(group_label)
end
it 'read from cache when object has been cached' do
group_label = create(:group_label, name: 'group label', group: project.group)
subject.find
expect(subject).not_to receive(:find_object)
expect { subject.find }.not_to change { lru_cache[cache_key] }
expect(subject.find).to eq(group_label)
end
end
context 'labels' do
it 'finds the existing group label' do
group_label = create(:group_label, name: 'group label', group: project.group)
expect(described_class.build(
Label,
'title' => 'group label',
'project' => project,
'group' => project.group
)).to eq(group_label)
end
it 'finds the existing group label in root ancestor' do
group_label = create(:group_label, name: 'group label', group: group)
expect(described_class.build(
Label,
'title' => 'group label',
'project' => project,
'group' => group
)).to eq(group_label)
end
it 'creates a new project label' do
label = described_class.build(
Label,
'title' => 'group label',
'project' => project,
'group' => project.group,
'group_id' => project.group.id
)
expect(label.persisted?).to be true
expect(label).to be_an_instance_of(ProjectLabel)
expect(label.group_id).to be_nil
end
end
context 'milestones' do
it 'finds the existing group milestone' do
milestone = create(:milestone, name: 'group milestone', group: project.group)
expect(described_class.build(
Milestone,
'title' => 'group milestone',
'project' => project,
'group' => project.group
)).to eq(milestone)
end
it 'finds the existing group milestone in root ancestor' do
milestone = create(:milestone, name: 'group milestone', group: group)
expect(described_class.build(
Milestone,
'title' => 'group milestone',
'project' => project,
'group' => group
)).to eq(milestone)
end
it 'creates a new milestone' do
milestone = described_class.build(
Milestone,
'title' => 'group milestone',
'project' => project,
'group' => project.group
)
expect(milestone.persisted?).to be true
end
context 'with clashing iid' do
it 'creates milestone and claims iid for the new milestone' do
clashing_iid = 1
create(:milestone, iid: clashing_iid, project: project)
milestone = described_class.build(
Milestone,
'iid' => clashing_iid,
'title' => 'milestone',
'project' => project,
'group' => nil,
'group_id' => nil
)
expect(milestone.persisted?).to be true
expect(Milestone.count).to eq(2)
expect(milestone.iid).to eq(clashing_iid)
end
end
end
context 'work item types', :request_store, feature_category: :team_planning do
it 'returns the correct type by base type' do
task_type = described_class.new(WorkItems::Type, { 'base_type' => 'task' }).find
incident_type = described_class.new(WorkItems::Type, { 'base_type' => 'incident' }).find
default_type = described_class.new(WorkItems::Type, { 'base_type' => 'bad_input' }).find
expect(task_type).to eq(WorkItems::Type.default_by_type(:task))
expect(incident_type).to eq(WorkItems::Type.default_by_type(:incident))
expect(default_type).to eq(WorkItems::Type.default_by_type(:issue))
end
it 'caches the results' do
builder = described_class.new(WorkItems::Type, { 'base_type' => 'task' })
# Make sure finder works
expect(builder.find).to be_a(WorkItems::Type)
query_count = ActiveRecord::QueryRecorder.new(skip_cached: false) do
builder.find
end.count
expect(query_count).to be_zero
end
end
context 'merge_request' do
it 'finds the existing merge_request' do
merge_request = create(
:merge_request,
title: 'MergeRequest',
iid: 7,
target_project: project,
source_project: project
)
expect(described_class.build(
MergeRequest,
'title' => 'MergeRequest',
'source_project_id' => project.id,
'target_project_id' => project.id,
'source_branch' => 'SourceBranch',
'iid' => 7,
'target_branch' => 'TargetBranch',
'author_id' => project.creator.id
)).to eq(merge_request)
end
it 'creates a new merge_request' do
merge_request = described_class.build(
MergeRequest,
'title' => 'MergeRequest',
'iid' => 8,
'source_project_id' => project.id,
'target_project_id' => project.id,
'source_branch' => 'SourceBranch',
'target_branch' => 'TargetBranch',
'author_id' => project.creator.id
)
expect(merge_request.persisted?).to be true
end
end
context 'merge request diff commit users' do
it 'finds the existing user' do
user = MergeRequest::DiffCommitUser.find_or_create('Alice', 'alice@example.com')
found = described_class.build(
MergeRequest::DiffCommitUser,
'name' => 'Alice',
'email' => 'alice@example.com'
)
expect(found).to eq(user)
end
it 'creates a new user' do
found = described_class.build(
MergeRequest::DiffCommitUser,
'name' => 'Alice',
'email' => 'alice@example.com'
)
expect(found.name).to eq('Alice')
expect(found.email).to eq('alice@example.com')
end
end
context 'merge request diff commits' do
context 'when the "committer" object is present' do
it 'uses this object as the committer' do
user = MergeRequest::DiffCommitUser
.find_or_create('Alice', 'alice@example.com')
commit = described_class.build(
MergeRequestDiffCommit,
{
'committer' => user,
'committer_name' => 'Bla',
'committer_email' => 'bla@example.com',
'author_name' => 'Bla',
'author_email' => 'bla@example.com'
}
)
expect(commit.committer).to eq(user)
end
end
context 'when the "committer" object is missing' do
it 'creates one from the committer name and Email' do
commit = described_class.build(
MergeRequestDiffCommit,
{
'committer_name' => 'Alice',
'committer_email' => 'alice@example.com',
'author_name' => 'Alice',
'author_email' => 'alice@example.com'
}
)
expect(commit.committer.name).to eq('Alice')
expect(commit.committer.email).to eq('alice@example.com')
end
end
context 'when the "commit_author" object is present' do
it 'uses this object as the author' do
user = MergeRequest::DiffCommitUser
.find_or_create('Alice', 'alice@example.com')
commit = described_class.build(
MergeRequestDiffCommit,
{
'committer_name' => 'Alice',
'committer_email' => 'alice@example.com',
'commit_author' => user,
'author_name' => 'Bla',
'author_email' => 'bla@example.com'
}
)
expect(commit.commit_author).to eq(user)
end
end
context 'when the "commit_author" object is missing' do
it 'creates one from the author name and Email' do
commit = described_class.build(
MergeRequestDiffCommit,
{
'committer_name' => 'Alice',
'committer_email' => 'alice@example.com',
'author_name' => 'Alice',
'author_email' => 'alice@example.com'
}
)
expect(commit.commit_author.name).to eq('Alice')
expect(commit.commit_author.email).to eq('alice@example.com')
end
end
end
describe '#find_or_create_diff_commit_user' do
context 'when the user already exists' do
it 'returns the existing user' do
user = MergeRequest::DiffCommitUser
.find_or_create('Alice', 'alice@example.com')
found = described_class
.new(MergeRequestDiffCommit, {})
.send(:find_or_create_diff_commit_user, user.name, user.email)
expect(found).to eq(user)
end
end
context 'when the user does not exist' do
it 'creates the user' do
found = described_class
.new(MergeRequestDiffCommit, {})
.send(:find_or_create_diff_commit_user, 'Alice', 'alice@example.com')
expect(found.name).to eq('Alice')
expect(found.email).to eq('alice@example.com')
end
end
it 'caches the results' do
builder = described_class.new(MergeRequestDiffCommit, {})
builder.send(:find_or_create_diff_commit_user, 'Alice', 'alice@example.com')
record = ActiveRecord::QueryRecorder.new do
builder.send(:find_or_create_diff_commit_user, 'Alice', 'alice@example.com')
end
expect(record.count).to eq(1)
end
end
end
|