1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe Gitlab::Memory::UploadAndCleanupReports, :aggregate_failures do
let(:uploader) { instance_double(Gitlab::Memory::ReportsUploader) }
let(:logger) { instance_double(Gitlab::Memory::DiagnosticReportsLogger) }
describe '#initalize' do
let(:reports_path) { '/path/to/reports' }
context 'when sleep_time_seconds is passed through the environment' do
before do
stub_env('GITLAB_DIAGNOSTIC_REPORTS_UPLOADER_SLEEP_S', '600')
end
it 'initializes with these settings' do
upload_and_cleanup = described_class.new(uploader: uploader, reports_path: reports_path, logger: logger)
expect(upload_and_cleanup.sleep_time_seconds).to eq(600)
end
end
context 'when sleep_time_seconds is passed through the initializer' do
it 'initializes with these settings' do
upload_and_cleanup = described_class.new(uploader: uploader, reports_path: reports_path, sleep_time_seconds: 60,
logger: logger)
expect(upload_and_cleanup.sleep_time_seconds).to eq(60)
end
end
context 'when `sleep_time_seconds` is not passed' do
it 'initialized with the default' do
upload_and_cleanup = described_class.new(uploader: uploader, reports_path: reports_path, logger: logger)
expect(upload_and_cleanup.sleep_time_seconds).to eq(described_class::DEFAULT_SLEEP_TIME_SECONDS)
end
end
end
describe '#call' do
let(:upload_and_cleanup) do
described_class.new(sleep_time_seconds: 600, reports_path: dir, uploader: uploader,
logger: logger).tap do |instance|
allow(instance).to receive(:loop).and_yield
allow(instance).to receive(:sleep)
end
end
let(:dir) { Dir.mktmpdir }
let(:reports_count) { 3 }
let(:reports) do
(1..reports_count).map do |i|
Tempfile.new("report.1.worker_#{i}.#{Time.current.to_i}.json", dir)
end
end
after do
FileUtils.remove_entry(dir)
end
it 'invokes the uploader and cleans the files' do
expect(logger)
.to receive(:info)
.with(hash_including(:pid,
message: "Diagnostic reports",
class: 'Gitlab::Memory::UploadAndCleanupReports',
perf_report_status: 'started'))
reports.each do |report|
expect(upload_and_cleanup.uploader).to receive(:upload).with(report.path)
end
expect { upload_and_cleanup.call }
.to change { Dir.entries(dir).count { |e| e.match(/report.*/) } }
.from(reports_count).to(0)
end
context 'when there is an exception' do
let(:report) { Tempfile.new("report.1.worker_1.#{Time.current.to_i}.json", dir) }
it 'logs it and does not crash the loop' do
expect(logger)
.to receive(:info)
.with(hash_including(:pid,
message: "Diagnostic reports",
class: 'Gitlab::Memory::UploadAndCleanupReports',
perf_report_status: 'started'))
.ordered
expect(upload_and_cleanup.uploader)
.to receive(:upload)
.with(report.path)
.and_raise(StandardError, 'Error Message')
expect(logger)
.to receive(:error)
.with(hash_including(:pid, message: "Diagnostic reports", class: 'Gitlab::Memory::UploadAndCleanupReports',
perf_report_status: 'error', error: 'Error Message'))
.ordered
expect { upload_and_cleanup.call }.not_to raise_error
end
end
end
end
|
