1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe Gitlab::Redis::CrossSlot, feature_category: :redis do
describe '.pipelined' do
context 'when using redis client' do
before do
Gitlab::Redis::Queues.with { |redis| redis.set('a', 1) }
end
it 'performs redis-rb pipelined' do
expect(Gitlab::Redis::CrossSlot::Router).not_to receive(:new)
expect(
Gitlab::Instrumentation::RedisClusterValidator.allow_cross_slot_commands do
Gitlab::Redis::Queues.with do |redis|
described_class::Pipeline.new(redis).pipelined do |p|
p.get('a')
p.set('b', 1)
end
end
end
).to eq(%w[1 OK])
end
end
context 'when using with MultiStore' do
let(:multistore) do
Gitlab::Redis::MultiStore.new(
::Redis.new(::Gitlab::Redis::SharedState.params),
::Redis.new(::Gitlab::Redis::Sessions.params),
'testing')
end
before do
Gitlab::Redis::SharedState.with { |redis| redis.set('a', 1) }
Gitlab::Redis::Sessions.with { |redis| redis.set('a', 1) }
skip_feature_flags_yaml_validation
skip_default_enabled_yaml_check
end
it 'performs multistore pipelined' do
expect(Gitlab::Redis::CrossSlot::Router).not_to receive(:new)
expect(
Gitlab::Instrumentation::RedisClusterValidator.allow_cross_slot_commands do
described_class::Pipeline.new(multistore).pipelined do |p|
p.get('a')
p.set('b', 1)
end
end
).to eq(%w[1 OK])
end
end
context 'when using Redis::Cluster' do
# Only stub redis client internals since the CI pipeline does not run a Redis Cluster
let(:redis) { double(:redis) } # rubocop:disable RSpec/VerifiedDoubles
let(:client) { double(:client) } # rubocop:disable RSpec/VerifiedDoubles
let(:pipeline) { double(:pipeline) } # rubocop:disable RSpec/VerifiedDoubles
let(:arguments) { %w[a b c d] }
subject do
described_class::Pipeline.new(redis).pipelined do |p|
arguments.each { |key| p.get(key) }
end
end
before do
allow(redis).to receive(:_client).and_return(client)
allow(redis).to receive(:pipelined).and_yield(pipeline)
allow(client).to receive(:instance_of?).with(::Redis::Cluster).and_return(true)
end
it 'fan-out and fan-in commands to separate shards' do
# simulate fan-out to 3 shards with random order
expect(client).to receive(:_find_node_key).exactly(4).times.and_return(3, 2, 1, 3)
arguments.each do |key|
f = double('future') # rubocop:disable RSpec/VerifiedDoubles
expect(pipeline).to receive(:get).with(key).and_return(f)
expect(f).to receive(:value).and_return(key)
end
expect(subject).to eq(arguments)
end
shared_examples 'fallback on cross-slot' do |redirection|
context 'when redis cluster undergoing slot migration' do
before do
allow(pipeline).to receive(:get).and_raise(::Redis::CommandError.new("#{redirection} 1 127.0.0.1:7001"))
end
it 'logs error and executes sequentially' do
expect(client).to receive(:_find_node_key).exactly(4).times.and_return(3, 2, 1, 3)
expect(Gitlab::ErrorTracking).to receive(:log_exception).with(an_instance_of(::Redis::CommandError))
arguments.each do |key|
expect(redis).to receive(:get).with(key).and_return(key)
end
subject
end
end
end
it_behaves_like 'fallback on cross-slot', 'MOVED'
it_behaves_like 'fallback on cross-slot', 'ASK'
context 'when receiving non-MOVED/ASK command errors' do
before do
allow(pipeline).to receive(:get).and_raise(::Redis::CommandError.new)
allow(client).to receive(:_find_node_key).exactly(4).times.and_return(3, 2, 1, 3)
end
it 'raises error' do
expect { subject }.to raise_error(::Redis::CommandError)
end
end
end
end
end
|
