blob: 96151de1148015dffbbb86bfd0d5b2576131bc15 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
|
# frozen_string_literal: true
require 'spec_helper'
require_migration!
RSpec.describe SwapNotesIdToBigintForSelfManaged, feature_category: :database do
let(:connection) { described_class.new.connection }
shared_examples 'column `id_convert_to_bigint` is already dropped' do
before do
connection.execute('ALTER TABLE notes ALTER COLUMN id TYPE bigint')
connection.execute('ALTER TABLE notes DROP COLUMN IF EXISTS id_convert_to_bigint')
end
after do
connection.execute('ALTER TABLE notes DROP COLUMN IF EXISTS id_convert_to_bigint')
end
it 'does not swaps the columns' do
disable_migrations_output do
reversible_migration do |migration|
migration.before -> {
notes_table.reset_column_information
expect(notes_table.columns.find { |c| c.name == 'id' }.sql_type).to eq('bigint')
expect(notes_table.columns.find { |c| c.name == 'id_convert_to_bigint' }).to be_nil
}
migration.after -> {
notes_table.reset_column_information
expect(notes_table.columns.find { |c| c.name == 'id' }.sql_type).to eq('bigint')
expect(notes_table.columns.find { |c| c.name == 'id_convert_to_bigint' }).to be_nil
}
end
end
end
end
describe '#up' do
let!(:notes_table) { table(:notes) }
before do
# rubocop:disable RSpec/AnyInstanceOf
allow_any_instance_of(described_class).to(
receive(:com_or_dev_or_test_but_not_jh?).and_return(com_or_dev_or_test_but_not_jh?)
)
# rubocop:enable RSpec/AnyInstanceOf
end
context 'when GitLab.com, dev, or test' do
let(:com_or_dev_or_test_but_not_jh?) { true }
it_behaves_like 'column `id_convert_to_bigint` is already dropped'
end
context 'when self-managed instance with the `id_convert_to_bigint` column already dropped' do
let(:com_or_dev_or_test_but_not_jh?) { false }
it_behaves_like 'column `id_convert_to_bigint` is already dropped'
end
context 'when self-managed instance columns already swapped' do
let(:com_or_dev_or_test_but_not_jh?) { false }
before do
connection.execute('ALTER TABLE notes ALTER COLUMN id TYPE bigint')
connection.execute('ALTER TABLE notes ADD COLUMN IF NOT EXISTS id_convert_to_bigint integer')
disable_migrations_output { migrate! }
end
after do
connection.execute('ALTER TABLE notes DROP COLUMN IF EXISTS id_convert_to_bigint')
end
it 'does not swaps the columns' do
expect(notes_table.columns.find { |c| c.name == 'id' }.sql_type).to eq('bigint')
expect(notes_table.columns.find { |c| c.name == 'id_convert_to_bigint' }.sql_type).to eq('integer')
end
end
context 'when self-managed instance' do
let(:com_or_dev_or_test_but_not_jh?) { false }
before do
connection.execute('ALTER TABLE notes ALTER COLUMN id TYPE integer')
connection.execute('ALTER TABLE notes ADD COLUMN IF NOT EXISTS id_convert_to_bigint bigint')
connection.execute('ALTER TABLE notes ALTER COLUMN id_convert_to_bigint TYPE bigint')
connection.execute('DROP INDEX IF EXISTS index_notes_on_id_convert_to_bigint CASCADE')
connection.execute('CREATE OR REPLACE FUNCTION trigger_080e73845bfd() RETURNS trigger LANGUAGE plpgsql AS $$
BEGIN NEW."id_convert_to_bigint" := NEW."id"; RETURN NEW; END; $$;')
end
after do
connection.execute('ALTER TABLE notes DROP COLUMN IF EXISTS id_convert_to_bigint')
end
it 'swaps the columns' do
disable_migrations_output do
reversible_migration do |migration|
migration.before -> {
notes_table.reset_column_information
expect(notes_table.columns.find { |c| c.name == 'id' }.sql_type).to eq('integer')
expect(notes_table.columns.find { |c| c.name == 'id_convert_to_bigint' }.sql_type).to eq('bigint')
}
migration.after -> {
notes_table.reset_column_information
expect(notes_table.columns.find { |c| c.name == 'id' }.sql_type).to eq('bigint')
expect(notes_table.columns.find { |c| c.name == 'id_convert_to_bigint' }.sql_type).to eq('integer')
}
end
end
end
context 'when having different naming for fk_d83a918cb1 foreign key' do
before do
connection.execute('ALTER TABLE system_note_metadata DROP CONSTRAINT IF EXISTS fk_d83a918cb1')
connection.execute('ALTER TABLE system_note_metadata DROP CONSTRAINT IF EXISTS fk_rails_d83a918cb1')
connection.execute('ALTER TABLE system_note_metadata ADD CONSTRAINT fk_rails_d83a918cb1 FOREIGN KEY (note_id)
REFERENCES notes(id) ON DELETE CASCADE')
end
after do
connection.execute('ALTER TABLE system_note_metadata DROP CONSTRAINT IF EXISTS fk_rails_d83a918cb1')
connection.execute('ALTER TABLE system_note_metadata DROP CONSTRAINT IF EXISTS fk_d83a918cb1_tmp')
connection.execute('ALTER TABLE system_note_metadata ADD CONSTRAINT fk_d83a918cb1 FOREIGN KEY (note_id)
REFERENCES notes(id) ON DELETE CASCADE')
end
it 'swaps the columns' do
disable_migrations_output do
reversible_migration do |migration|
migration.before -> {
notes_table.reset_column_information
expect(notes_table.columns.find { |c| c.name == 'id' }.sql_type).to eq('integer')
expect(notes_table.columns.find { |c| c.name == 'id_convert_to_bigint' }.sql_type).to eq('bigint')
}
migration.after -> {
notes_table.reset_column_information
expect(notes_table.columns.find { |c| c.name == 'id' }.sql_type).to eq('bigint')
expect(notes_table.columns.find { |c| c.name == 'id_convert_to_bigint' }.sql_type).to eq('integer')
}
end
end
end
end
end
end
end
|
