blob: c1aa2d4daec2a77192dd68beef78e33b6bb2b26f (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
|
# frozen_string_literal: true
require 'spec_helper'
require_migration!
RSpec.describe SwapVulnerabilityUserMentionsNoteIdToBigintForSelfHosts, feature_category: :database do
let(:connection) { described_class.new.connection }
let(:vulnerability_user_mentions) { table(:vulnerability_user_mentions) }
shared_examples 'column `note_id_convert_to_bigint` is already dropped' do
before do
connection.execute('ALTER TABLE vulnerability_user_mentions ALTER COLUMN note_id TYPE bigint')
connection.execute('ALTER TABLE vulnerability_user_mentions DROP COLUMN IF EXISTS note_id_convert_to_bigint')
end
it 'does not swaps the columns' do
disable_migrations_output do
reversible_migration do |migration|
migration.before -> {
vulnerability_user_mentions.reset_column_information
expect(vulnerability_user_mentions.columns.find { |c| c.name == 'note_id' }.sql_type).to eq('bigint')
expect(vulnerability_user_mentions.columns.find { |c| c.name == 'note_id_convert_to_bigint' }).to be_nil
}
migration.after -> {
vulnerability_user_mentions.reset_column_information
expect(vulnerability_user_mentions.columns.find { |c| c.name == 'note_id' }.sql_type).to eq('bigint')
expect(vulnerability_user_mentions.columns.find { |c| c.name == 'note_id_convert_to_bigint' }).to be_nil
}
end
end
end
end
describe '#up' do
before do
# rubocop:disable RSpec/AnyInstanceOf
allow_any_instance_of(described_class).to(
receive(:com_or_dev_or_test_but_not_jh?).and_return(com_or_dev_or_test_but_not_jh?)
)
# rubocop:enable RSpec/AnyInstanceOf
end
context 'when GitLab.com, dev, or test' do
let(:com_or_dev_or_test_but_not_jh?) { true }
it_behaves_like 'column `note_id_convert_to_bigint` is already dropped'
end
context 'when self-managed instance with the `note_id_convert_to_bigint` column already dropped' do
let(:com_or_dev_or_test_but_not_jh?) { false }
it_behaves_like 'column `note_id_convert_to_bigint` is already dropped'
end
context 'when self-managed instance columns already swapped' do
let(:com_or_dev_or_test_but_not_jh?) { false }
before do
connection.execute('ALTER TABLE vulnerability_user_mentions ALTER COLUMN note_id TYPE bigint')
connection.execute(
'ALTER TABLE vulnerability_user_mentions ADD COLUMN IF NOT EXISTS note_id_convert_to_bigint integer'
)
disable_migrations_output { migrate! }
end
after do
connection.execute('ALTER TABLE vulnerability_user_mentions DROP COLUMN IF EXISTS note_id_convert_to_bigint')
end
it 'does not swaps the columns' do
expect(vulnerability_user_mentions.columns.find { |c| c.name == 'note_id' }.sql_type).to eq('bigint')
expect(vulnerability_user_mentions.columns.find { |c| c.name == 'note_id_convert_to_bigint' }.sql_type).to(
eq('integer')
)
end
end
context 'when self-managed instance' do
let(:com_or_dev_or_test_but_not_jh?) { false }
before do
connection.execute('ALTER TABLE vulnerability_user_mentions ALTER COLUMN note_id TYPE integer')
connection.execute(
'ALTER TABLE vulnerability_user_mentions ADD COLUMN IF NOT EXISTS note_id_convert_to_bigint bigint'
)
connection.execute('ALTER TABLE vulnerability_user_mentions ALTER COLUMN note_id_convert_to_bigint TYPE bigint')
connection.execute(
'DROP INDEX IF EXISTS index_vulnerability_user_mentions_on_note_id_convert_to_bigint CASCADE'
)
connection.execute('CREATE OR REPLACE FUNCTION trigger_0e214b8a14f2() RETURNS trigger LANGUAGE plpgsql AS $$
BEGIN NEW."note_id_convert_to_bigint" := NEW."note_id"; RETURN NEW; END; $$;')
end
after do
connection.execute('ALTER TABLE vulnerability_user_mentions DROP COLUMN IF EXISTS note_id_convert_to_bigint')
end
it 'swaps the columns' do
disable_migrations_output do
reversible_migration do |migration|
migration.before -> {
vulnerability_user_mentions.reset_column_information
expect(vulnerability_user_mentions.columns.find do |c|
c.name == 'note_id'
end.sql_type).to eq('integer')
expect(vulnerability_user_mentions.columns.find do |c|
c.name == 'note_id_convert_to_bigint'
end.sql_type).to(
eq('bigint')
)
}
migration.after -> {
vulnerability_user_mentions.reset_column_information
expect(vulnerability_user_mentions.columns.find { |c| c.name == 'note_id' }.sql_type).to eq('bigint')
expect(vulnerability_user_mentions.columns.find do |c|
c.name == 'note_id_convert_to_bigint'
end.sql_type).to(
eq('integer')
)
}
end
end
end
end
end
end
|
