1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe BulkImports::Entity, type: :model, feature_category: :importers do
describe 'associations' do
it { is_expected.to belong_to(:bulk_import).required }
it { is_expected.to belong_to(:parent) }
it { is_expected.to belong_to(:group) }
it { is_expected.to belong_to(:project) }
end
describe 'validations' do
it { is_expected.to validate_presence_of(:source_type) }
it { is_expected.to validate_presence_of(:source_full_path) }
it { is_expected.to validate_presence_of(:destination_name) }
it { is_expected.to define_enum_for(:source_type).with_values(%i[group_entity project_entity]) }
context 'when formatting with regexes' do
subject { described_class.new(group: Group.new) }
it { is_expected.to allow_values('namespace', 'parent/namespace', 'parent/group/subgroup', '').for(:destination_namespace) }
it { is_expected.not_to allow_values('parent/namespace/', '/namespace', 'parent group/subgroup', '@namespace').for(:destination_namespace) }
it { is_expected.to allow_values('source', 'source/path', 'source/full/path').for(:source_full_path) }
it { is_expected.not_to allow_values('/source', 'http://source/path', 'sou rce/full/path', '').for(:source_full_path) }
it { is_expected.to allow_values('destination', 'destination-slug', 'new-destination-slug').for(:destination_slug) }
# it { is_expected.not_to allow_values('destination/slug', '/destination-slug', 'destination slug').for(:destination_slug) } <-- this test should
# succeed but it's failing possibly due to rspec caching. To ensure this case is covered see the more cumbersome test below:
context 'when destination_slug is invalid' do
let(:invalid_slugs) { ['destination/slug', '/destination-slug', 'destination slug'] }
let(:error_message) do
'cannot start with a non-alphanumeric character except for periods or underscores, ' \
'can contain only alphanumeric characters, periods, and underscores, ' \
'cannot end with a period or forward slash, and has no ' \
'leading or trailing forward slashes'
end
it 'raises an error' do
invalid_slugs.each do |slug|
entity = build(:bulk_import_entity, :group_entity, group: build(:group), project: nil, destination_slug: slug)
expect(entity).not_to be_valid
expect(entity.errors.errors[0].message).to include(error_message)
end
end
end
end
context 'when associated with a group and project' do
it 'is invalid' do
entity = build(:bulk_import_entity, group: build(:group), project: build(:project))
expect(entity).not_to be_valid
expect(entity.errors).to include(:project, :group)
end
end
context 'when not associated with a group or project' do
it 'is valid' do
entity = build(:bulk_import_entity, group: nil, project: nil)
expect(entity).to be_valid
end
end
context 'when associated with a group and no project' do
it 'is valid as a group_entity' do
entity = build(:bulk_import_entity, :group_entity, group: build(:group), project: nil)
expect(entity).to be_valid
end
it 'is valid when destination_namespace is empty' do
entity = build(:bulk_import_entity, :group_entity, group: build(:group), project: nil, destination_namespace: '')
expect(entity).to be_valid
end
it 'is invalid when destination_namespace is nil' do
entity = build(:bulk_import_entity, :group_entity, group: build(:group), project: nil, destination_namespace: nil)
expect(entity).not_to be_valid
end
it 'is invalid when destination_slug is empty' do
entity = build(:bulk_import_entity, :group_entity, group: build(:group), project: nil, destination_slug: '')
expect(entity).not_to be_valid
end
it 'is invalid when destination_slug is nil' do
entity = build(:bulk_import_entity, :group_entity, group: build(:group), project: nil, destination_slug: nil)
expect(entity).not_to be_valid
end
it 'is invalid as a project_entity' do
stub_feature_flags(bulk_import_projects: true)
entity = build(:bulk_import_entity, :project_entity, group: build(:group), project: nil)
expect(entity).not_to be_valid
expect(entity.errors).to include(:group)
end
end
context 'when associated with a project and no group' do
it 'is valid' do
stub_feature_flags(bulk_import_projects: true)
entity = build(:bulk_import_entity, :project_entity, group: nil, project: build(:project))
expect(entity).to be_valid
end
it 'is invalid when destination_namespace is nil' do
entity = build(:bulk_import_entity, :group_entity, group: build(:group), project: nil, destination_namespace: nil)
expect(entity).not_to be_valid
expect(entity.errors).to include(:destination_namespace)
end
it 'is invalid as a project_entity' do
entity = build(:bulk_import_entity, :group_entity, group: nil, project: build(:project))
expect(entity).not_to be_valid
expect(entity.errors).to include(:project)
end
end
context 'when the parent is a group import' do
it 'is valid' do
entity = build(:bulk_import_entity, parent: build(:bulk_import_entity, :group_entity))
expect(entity).to be_valid
end
end
context 'when the parent is a project import' do
it 'is invalid' do
stub_feature_flags(bulk_import_projects: true)
entity = build(:bulk_import_entity, parent: build(:bulk_import_entity, :project_entity))
expect(entity).not_to be_valid
expect(entity.errors).to include(:parent)
end
end
context 'validate destination namespace of a group_entity' do
it 'is invalid if destination namespace is the source namespace' do
group_a = create(:group, path: 'group_a')
entity = build(
:bulk_import_entity,
:group_entity,
source_full_path: group_a.full_path,
destination_namespace: group_a.full_path
)
expect(entity).not_to be_valid
expect(entity.errors).to include(:base)
expect(entity.errors[:base])
.to include('Import failed: Destination cannot be a subgroup of the source group. Change the destination and try again.')
end
it 'is invalid if destination namespace is a descendant of the source' do
group_a = create(:group, path: 'group_a')
group_b = create(:group, parent: group_a, path: 'group_b')
entity = build(
:bulk_import_entity,
:group_entity,
source_full_path: group_a.full_path,
destination_namespace: group_b.full_path
)
expect(entity).not_to be_valid
expect(entity.errors[:base])
.to include('Import failed: Destination cannot be a subgroup of the source group. Change the destination and try again.')
end
end
context 'when bulk_import_projects feature flag is disabled and source_type is a project_entity' do
it 'is invalid' do
stub_feature_flags(bulk_import_projects: false)
entity = build(:bulk_import_entity, :project_entity)
expect(entity).not_to be_valid
expect(entity.errors[:base]).to include('invalid entity source type')
end
end
context 'when bulk_import_projects feature flag is enabled and source_type is a project_entity' do
it 'is valid' do
stub_feature_flags(bulk_import_projects: true)
entity = build(:bulk_import_entity, :project_entity)
expect(entity).to be_valid
end
end
context 'when bulk_import_projects feature flag is enabled on root ancestor level and source_type is a project_entity' do
it 'is valid' do
top_level_namespace = create(:group)
stub_feature_flags(bulk_import_projects: top_level_namespace)
entity = build(:bulk_import_entity, :project_entity, destination_namespace: top_level_namespace.full_path)
expect(entity).to be_valid
end
end
end
describe '#encoded_source_full_path' do
it 'encodes entity source full path' do
expected = 'foo%2Fbar'
entity = build(:bulk_import_entity, source_full_path: 'foo/bar')
expect(entity.encoded_source_full_path).to eq(expected)
end
end
describe 'scopes' do
describe '.by_user_id' do
it 'returns entities associated with specified user' do
user = create(:user)
import = create(:bulk_import, user: user)
entity_1 = create(:bulk_import_entity, bulk_import: import)
entity_2 = create(:bulk_import_entity, bulk_import: import)
create(:bulk_import_entity)
expect(described_class.by_user_id(user.id)).to contain_exactly(entity_1, entity_2)
end
end
end
describe '.all_human_statuses' do
it 'returns all human readable entity statuses' do
expect(described_class.all_human_statuses).to contain_exactly('created', 'started', 'finished', 'failed', 'timeout')
end
end
describe '#pipelines' do
context 'when entity is group' do
it 'returns group pipelines' do
entity = build(:bulk_import_entity, :group_entity)
expect(entity.pipelines.collect { _1[:pipeline] }).to include(BulkImports::Groups::Pipelines::GroupPipeline)
end
end
context 'when entity is project' do
it 'returns project pipelines' do
entity = build(:bulk_import_entity, :project_entity)
expect(entity.pipelines.collect { _1[:pipeline] }).to include(BulkImports::Projects::Pipelines::ProjectPipeline)
end
end
end
describe '#pipeline_exists?' do
let_it_be(:entity) { create(:bulk_import_entity, :group_entity) }
it 'returns true when the given pipeline name exists in the pipelines list' do
expect(entity.pipeline_exists?(BulkImports::Groups::Pipelines::GroupPipeline)).to eq(true)
expect(entity.pipeline_exists?('BulkImports::Groups::Pipelines::GroupPipeline')).to eq(true)
end
it 'returns false when the given pipeline name exists in the pipelines list' do
expect(entity.pipeline_exists?('BulkImports::Groups::Pipelines::InexistentPipeline')).to eq(false)
end
end
describe '#pluralized_name' do
context 'when entity is group' do
it 'returns groups' do
entity = build(:bulk_import_entity, :group_entity)
expect(entity.pluralized_name).to eq('groups')
end
end
context 'when entity is project' do
it 'returns projects' do
entity = build(:bulk_import_entity, :project_entity)
expect(entity.pluralized_name).to eq('projects')
end
end
end
describe '#export_relations_url_path' do
context 'when entity is group' do
it 'returns group export relations url' do
entity = build(:bulk_import_entity, :group_entity)
expect(entity.export_relations_url_path).to eq("/groups/#{entity.source_xid}/export_relations")
end
end
context 'when entity is project' do
it 'returns project export relations url' do
entity = build(:bulk_import_entity, :project_entity)
expect(entity.export_relations_url_path).to eq("/projects/#{entity.source_xid}/export_relations")
end
end
end
describe '#relation_download_url_path' do
it 'returns export relations url with download query string' do
entity = build(:bulk_import_entity)
expect(entity.relation_download_url_path('test'))
.to eq("/groups/#{entity.source_xid}/export_relations/download?relation=test")
end
end
describe '#entity_type' do
it 'returns entity type' do
group_entity = build(:bulk_import_entity)
project_entity = build(:bulk_import_entity, :project_entity)
expect(group_entity.entity_type).to eq('group')
expect(project_entity.entity_type).to eq('project')
end
end
describe '#project?' do
it 'returns true if project entity' do
group_entity = build(:bulk_import_entity)
project_entity = build(:bulk_import_entity, :project_entity)
expect(group_entity.project?).to eq(false)
expect(project_entity.project?).to eq(true)
end
end
describe '#group?' do
it 'returns true if group entity' do
group_entity = build(:bulk_import_entity)
project_entity = build(:bulk_import_entity, :project_entity)
expect(group_entity.group?).to eq(true)
expect(project_entity.group?).to eq(false)
end
end
describe '#base_resource_url_path' do
it 'returns base entity url path' do
entity = build(:bulk_import_entity, source_xid: nil)
expect(entity.base_resource_path).to eq("/groups/#{entity.encoded_source_full_path}")
end
end
describe '#wiki_url_path' do
it 'returns entity wiki url path' do
entity = build(:bulk_import_entity, source_xid: nil)
expect(entity.wikis_url_path).to eq("/groups/#{entity.encoded_source_full_path}/wikis")
end
end
describe '#update_service' do
it 'returns correct update service class' do
group_entity = build(:bulk_import_entity)
project_entity = build(:bulk_import_entity, :project_entity)
expect(group_entity.update_service).to eq(::Groups::UpdateService)
expect(project_entity.update_service).to eq(::Projects::UpdateService)
end
end
describe '#full_path' do
it 'returns group full path for project entity' do
group_entity = build(:bulk_import_entity, :group_entity, group: build(:group))
expect(group_entity.full_path).to eq(group_entity.group.full_path)
end
it 'returns project full path for project entity' do
project_entity = build(:bulk_import_entity, :project_entity, project: build(:project))
expect(project_entity.full_path).to eq(project_entity.project.full_path)
end
it 'returns nil when not associated with group or project' do
entity = build(:bulk_import_entity, group: nil, project: nil)
expect(entity.full_path).to eq(nil)
end
end
describe '#default_visibility_level' do
context 'when entity is a group' do
it 'returns default group visibility' do
stub_application_setting(default_group_visibility: Gitlab::VisibilityLevel::PUBLIC)
entity = build(:bulk_import_entity, :group_entity, group: build(:group))
expect(entity.default_visibility_level).to eq(Gitlab::VisibilityLevel::PUBLIC)
end
end
context 'when entity is a project' do
it 'returns default project visibility' do
stub_application_setting(default_project_visibility: Gitlab::VisibilityLevel::INTERNAL)
entity = build(:bulk_import_entity, :project_entity, group: build(:group))
expect(entity.default_visibility_level).to eq(Gitlab::VisibilityLevel::INTERNAL)
end
end
end
end
|