1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe Ci::PipelineArtifact, type: :model do
let(:coverage_report) { create(:ci_pipeline_artifact, :with_coverage_report) }
describe 'associations' do
it { is_expected.to belong_to(:pipeline) }
it { is_expected.to belong_to(:project) }
end
it_behaves_like 'having unique enum values'
it_behaves_like 'UpdateProjectStatistics' do
let_it_be(:pipeline, reload: true) { create(:ci_pipeline) }
subject { build(:ci_pipeline_artifact, :with_code_coverage_with_multiple_files, pipeline: pipeline) }
end
describe 'validations' do
it { is_expected.to validate_presence_of(:pipeline) }
it { is_expected.to validate_presence_of(:project) }
it { is_expected.to validate_presence_of(:file_type) }
it { is_expected.to validate_presence_of(:file_format) }
it { is_expected.to validate_presence_of(:size) }
it { is_expected.to validate_presence_of(:file) }
context 'when attributes are valid' do
it 'returns no errors' do
expect(coverage_report).to be_valid
end
end
context 'when file_store is invalid' do
it 'returns errors' do
coverage_report.file_store = 0
expect(coverage_report).to be_invalid
expect(coverage_report.errors.full_messages).to eq(["File store is not included in the list"])
end
end
context 'when size is over 10 megabytes' do
it 'returns errors' do
coverage_report.size = 11.megabytes
expect(coverage_report).to be_invalid
end
end
end
describe 'scopes' do
describe '.unlocked' do
subject(:pipeline_artifacts) { described_class.unlocked }
context 'when pipeline is locked' do
it 'returns an empty collection' do
expect(pipeline_artifacts).to be_empty
end
end
context 'when pipeline is unlocked' do
before do
create(:ci_pipeline_artifact, :with_coverage_report)
end
it 'returns unlocked artifacts' do
codequality_report = create(:ci_pipeline_artifact, :with_codequality_mr_diff_report, :unlocked)
expect(pipeline_artifacts).to eq([codequality_report])
end
end
end
end
describe 'file is being stored' do
subject { create(:ci_pipeline_artifact, :with_coverage_report) }
context 'when existing object has local store' do
it_behaves_like 'mounted file in local store'
end
context 'when direct upload is enabled' do
before do
stub_artifacts_object_storage(Ci::PipelineArtifactUploader, direct_upload: true)
end
context 'when file is stored' do
it_behaves_like 'mounted file in object store'
end
end
context 'when file contains multi-byte characters' do
let(:coverage_report_multibyte) { create(:ci_pipeline_artifact, :with_coverage_multibyte_characters) }
it 'sets the size in bytesize' do
expect(coverage_report_multibyte.size).to eq(14)
end
end
end
describe '.report_exists?' do
subject(:pipeline_artifact) { Ci::PipelineArtifact.report_exists?(file_type) }
context 'when file_type is code_coverage' do
let(:file_type) { :code_coverage }
context 'when pipeline artifact has a coverage report' do
let!(:pipeline_artifact) { create(:ci_pipeline_artifact, :with_coverage_report) }
it 'returns true' do
expect(pipeline_artifact).to be_truthy
end
end
context 'when pipeline artifact does not have a coverage report' do
it 'returns false' do
expect(pipeline_artifact).to be_falsey
end
end
end
context 'when file_type is code_quality_mr_diff' do
let(:file_type) { :code_quality_mr_diff }
context 'when pipeline artifact has a codequality mr diff report' do
let!(:pipeline_artifact) { create(:ci_pipeline_artifact, :with_codequality_mr_diff_report) }
it 'returns true' do
expect(pipeline_artifact).to be_truthy
end
end
context 'when pipeline artifact does not have a codequality mr diff report' do
it 'returns false' do
expect(pipeline_artifact).to be_falsey
end
end
end
context 'when file_type is nil' do
let(:file_type) { nil }
it 'returns false' do
expect(pipeline_artifact).to be_falsey
end
end
end
describe '.find_by_file_type' do
subject(:pipeline_artifact) { Ci::PipelineArtifact.find_by_file_type(file_type) }
context 'when file_type is code_coverage' do
let(:file_type) { :code_coverage }
context 'when pipeline artifact has a coverage report' do
let!(:coverage_report) { create(:ci_pipeline_artifact, :with_coverage_report) }
it 'returns a pipeline artifact with a coverage report' do
expect(pipeline_artifact.file_type).to eq('code_coverage')
end
end
context 'when pipeline artifact does not have a coverage report' do
it 'returns nil' do
expect(pipeline_artifact).to be_nil
end
end
end
context 'when file_type is code_quality_mr_diff' do
let(:file_type) { :code_quality_mr_diff }
context 'when pipeline artifact has a quality report' do
let!(:coverage_report) { create(:ci_pipeline_artifact, :with_codequality_mr_diff_report) }
it 'returns a pipeline artifact with a quality report' do
expect(pipeline_artifact.file_type).to eq('code_quality_mr_diff')
end
end
context 'when pipeline artifact does not have a quality report' do
it 'returns nil' do
expect(pipeline_artifact).to be_nil
end
end
end
context 'when file_type is nil' do
let(:file_type) { nil }
it 'returns nil' do
expect(pipeline_artifact).to be_nil
end
end
end
describe '.create_or_replace_for_pipeline!' do
let_it_be(:pipeline) { create(:ci_empty_pipeline) }
let(:file_type) { :code_coverage }
let(:file) { CarrierWaveStringFile.new_file(file_content: 'content', filename: 'file.json', content_type: 'json') }
let(:size) { file['tempfile'].size }
subject do
Ci::PipelineArtifact.create_or_replace_for_pipeline!(
pipeline: pipeline,
file_type: file_type,
file: file,
size: size
)
end
around do |example|
freeze_time { example.run }
end
context 'when there is no existing record' do
it 'creates a new pipeline artifact for the given parameters' do
expect { subject }.to change { Ci::PipelineArtifact.count }.from(0).to(1)
expect(subject.code_coverage?).to be(true)
expect(subject.pipeline).to eq(pipeline)
expect(subject.project_id).to eq(pipeline.project_id)
expect(subject.file.filename).to eq(file['filename'])
expect(subject.size).to eq(size)
expect(subject.file_format).to eq(Ci::PipelineArtifact::REPORT_TYPES[file_type].to_s)
expect(subject.expire_at).to eq(Ci::PipelineArtifact::EXPIRATION_DATE.from_now)
expect(subject.locked).to eq('unknown')
end
it "creates a new pipeline artifact with pipeline's locked state" do
artifact = Ci::PipelineArtifact.create_or_replace_for_pipeline!(
pipeline: pipeline,
file_type: file_type,
file: file,
size: size,
locked: pipeline.locked
)
expect(artifact.locked).to eq(pipeline.locked)
end
end
context 'when there are existing records with different types' do
let!(:existing_artifact) do
create(:ci_pipeline_artifact, pipeline: pipeline, file_type: file_type, expire_at: 1.day.from_now)
end
let!(:other_artifact) { create(:ci_pipeline_artifact, pipeline: pipeline, file_type: :code_quality_mr_diff) }
it 'replaces the existing pipeline artifact record with the given file type' do
expect { subject }.not_to change { Ci::PipelineArtifact.count }
expect(subject.id).not_to eq(existing_artifact.id)
expect(subject.code_coverage?).to be(true)
expect(subject.pipeline).to eq(pipeline)
expect(subject.project_id).to eq(pipeline.project_id)
expect(subject.file.filename).to eq(file['filename'])
expect(subject.size).to eq(size)
expect(subject.file_format).to eq(Ci::PipelineArtifact::REPORT_TYPES[file_type].to_s)
expect(subject.expire_at).to eq(Ci::PipelineArtifact::EXPIRATION_DATE.from_now)
end
end
context 'when ActiveRecordError is raised' do
let(:pipeline) { instance_double(Ci::Pipeline, id: 1) }
let(:file_type) { :code_coverage }
let(:error) { ActiveRecord::ActiveRecordError.new('something went wrong') }
before do
allow(pipeline).to receive(:pipeline_artifacts).and_raise(error)
end
it 'tracks and raise the exception' do
expect(Gitlab::ErrorTracking).to receive(:track_and_raise_exception)
.with(error, { pipeline_id: pipeline.id, file_type: file_type }).and_call_original
expect { subject }.to raise_error(ActiveRecord::ActiveRecordError, 'something went wrong')
end
end
end
describe '#present' do
subject(:presenter) { report.present }
context 'when file_type is code_coverage' do
let(:report) { coverage_report }
it 'uses code coverage presenter' do
expect(presenter).to be_kind_of(Ci::PipelineArtifacts::CodeCoveragePresenter)
end
end
context 'when file_type is code_quality_mr_diff' do
let(:report) { create(:ci_pipeline_artifact, :with_codequality_mr_diff_report) }
it 'uses code codequality mr diff presenter' do
expect(presenter).to be_kind_of(Ci::PipelineArtifacts::CodeQualityMrDiffPresenter)
end
end
end
context 'loose foreign key on ci_pipeline_artifacts.project_id' do
it_behaves_like 'cleanup by a loose foreign key' do
let!(:parent) { create(:project) }
let!(:model) { create(:ci_pipeline_artifact, project: parent) }
end
end
end
|