1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe Clusters::Agent, feature_category: :deployment_management do
subject { create(:cluster_agent) }
it { is_expected.to belong_to(:created_by_user).class_name('User').optional }
it { is_expected.to belong_to(:project).class_name('::Project') }
it { is_expected.to have_many(:agent_tokens).class_name('Clusters::AgentToken').order(Clusters::AgentToken.arel_table[:last_used_at].desc.nulls_last) }
it { is_expected.to have_many(:active_agent_tokens).class_name('Clusters::AgentToken').conditions(status: 0).order(Clusters::AgentToken.arel_table[:last_used_at].desc.nulls_last) }
it { is_expected.to have_many(:ci_access_group_authorizations).class_name('Clusters::Agents::Authorizations::CiAccess::GroupAuthorization') }
it { is_expected.to have_many(:ci_access_authorized_groups).through(:ci_access_group_authorizations) }
it { is_expected.to have_many(:ci_access_project_authorizations).class_name('Clusters::Agents::Authorizations::CiAccess::ProjectAuthorization') }
it { is_expected.to have_many(:ci_access_authorized_projects).through(:ci_access_project_authorizations).class_name('::Project') }
it { is_expected.to have_many(:environments).class_name('::Environment') }
it { is_expected.to validate_presence_of(:name) }
it { is_expected.to validate_length_of(:name).is_at_most(63) }
it { is_expected.to validate_uniqueness_of(:name).scoped_to(:project_id) }
describe 'scopes' do
describe '.ordered_by_name' do
let(:names) { %w(agent-d agent-b agent-a agent-c) }
subject { described_class.ordered_by_name }
before do
names.each do |name|
create(:cluster_agent, name: name)
end
end
it { expect(subject.map(&:name)).to eq(names.sort) }
end
describe '.with_name' do
let!(:matching_name) { create(:cluster_agent, name: 'matching-name') }
let!(:other_name) { create(:cluster_agent, name: 'other-name') }
subject { described_class.with_name(matching_name.name) }
it { is_expected.to contain_exactly(matching_name) }
end
describe '.has_vulnerabilities' do
let_it_be(:without_vulnerabilities) { create(:cluster_agent, has_vulnerabilities: false) }
let_it_be(:with_vulnerabilities) { create(:cluster_agent, has_vulnerabilities: true) }
context 'when value is not provided' do
subject { described_class.has_vulnerabilities }
it 'returns agents which have vulnerabilities' do
is_expected.to contain_exactly(with_vulnerabilities)
end
end
context 'when value is provided' do
subject { described_class.has_vulnerabilities(value) }
context 'as true' do
let(:value) { true }
it 'returns agents which have vulnerabilities' do
is_expected.to contain_exactly(with_vulnerabilities)
end
end
context 'as false' do
let(:value) { false }
it 'returns agents which do not have vulnerabilities' do
is_expected.to contain_exactly(without_vulnerabilities)
end
end
end
end
end
describe 'validation' do
describe 'name validation' do
it 'rejects names that do not conform to RFC 1123', :aggregate_failures do
%w[Agent agentA agentAagain gent- -agent agent.a agent/a agent>a].each do |name|
agent = build(:cluster_agent, name: name)
expect(agent).not_to be_valid
expect(agent.errors[:name]).to eq(["can contain only lowercase letters, digits, and '-', but cannot start or end with '-'"])
end
end
it 'accepts valid names', :aggregate_failures do
%w[agent agent123 agent-123].each do |name|
agent = build(:cluster_agent, name: name)
expect(agent).to be_valid
end
end
end
end
describe '#has_access_to?' do
let(:agent) { build(:cluster_agent) }
it 'has access to own project' do
expect(agent.has_access_to?(agent.project)).to be_truthy
end
it 'does not have access to other projects' do
expect(agent.has_access_to?(create(:project))).to be_falsey
end
end
describe '#connected?' do
let_it_be(:agent) { create(:cluster_agent) }
let!(:token) { create(:cluster_agent_token, agent: agent, last_used_at: last_used_at) }
subject { agent.connected? }
context 'agent has never connected' do
let(:last_used_at) { nil }
it { is_expected.to be_falsey }
end
context 'agent has connected, but not recently' do
let(:last_used_at) { 2.hours.ago }
it { is_expected.to be_falsey }
end
context 'agent has connected recently' do
let(:last_used_at) { 2.minutes.ago }
it { is_expected.to be_truthy }
context 'agent token has been revoked' do
before do
token.revoked!
end
it { is_expected.to be_falsey }
end
end
context 'agent has multiple tokens' do
let!(:inactive_token) { create(:cluster_agent_token, agent: agent, last_used_at: 2.hours.ago) }
let(:last_used_at) { 2.minutes.ago }
it { is_expected.to be_truthy }
end
end
describe '#activity_event_deletion_cutoff' do
let_it_be(:agent) { create(:cluster_agent) }
let_it_be(:event1) { create(:agent_activity_event, agent: agent, recorded_at: 1.hour.ago) }
let_it_be(:event2) { create(:agent_activity_event, agent: agent, recorded_at: 2.hours.ago) }
let_it_be(:event3) { create(:agent_activity_event, agent: agent, recorded_at: 3.hours.ago) }
subject { agent.activity_event_deletion_cutoff }
before do
stub_const("#{described_class}::ACTIVITY_EVENT_LIMIT", 2)
end
it { is_expected.to be_like_time(event2.recorded_at) }
end
describe '#ci_access_authorized_for?' do
using RSpec::Parameterized::TableSyntax
let_it_be(:organization) { create(:group) }
let_it_be(:agent_management_project) { create(:project, group: organization) }
let_it_be(:agent) { create(:cluster_agent, project: agent_management_project) }
let_it_be(:deployment_project) { create(:project, group: organization) }
let(:user) { create(:user) }
subject { agent.ci_access_authorized_for?(user) }
it { is_expected.to eq(false) }
context 'with project-level authorization' do
let!(:authorization) { create(:agent_ci_access_project_authorization, agent: agent, project: deployment_project) }
where(:user_role, :allowed) do
:guest | false
:reporter | false
:developer | true
:maintainer | true
:owner | true
end
with_them do
before do
deployment_project.add_member(user, user_role)
end
it { is_expected.to eq(allowed) }
end
end
context 'with group-level authorization' do
let!(:authorization) { create(:agent_ci_access_group_authorization, agent: agent, group: organization) }
where(:user_role, :allowed) do
:guest | false
:reporter | false
:developer | true
:maintainer | true
:owner | true
end
with_them do
before do
organization.add_member(user, user_role)
end
it { is_expected.to eq(allowed) }
end
end
end
describe '#user_access_authorized_for?' do
using RSpec::Parameterized::TableSyntax
let_it_be(:organization) { create(:group) }
let_it_be(:agent_management_project) { create(:project, group: organization) }
let_it_be(:agent) { create(:cluster_agent, project: agent_management_project) }
let_it_be(:deployment_project) { create(:project, group: organization) }
let(:user) { create(:user) }
subject { agent.user_access_authorized_for?(user) }
it { is_expected.to eq(false) }
context 'with project-level authorization' do
let!(:authorization) { create(:agent_user_access_project_authorization, agent: agent, project: deployment_project) }
where(:user_role, :allowed) do
:guest | false
:reporter | false
:developer | true
:maintainer | true
:owner | true
end
with_them do
before do
deployment_project.add_member(user, user_role)
end
it { is_expected.to eq(allowed) }
end
end
context 'with group-level authorization' do
let!(:authorization) { create(:agent_user_access_group_authorization, agent: agent, group: organization) }
where(:user_role, :allowed) do
:guest | false
:reporter | false
:developer | true
:maintainer | true
:owner | true
end
with_them do
before do
organization.add_member(user, user_role)
end
it { is_expected.to eq(allowed) }
end
end
end
describe '#user_access_config' do
let_it_be(:group) { create(:group) }
let_it_be(:project) { create(:project) }
let_it_be_with_refind(:agent) { create(:cluster_agent, project: project) }
subject { agent.user_access_config }
it { is_expected.to be_nil }
context 'with user_access project authorizations' do
before do
create(:agent_user_access_project_authorization, agent: agent, project: project, config: config)
end
let(:config) { {} }
it { is_expected.to eq(config) }
context 'when access_as keyword exists' do
let(:config) { { 'access_as' => { 'agent' => {} } } }
it { is_expected.to eq(config) }
end
end
context 'with user_access group authorizations' do
before do
create(:agent_user_access_group_authorization, agent: agent, group: group, config: config)
end
let(:config) { {} }
it { is_expected.to eq(config) }
context 'when access_as keyword exists' do
let(:config) { { 'access_as' => { 'agent' => {} } } }
it { is_expected.to eq(config) }
end
end
end
end
|