1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe Spammable, feature_category: :instance_resiliency do
before do
stub_const('SpammableModel', Class.new(ActiveRecord::Base))
SpammableModel.class_eval do
self.table_name = 'issues'
include Spammable
attr_accessor :other_attr
attr_spammable :title, spam_title: true
attr_spammable :description, spam_description: true
end
end
let(:spammable_model) { SpammableModel.new }
let(:issue) { create(:issue, description: 'Test Desc.') }
describe 'Associations' do
subject { build(:issue) }
it { is_expected.to have_one(:user_agent_detail).dependent(:destroy) }
end
describe 'ClassMethods' do
it 'returns correct attr_spammable' do
expect(issue.spammable_text).to eq("#{issue.title}\n#{issue.description}")
end
end
describe 'InstanceMethods' do
let(:issue) { build(:issue, spam: true) }
it 'is invalid if spam' do
expect(issue.valid?).to be_falsey
end
describe '#check_for_spam?' do
context 'when not overriden' do
subject { spammable_model.check_for_spam? }
context 'when spammable attributes have changed' do
where(attr: [:title, :description])
with_them do
before do
spammable_model.assign_attributes(attr => 'x')
end
it { is_expected.to eq(true) }
end
end
context 'when other attributes have changed' do
before do
spammable_model.other_attr = true
end
it { is_expected.to eq(false) }
end
end
it 'returns true for public project' do
issue.project.update_attribute(:visibility_level, Gitlab::VisibilityLevel::PUBLIC)
expect(issue.check_for_spam?(user: issue.author)).to eq(true)
end
it 'returns false for other visibility levels' do
expect(issue.check_for_spam?(user: issue.author)).to eq(false)
end
end
describe '#invalidate_if_spam' do
before do
stub_application_setting(recaptcha_enabled: true)
end
context 'when the model is spam' do
where(model: [:issue, :merge_request, :snippet, :spammable_model])
with_them do
subject do
model.to_s.classify.constantize.new.tap do |m|
m.spam!
m.invalidate_if_spam
end
end
it 'has an error related to spam on the model' do
expect(subject.errors.messages[:base])
.to match_array /Your #{subject.class.model_name.human.downcase} has been recognized as spam./
end
end
context 'when the spammable model is a Note' do
subject do
Note.new.tap do |m|
m.spam!
m.invalidate_if_spam
end
end
it 'has an error related to spam on the model' do
expect(subject.errors.messages[:base])
.to match_array /Your comment has been recognized as spam./
end
end
end
context 'when the model needs recaptcha' do
subject { invalidate_if_spam(needs_recaptcha: true) }
it 'has an error related to spam on the model' do
expect(subject.errors.messages[:base]).to match_array /content or solve the/
end
end
context 'when the model needs recaptcha but does not support it' do
subject { invalidate_if_spam(needs_recaptcha: true) }
before do
allow(issue).to receive(:supports_recaptcha?).and_return(false)
end
it 'has an error that discards the spammable' do
expect(subject.errors.messages[:base]).to match_array /has been recognized as spam/
end
end
context 'if the model is spam and also needs recaptcha' do
subject { invalidate_if_spam(is_spam: true, needs_recaptcha: true) }
it 'has an error related to spam on the model' do
expect(subject.errors.messages[:base]).to match_array /content or solve the/
end
end
context 'when the model is not spam nor needs recaptcha' do
subject { invalidate_if_spam }
it 'returns no error' do
expect(subject.errors.messages[:base]).to be_empty
end
end
context 'if recaptcha is not enabled and the model needs recaptcha' do
before do
stub_application_setting(recaptcha_enabled: false)
end
subject { invalidate_if_spam(needs_recaptcha: true) }
it 'has no errors' do
expect(subject.errors.messages[:base]).to match_array /has been recognized as spam/
end
end
def invalidate_if_spam(is_spam: false, needs_recaptcha: false)
issue.tap do |i|
i.spam = is_spam
i.needs_recaptcha = needs_recaptcha
i.invalidate_if_spam
end
end
end
describe 'spam flags' do
before do
issue.spam = false
issue.needs_recaptcha = false
end
describe '#spam!' do
it 'adds only `spam` flag' do
issue.spam!
expect(issue.spam).to be_truthy
expect(issue.needs_recaptcha).to be_falsey
end
end
describe '#needs_recaptcha!' do
context 'when recaptcha is supported' do
it 'adds `needs_recaptcha` flag' do
issue.needs_recaptcha!
expect(issue.spam).to be_falsey
expect(issue.needs_recaptcha).to be_truthy
end
end
context 'when recaptcha is not supported' do
before do
allow(issue).to receive(:supports_recaptcha?).and_return(false)
end
it 'marks the object as spam' do
issue.needs_recaptcha!
expect(issue.spam).to be_truthy
expect(issue.needs_recaptcha).to be_falsey
end
end
end
describe '#render_recaptcha?' do
before do
allow(Gitlab::Recaptcha).to receive(:enabled?) { recaptcha_enabled }
end
context 'when recaptcha is not enabled' do
let(:recaptcha_enabled) { false }
it 'returns false' do
expect(issue.render_recaptcha?).to eq(false)
end
end
context 'when recaptcha is enabled' do
let(:recaptcha_enabled) { true }
context 'when there are two or more errors' do
before do
issue.errors.add(:base, 'a spam error')
issue.errors.add(:base, 'some other error')
end
it 'returns false' do
expect(issue.render_recaptcha?).to eq(false)
end
end
context 'when there are less than two errors' do
before do
issue.errors.add(:base, 'a spam error')
end
context 'when spammable does not need recaptcha' do
before do
issue.needs_recaptcha = false
end
it 'returns false' do
expect(issue.render_recaptcha?).to eq(false)
end
end
context 'when spammable needs recaptcha' do
before do
issue.needs_recaptcha!
end
it 'returns false' do
expect(issue.render_recaptcha?).to eq(true)
end
end
end
end
end
describe '#clear_spam_flags!' do
it 'clears spam and recaptcha flags' do
issue.spam = true
issue.needs_recaptcha = true
issue.clear_spam_flags!
expect(issue).not_to be_spam
expect(issue.needs_recaptcha).to be_falsey
end
end
end
describe '#submittable_as_spam_by?' do
let(:admin) { build(:admin) }
let(:user) { build(:user) }
before do
allow(issue).to receive(:submittable_as_spam?).and_return(true)
end
it 'tests if the user can submit spam' do
expect(issue.submittable_as_spam_by?(admin)).to be(true)
expect(issue.submittable_as_spam_by?(user)).to be(false)
expect(issue.submittable_as_spam_by?(nil)).to be_nil
end
end
describe '#allow_possible_spam?' do
subject { issue.allow_possible_spam? }
context 'when the `allow_possible_spam` application setting is turned off' do
it { is_expected.to eq(false) }
end
context 'when the `allow_possible_spam` application setting is turned on' do
before do
stub_application_setting(allow_possible_spam: true)
end
it { is_expected.to eq(true) }
end
end
end
end
|