1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe ExternalPullRequest do
let_it_be(:project) { create(:project, :repository) }
let(:source_branch) { 'the-branch' }
let(:status) { :open }
it { is_expected.to belong_to(:project) }
shared_examples 'has errors on' do |attribute|
it "has errors for #{attribute}" do
expect(subject).not_to be_valid
expect(subject.errors[attribute]).not_to be_empty
end
end
describe 'validations' do
context 'when source branch not present' do
subject { build(:external_pull_request, source_branch: nil) }
it_behaves_like 'has errors on', :source_branch
end
context 'when status not present' do
subject { build(:external_pull_request, status: nil) }
it_behaves_like 'has errors on', :status
end
context 'when pull request is from a fork' do
subject { build(:external_pull_request, source_repository: 'the-fork', target_repository: 'the-target') }
it_behaves_like 'has errors on', :base
end
end
describe 'create_or_update_from_params' do
subject { described_class.create_or_update_from_params(params) }
context 'when pull request does not exist' do
context 'when params are correct' do
let(:params) do
{
project_id: project.id,
pull_request_iid: 123,
source_branch: 'feature',
target_branch: 'master',
source_repository: 'the-repository',
target_repository: 'the-repository',
source_sha: '97de212e80737a608d939f648d959671fb0a0142',
target_sha: 'a09386439ca39abe575675ffd4b89ae824fec22f',
status: :open
}
end
it 'saves the model successfully and returns it' do
expect(subject).to be_persisted
expect(subject).to be_valid
end
it 'yields the model' do
yielded_value = nil
result = described_class.create_or_update_from_params(params) do |pull_request|
yielded_value = pull_request
end
expect(result).to eq(yielded_value)
end
end
context 'when params are not correct' do
let(:params) do
{
pull_request_iid: 123,
source_branch: 'feature',
target_branch: 'master',
source_repository: 'the-repository',
target_repository: 'the-repository',
source_sha: nil,
target_sha: nil,
status: :open
}
end
it 'returns an invalid model' do
expect(subject).not_to be_persisted
expect(subject).not_to be_valid
end
end
end
context 'when pull request exists' do
let!(:pull_request) do
create(:external_pull_request,
project: project,
source_sha: '97de212e80737a608d939f648d959671fb0a0142')
end
context 'when params are correct' do
let(:params) do
{
pull_request_iid: pull_request.pull_request_iid,
source_branch: pull_request.source_branch,
target_branch: pull_request.target_branch,
source_repository: 'the-repository',
target_repository: 'the-repository',
source_sha: 'ce84140e8b878ce6e7c4d298c7202ff38170e3ac',
target_sha: pull_request.target_sha,
status: :open
}
end
it 'updates the model successfully and returns it' do
expect(subject).to be_valid
expect(subject.source_sha).to eq(params[:source_sha])
expect(pull_request.reload.source_sha).to eq(params[:source_sha])
end
end
context 'when params are not correct' do
let(:params) do
{
pull_request_iid: pull_request.pull_request_iid,
source_branch: pull_request.source_branch,
target_branch: pull_request.target_branch,
source_repository: 'the-repository',
target_repository: 'the-repository',
source_sha: nil,
target_sha: nil,
status: :open
}
end
it 'returns an invalid model' do
expect(subject).not_to be_valid
expect(pull_request.reload.source_sha).not_to be_nil
expect(pull_request.target_sha).not_to be_nil
end
end
end
end
describe '#open?' do
it 'returns true if status is open' do
pull_request = create(:external_pull_request, status: :open)
expect(pull_request).to be_open
end
it 'returns false if status is not open' do
pull_request = create(:external_pull_request, status: :closed)
expect(pull_request).not_to be_open
end
end
describe '#closed?' do
it 'returns true if status is closed' do
pull_request = build(:external_pull_request, status: :closed)
expect(pull_request).to be_closed
end
it 'returns false if status is not closed' do
pull_request = build(:external_pull_request, status: :open)
expect(pull_request).not_to be_closed
end
end
describe '#actual_branch_head?' do
let(:project) { create(:project, :repository) }
let(:branch) { project.repository.branches.first }
let(:source_branch) { branch.name }
let(:pull_request) do
create(:external_pull_request,
project: project,
source_branch: source_branch,
source_sha: source_sha)
end
context 'when source sha matches the head of the branch' do
let(:source_sha) { branch.target }
it 'returns true' do
expect(pull_request).to be_actual_branch_head
end
end
context 'when source sha does not match the head of the branch' do
let(:source_sha) { project.repository.commit('HEAD').sha }
it 'returns true' do
expect(pull_request).not_to be_actual_branch_head
end
end
end
describe '#from_fork?' do
it 'returns true if source_repository differs from target_repository' do
pull_request = build(:external_pull_request,
source_repository: 'repository-1',
target_repository: 'repository-2')
expect(pull_request).to be_from_fork
end
it 'returns false if source_repository is the same as target_repository' do
pull_request = build(:external_pull_request,
source_repository: 'repository-1',
target_repository: 'repository-1')
expect(pull_request).not_to be_from_fork
end
end
describe '#modified_paths' do
let(:pull_request) do
build(:external_pull_request, project: project, target_sha: '281d3a7', source_sha: '498214d')
end
subject(:modified_paths) { pull_request.modified_paths }
it 'returns modified paths' do
expect(modified_paths).to eq ['bar/branch-test.txt',
'files/js/commit.coffee',
'with space/README.md']
end
end
end
|
