1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
|
# frozen_string_literal: true
require "spec_helper"
RSpec.describe Integrations::Discord, feature_category: :integrations do
it_behaves_like "chat integration", "Discord notifications", supports_deployments: true do
let(:client) { Discordrb::Webhooks::Client }
let(:client_arguments) { { url: webhook_url } }
let(:payload) do
{
embeds: [
include(
author: include(name: be_present),
description: be_present,
color: be_present,
timestamp: be_present
)
]
}
end
it_behaves_like 'supports group mentions', :discord_integration
end
describe 'validations' do
let_it_be(:project) { create(:project) }
subject { integration }
describe 'only allows one channel on events' do
context 'when given more than one channel' do
let(:integration) { build(:discord_integration, project: project, note_channel: 'webhook1,webhook2') }
it { is_expected.not_to be_valid }
end
context 'when given one channel' do
let(:integration) { build(:discord_integration, project: project, note_channel: 'webhook1') }
it { is_expected.to be_valid }
end
end
end
describe '#execute' do
include StubRequests
let_it_be(:project) { create(:project, :repository) }
let(:user) { build_stubbed(:user) }
let(:webhook_url) { "https://example.gitlab.com/" }
let(:sample_data) do
Gitlab::DataBuilder::Push.build_sample(project, user)
end
before do
allow(subject).to receive_messages(
project: project,
project_id: project.id,
webhook: webhook_url
)
WebMock.stub_request(:post, webhook_url)
end
it 'uses the right embed parameters' do
builder = Discordrb::Webhooks::Builder.new
allow_next_instance_of(Discordrb::Webhooks::Client) do |client|
allow(client).to receive(:execute).and_yield(builder)
end
freeze_time do
subject.execute(sample_data)
expect(builder.to_json_hash[:embeds].first).to include(
description: start_with("#{user.name} pushed to branch [master](http://localhost/#{project.namespace.path}/#{project.path}/-/commits/master) of"),
author: hash_including(
icon_url: start_with('https://www.gravatar.com/avatar/'),
name: user.name
),
color: 3359829,
timestamp: Time.now.utc.iso8601
)
end
end
context 'DNS rebind to local address' do
before do
stub_dns(webhook_url, ip_address: '192.168.2.120')
end
it 'does not allow DNS rebinding' do
expect { subject.execute(sample_data) }.to raise_error(ArgumentError, /is blocked/)
end
end
context 'when the Discord request fails' do
before do
WebMock.stub_request(:post, webhook_url).to_return(status: 400)
end
it 'logs an error and returns false' do
expect(subject).to receive(:log_error).with('400 Bad Request')
expect(subject.execute(sample_data)).to be(false)
end
end
end
end
|