1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe LastGroupOwnerAssigner do
describe "#execute" do
let_it_be(:user, reload: true) { create(:user) }
let_it_be(:group) { create(:group) }
let!(:group_member) { group.add_owner(user) }
subject(:assigner) { described_class.new(group, [group_member]) }
it "avoids extra database queries utilizing memoization", :aggregate_failures do
control = ActiveRecord::QueryRecorder.new { assigner.execute }
count_queries = control.occurrences_by_line_method.first[1][:occurrences].find_all { |i| i.include?('SELECT COUNT') }
expect(control.count).to be <= 5
expect(count_queries.count).to eq(0)
end
context "when there are unblocked owners" do
context "with one unblocked owner" do
specify do
expect { assigner.execute }.to change(group_member, :last_owner)
.from(nil).to(true)
.and change(group_member, :last_blocked_owner)
.from(nil).to(false)
end
end
context "with multiple unblocked owners" do
let_it_be(:unblocked_owner_member) { create(:group_member, :owner, source: group) }
specify do
expect { assigner.execute }.to change(group_member, :last_owner)
.from(nil).to(false)
.and change(group_member, :last_blocked_owner)
.from(nil).to(false)
end
it "has many members passed" do
assigner = described_class.new(group, [unblocked_owner_member, group_member])
expect { assigner.execute }.to change(group_member, :last_owner)
.from(nil).to(false)
.and change(group_member, :last_blocked_owner)
.from(nil).to(false)
.and change(unblocked_owner_member, :last_owner)
.from(nil).to(false)
.and change(unblocked_owner_member, :last_blocked_owner)
.from(nil).to(false)
end
end
context 'with owners from a parent' do
context 'when top-level group' do
context 'with group sharing' do
let!(:subgroup) { create(:group, parent: group) }
before do
create(:group_group_link, :owner, shared_group: group, shared_with_group: subgroup)
create(:group_member, :owner, group: subgroup)
end
specify do
expect { assigner.execute }.to change(group_member, :last_owner)
.from(nil).to(true)
.and change(group_member, :last_blocked_owner)
.from(nil).to(false)
end
end
end
context 'when subgroup' do
let!(:subgroup) { create(:group, parent: group) }
let!(:group_member_2) { subgroup.add_owner(user) }
subject(:assigner) { described_class.new(subgroup, [group_member_2]) }
specify do
expect { assigner.execute }.to change(group_member_2, :last_owner)
.from(nil).to(false)
.and change(group_member_2, :last_blocked_owner)
.from(nil).to(false)
end
end
end
end
context "when there are blocked owners" do
before do
user.block!
end
context "with one blocked owner" do
specify do
expect { assigner.execute }.to change(group_member, :last_owner)
.from(nil).to(false)
.and change(group_member, :last_blocked_owner)
.from(nil).to(true)
end
end
context "with multiple unblocked owners" do
specify do
create_list(:group_member, 2, :owner, source: group)
expect { assigner.execute }.to change(group_member, :last_owner)
.from(nil).to(false)
.and change(group_member, :last_blocked_owner)
.from(nil).to(false)
end
end
context "with multiple blocked owners" do
specify do
create(:group_member, :owner, :blocked, source: group)
expect { assigner.execute }.to change(group_member, :last_owner)
.from(nil).to(false)
.and change(group_member, :last_blocked_owner)
.from(nil).to(false)
end
end
context 'with owners from a parent' do
context 'when top-level group' do
context 'with group sharing' do
let!(:subgroup) { create(:group, parent: group) }
before do
create(:group_group_link, :owner, shared_group: group, shared_with_group: subgroup)
create(:group_member, :owner, group: subgroup)
end
specify do
expect { assigner.execute }.to change(group_member, :last_owner)
.from(nil).to(false)
.and change(group_member, :last_blocked_owner)
.from(nil).to(true)
end
end
end
context 'when subgroup' do
let!(:subgroup) { create(:group, :nested) }
let!(:group_member) { subgroup.add_owner(user) }
subject(:assigner) { described_class.new(subgroup, [group_member]) }
specify do
expect { assigner.execute }.to change(group_member, :last_owner)
.from(nil).to(false)
.and change(group_member, :last_blocked_owner)
.from(nil).to(true)
end
context 'with two owners' do
before do
create(:group_member, :owner, group: subgroup.parent)
end
specify do
expect { assigner.execute }.to change(group_member, :last_owner)
.from(nil).to(false)
.and change(group_member, :last_blocked_owner)
.from(nil).to(false)
end
end
end
end
end
context 'when there are bot members' do
context 'with a bot owner' do
specify do
create(:group_member, :owner, source: group, user: create(:user, :project_bot))
expect { assigner.execute }.to change(group_member, :last_owner)
.from(nil).to(true)
.and change(group_member, :last_blocked_owner)
.from(nil).to(false)
end
end
end
end
end
|
