spec/models/ml/model_spec.rb


1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62

# frozen_string_literal: true

require 'spec_helper'

RSpec.describe Ml::Model, feature_category: :mlops do
  describe 'associations' do
    it { is_expected.to belong_to(:project) }
    it { is_expected.to have_one(:default_experiment) }
    it { is_expected.to have_many(:versions) }
  end

  describe '#valid?' do
    using RSpec::Parameterized::TableSyntax

    let_it_be(:project) { create(:project) }
    let_it_be(:existing_model) { create(:ml_models, name: 'an_existing_model', project: project) }
    let_it_be(:valid_name) { 'a_valid_name' }
    let_it_be(:default_experiment) { create(:ml_experiments, name: valid_name, project: project) }

    let(:name) { valid_name }

    subject(:errors) do
      m = described_class.new(name: name, project: project, default_experiment: default_experiment)
      m.validate
      m.errors
    end

    it 'validates a valid model version' do
      expect(errors).to be_empty
    end

    describe 'name' do
      where(:ctx, :name) do
        'name is blank'                     | ''
        'name is not valid package name'    | '!!()()'
        'name is too large'                 | ('a' * 256)
        'name is not unique in the project' | 'an_existing_model'
      end
      with_them do
        it { expect(errors).to include(:name) }
      end
    end

    describe 'default_experiment' do
      context 'when experiment name name is different than model name' do
        before do
          allow(default_experiment).to receive(:name).and_return("#{name}a")
        end

        it { expect(errors).to include(:default_experiment) }
      end

      context 'when model version project is different than model project' do
        before do
          allow(default_experiment).to receive(:project_id).and_return(project.id + 1)
        end

        it { expect(errors).to include(:default_experiment) }
      end
    end
  end
end