1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe Ml::ModelVersion, feature_category: :mlops do
using RSpec::Parameterized::TableSyntax
let_it_be(:base_project) { create(:project) }
let_it_be(:model1) { create(:ml_models, project: base_project) }
let_it_be(:model2) { create(:ml_models, project: base_project) }
let_it_be(:model_version1) { create(:ml_model_versions, model: model1) }
let_it_be(:model_version2) { create(:ml_model_versions, model: model_version1.model) }
let_it_be(:model_version3) { create(:ml_model_versions, model: model2) }
let_it_be(:model_version4) { create(:ml_model_versions, model: model_version3.model) }
describe 'associations' do
it { is_expected.to belong_to(:project) }
it { is_expected.to belong_to(:model) }
it { is_expected.to belong_to(:package).class_name('Packages::MlModel::Package') }
it { is_expected.to have_one(:candidate).class_name('Ml::Candidate') }
end
describe 'validation' do
let_it_be(:valid_version) { '1.0.0' }
let_it_be(:valid_package) do
build_stubbed(:ml_model_package, project: base_project, version: valid_version, name: model1.name)
end
let_it_be(:valid_description) { 'Valid description' }
let(:package) { valid_package }
let(:version) { valid_version }
let(:description) { valid_description }
subject(:errors) do
mv = described_class.new(version: version, model: model1, package: package, project: model1.project,
description: description)
mv.validate
mv.errors
end
it 'validates a valid model version' do
expect(errors).to be_empty
end
describe 'version' do
where(:ctx, :version) do
'version is blank' | ''
'version is not valid package version' | '!!()()'
'version is too large' | ('a' * 256)
end
with_them do
it { expect(errors).to include(:version) }
end
context 'when version is not unique in project+name' do
let_it_be(:existing_model_version) do
create(:ml_model_versions, model: model1)
end
let(:version) { existing_model_version.version }
it { expect(errors).to include(:version) }
end
end
describe 'description' do
context 'when description is too large' do
let(:description) { 'a' * 501 }
it { expect(errors).to include(:description) }
end
end
describe 'model' do
context 'when project is different' do
before do
allow(model1).to receive(:project_id).and_return(non_existing_record_id)
end
it { expect(errors[:model]).to include('model project must be the same') }
end
end
describe 'package' do
where(:property, :value, :error_message) do
:name | 'another_name' | 'package name must be the same'
:version | 'another_version' | 'package version must be the same'
:project_id | 0 | 'package project must be the same'
end
with_them do
before do
allow(package).to receive(property).and_return(:value)
end
it { expect(errors[:package]).to include(error_message) }
end
end
end
describe '#find_or_create!' do
let_it_be(:existing_model_version) { create(:ml_model_versions, model: model1, version: '1.0.0') }
let(:version) { existing_model_version.version }
let(:package) { nil }
let(:description) { 'Some description' }
subject(:find_or_create) { described_class.find_or_create!(model1, version, package, description) }
context 'if model version exists' do
it 'returns the model version', :aggregate_failures do
expect { find_or_create }.not_to change { Ml::ModelVersion.count }
is_expected.to eq(existing_model_version)
end
end
context 'if model version does not exist' do
let(:version) { '2.0.0' }
let(:package) { create(:ml_model_package, project: model1.project, name: model1.name, version: version) }
it 'creates another model version', :aggregate_failures do
expect { find_or_create }.to change { Ml::ModelVersion.count }.by(1)
model_version = find_or_create
expect(model_version.version).to eq(version)
expect(model_version.model).to eq(model1)
expect(model_version.description).to eq(description)
expect(model_version.package).to eq(package)
end
end
end
describe '#by_project_id_and_id' do
let(:id) { model_version1.id }
let(:project_id) { model_version1.project.id }
subject { described_class.by_project_id_and_id(project_id, id) }
context 'if exists' do
it { is_expected.to eq(model_version1) }
end
context 'if id has no match' do
let(:id) { non_existing_record_id }
it { is_expected.to be(nil) }
end
context 'if project id does not match' do
let(:project_id) { non_existing_record_id }
it { is_expected.to be(nil) }
end
end
describe '.by_project_id_name_and_version' do
let(:version) { model_version1.version }
let(:project_id) { model_version1.project.id }
let(:model_name) { model_version1.model.name }
let_it_be(:latest_version) { create(:ml_model_versions, model: model_version1.model) }
subject { described_class.by_project_id_name_and_version(project_id, model_name, version) }
context 'if exists' do
it { is_expected.to eq(model_version1) }
end
context 'if id has no match' do
let(:version) { non_existing_record_id }
it { is_expected.to be(nil) }
end
context 'if project id does not match' do
let(:project_id) { non_existing_record_id }
it { is_expected.to be(nil) }
end
context 'if model name does not match' do
let(:model_name) { non_existing_record_id }
it { is_expected.to be(nil) }
end
end
describe '.order_by_model_id_id_desc' do
subject { described_class.order_by_model_id_id_desc }
it 'orders by (model_id, id desc)' do
is_expected.to match_array([model_version2, model_version1, model_version4, model_version3])
end
end
describe '.latest_by_model' do
subject { described_class.latest_by_model }
it 'returns only the latest model version per model id' do
is_expected.to match_array([model_version4, model_version2])
end
end
end
|
