1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe Ci::RunnerPolicy do
describe 'ability :read_runner' do
let_it_be(:guest) { create(:user) }
let_it_be(:developer) { create(:user) }
let_it_be(:owner) { create(:user) }
let_it_be(:group1) { create(:group, name: 'top-level', path: 'top-level') }
let_it_be(:subgroup1) { create(:group, name: 'subgroup1', path: 'subgroup1', parent: group1) }
let_it_be(:project1) { create(:project, group: subgroup1) }
let_it_be(:instance_runner) { create(:ci_runner, :instance) }
let_it_be(:group1_runner) { create(:ci_runner, :group, groups: [group1]) }
let_it_be(:project1_runner) { create(:ci_runner, :project, projects: [project1]) }
subject(:policy) { described_class.new(user, runner) }
before do
group1.add_guest(guest)
group1.add_developer(developer)
group1.add_owner(owner)
end
shared_context 'on hierarchy with shared runners disabled' do
around do |example|
group1.update!(shared_runners_enabled: false)
project1.update!(shared_runners_enabled: false)
example.run
ensure
project1.update!(shared_runners_enabled: true)
group1.update!(shared_runners_enabled: true)
end
end
shared_context 'on hierarchy with group runners disabled' do
around do |example|
project1.update!(group_runners_enabled: false)
example.run
ensure
project1.update!(group_runners_enabled: true)
end
end
shared_examples 'does not allow reading runners on any scope' do
context 'with instance runner' do
let(:runner) { instance_runner }
it { expect_disallowed :read_runner }
context 'with shared runners disabled' do
include_context 'on hierarchy with shared runners disabled' do
it { expect_disallowed :read_runner }
end
end
end
context 'with group runner' do
let(:runner) { group1_runner }
it { expect_disallowed :read_runner }
context 'with group runner disabled' do
include_context 'on hierarchy with group runners disabled' do
it { expect_disallowed :read_runner }
end
end
end
context 'with project runner' do
let(:runner) { project1_runner }
it { expect_disallowed :read_runner }
end
end
context 'without access' do
let_it_be(:user) { create(:user) }
it_behaves_like 'does not allow reading runners on any scope'
end
context 'with guest access' do
let(:user) { guest }
it_behaves_like 'does not allow reading runners on any scope'
end
context 'with developer access' do
let(:user) { developer }
context 'with instance runner' do
let(:runner) { instance_runner }
it { expect_allowed :read_runner }
context 'with shared runners disabled' do
include_context 'on hierarchy with shared runners disabled' do
it { expect_disallowed :read_runner }
end
end
end
context 'with group runner' do
let(:runner) { group1_runner }
it { expect_allowed :read_runner }
context 'with group runner disabled' do
include_context 'on hierarchy with group runners disabled' do
it { expect_disallowed :read_runner }
end
end
end
context 'with project runner' do
let(:runner) { project1_runner }
it { expect_disallowed :read_runner }
end
end
context 'with owner access' do
let(:user) { owner }
context 'with instance runner' do
let(:runner) { instance_runner }
context 'with shared runners disabled' do
include_context 'on hierarchy with shared runners disabled' do
it { expect_disallowed :read_runner }
end
end
it { expect_allowed :read_runner }
end
context 'with group runner' do
let(:runner) { group1_runner }
context 'with group runners disabled' do
include_context 'on hierarchy with group runners disabled' do
it { expect_allowed :read_runner }
end
end
it { expect_allowed :read_runner }
end
context 'with project runner' do
let(:runner) { project1_runner }
it { expect_allowed :read_runner }
end
end
end
end
|