1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe ProjectGroupLinkPolicy, feature_category: :system_access do
let_it_be(:user) { create(:user) }
let_it_be(:group2) { create(:group, :private) }
let_it_be(:project) { create(:project, :private) }
subject(:policy) { described_class.new(user, project_group_link) }
describe 'destroy_project_group_link' do
let_it_be(:project_group_link) do
create(:project_group_link, project: project, group: group2, group_access: Gitlab::Access::DEVELOPER)
end
context 'when the user is a group owner' do
before_all do
group2.add_owner(user)
end
it 'can destroy group_project_link' do
expect(policy).to be_allowed(:destroy_project_group_link)
end
context 'when group link has owner access' do
it 'can destroy group_project_link' do
project_group_link.update!(group_access: Gitlab::Access::OWNER)
expect(policy).to be_allowed(:destroy_project_group_link)
end
end
end
context 'when user is a project maintainer' do
before do
project_group_link.project.add_maintainer(user)
end
context 'when group link has owner access' do
it 'cannot destroy group_project_link' do
project_group_link.update!(group_access: Gitlab::Access::OWNER)
expect(policy).to be_disallowed(:destroy_project_group_link)
end
end
context 'when group link has maintainer access' do
it 'can destroy group_project_link' do
project_group_link.update!(group_access: Gitlab::Access::MAINTAINER)
expect(policy).to be_allowed(:destroy_project_group_link)
end
end
end
context 'when user is not a project maintainer' do
it 'cannot destroy group_project_link' do
project_group_link.project.add_developer(user)
expect(policy).to be_disallowed(:destroy_project_group_link)
end
end
end
describe 'manage_destroy' do
let_it_be(:project_group_link) do
create(:project_group_link, project: project, group: group2, group_access: Gitlab::Access::DEVELOPER)
end
context 'when the user is a group owner' do
before_all do
group2.add_owner(user)
end
context 'when user is not project maintainer' do
it 'can manage_destroy' do
expect(policy).to be_allowed(:manage_destroy)
end
end
context 'when user is a project maintainer' do
before do
project_group_link.project.add_maintainer(user)
end
it 'can admin manage_destroy' do
expect(policy).to be_allowed(:manage_destroy)
end
end
end
context 'when user is not a group owner' do
context 'when user is a project maintainer' do
before do
project_group_link.project.add_maintainer(user)
end
context 'when group link has owner access' do
it 'can manage_destroy' do
project_group_link.update!(group_access: Gitlab::Access::OWNER)
expect(policy).to be_allowed(:manage_destroy)
end
end
context 'when group link has maintainer access' do
it 'can manage_destroy' do
project_group_link.update!(group_access: Gitlab::Access::MAINTAINER)
expect(policy).to be_allowed(:manage_destroy)
end
end
end
context 'when user is not a project maintainer' do
it 'cannot manage_destroy' do
project_group_link.project.add_developer(user)
expect(policy).to be_disallowed(:manage_destroy)
end
end
end
end
describe 'read_shared_with_group' do
let_it_be(:project_group_link) do
create(:project_group_link, project: project, group: group2, group_access: Gitlab::Access::MAINTAINER)
end
context 'when the user is a project member' do
before_all do
project.add_guest(user)
end
it 'can read_shared_with_group' do
expect(policy).to be_allowed(:read_shared_with_group)
end
end
context 'when the user is not a project member' do
context 'when user is not a group member' do
context 'when the group is private' do
it 'cannot read_shared_with_group' do
expect(policy).to be_disallowed(:read_shared_with_group)
end
context 'when the project is public' do
let_it_be(:project) { create(:project, :public) }
it 'cannot read_shared_with_group' do
expect(policy).to be_disallowed(:read_shared_with_group)
end
end
end
context 'when the group is public' do
it 'can read_shared_with_group' do
group2.update!(visibility_level: Gitlab::VisibilityLevel::PUBLIC)
expect(policy).to be_allowed(:read_shared_with_group)
end
end
end
context 'when user is a group member' do
before_all do
group2.add_guest(user)
end
it 'can read_shared_with_group' do
expect(policy).to be_allowed(:read_shared_with_group)
end
end
end
end
describe 'manage_owners' do
let_it_be(:project_group_link) do
create(:project_group_link, project: project, group: group2, group_access: Gitlab::Access::MAINTAINER)
end
context 'when the user is a project owner' do
before_all do
project.add_owner(user)
end
it 'can manage_owners' do
expect(policy).to be_allowed(:manage_owners)
end
end
context 'when the user is a project maintainer' do
before_all do
project.add_maintainer(user)
end
it 'cannot manage_owners' do
expect(policy).to be_disallowed(:manage_owners)
end
end
end
describe 'manage_group_link_with_owner_access' do
context 'when group link has owner access' do
let_it_be(:project_group_link) do
create(:project_group_link, project: project, group: group2, group_access: Gitlab::Access::OWNER)
end
context 'when the user is a project owner' do
before_all do
project.add_owner(user)
end
it 'can manage_group_link_with_owner_access' do
expect(policy).to be_allowed(:manage_group_link_with_owner_access)
end
end
context 'when the user is a project maintainer' do
before_all do
project.add_maintainer(user)
end
it 'cannot manage_group_link_with_owner_access' do
expect(policy).to be_disallowed(:manage_group_link_with_owner_access)
end
end
end
context 'when group link has maintainer access' do
let_it_be(:project_group_link) do
create(:project_group_link, project: project, group: group2, group_access: Gitlab::Access::MAINTAINER)
end
it 'can manage_group_link_with_owner_access' do
expect(policy).to be_allowed(:manage_group_link_with_owner_access)
end
end
end
end
|
