1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe API::ErrorTracking::ProjectSettings, feature_category: :error_tracking do
let_it_be(:user) { create(:user) }
let_it_be(:project) { create(:project) }
let_it_be(:setting) { create(:project_error_tracking_setting, project: project) }
let_it_be(:project_without_setting) { create(:project) }
shared_examples 'returns project settings' do
it 'returns correct project settings' do
make_request
expect(response).to have_gitlab_http_status(:ok)
expect(json_response).to eq(
'active' => setting.reload.enabled,
'project_name' => setting.project_name,
'sentry_external_url' => setting.sentry_external_url,
'api_url' => setting.api_url,
'integrated' => setting.integrated
)
end
end
shared_examples 'returns project settings with false for integrated' do
specify do
make_request
expect(response).to have_gitlab_http_status(:ok)
expect(json_response).to eq(
'active' => setting.reload.enabled,
'project_name' => setting.project_name,
'sentry_external_url' => setting.sentry_external_url,
'api_url' => setting.api_url,
'integrated' => false
)
end
end
shared_examples 'returns no project settings' do
it 'returns no project settings' do
make_request
expect(response).to have_gitlab_http_status(:not_found)
expect(json_response['message'])
.to eq('404 Error Tracking Setting Not Found')
end
end
shared_examples 'returns 400' do
it 'rejects request' do
make_request
expect(response).to have_gitlab_http_status(:bad_request)
end
end
shared_examples 'returns 401' do
it 'rejects request' do
make_request
expect(response).to have_gitlab_http_status(:unauthorized)
end
end
shared_examples 'returns 403' do
it 'rejects request' do
make_request
expect(response).to have_gitlab_http_status(:forbidden)
end
end
shared_examples 'returns 404' do
it 'rejects request' do
make_request
expect(response).to have_gitlab_http_status(:not_found)
end
end
shared_examples 'returns 400 with `integrated` param required or invalid' do |error|
it 'returns 400' do
make_request
expect(response).to have_gitlab_http_status(:bad_request)
expect(json_response['error'])
.to eq(error)
end
end
shared_examples "returns error from UpdateService" do
it "returns errors" do
make_request
expect(json_response['http_status']).to eq('forbidden')
expect(json_response['message']).to eq('An error occurred')
end
end
describe "PATCH /projects/:id/error_tracking/settings" do
let(:params) { { active: false, integrated: integrated } }
let(:integrated) { false }
def make_request
patch api("/projects/#{project.id}/error_tracking/settings", user), params: params
end
context 'when authenticated as maintainer' do
before do
project.add_maintainer(user)
end
context 'with integrated_error_tracking feature enabled' do
it_behaves_like 'returns project settings'
end
context 'with integrated_error_tracking feature disabled' do
before do
stub_feature_flags(integrated_error_tracking: false)
end
it_behaves_like 'returns project settings with false for integrated'
end
it 'updates enabled flag' do
expect(setting).to be_enabled
make_request
expect(json_response).to include('active' => false)
expect(setting.reload).not_to be_enabled
end
context 'when active is invalid' do
let(:params) { { active: "randomstring" } }
it 'returns active is invalid if non boolean' do
make_request
expect(response).to have_gitlab_http_status(:bad_request)
expect(json_response['error'])
.to eq('active is invalid')
end
end
context 'when active is empty' do
let(:params) { { active: '' } }
it 'returns 400' do
make_request
expect(response).to have_gitlab_http_status(:bad_request)
expect(json_response['error'])
.to eq('active is empty')
end
end
context 'with integrated param' do
let(:params) { { active: true, integrated: true } }
context 'when integrated_error_tracking feature enabled' do
before do
stub_feature_flags(integrated_error_tracking: true)
end
it 'updates the integrated flag' do
expect(setting.integrated).to be_falsey
make_request
expect(json_response).to include('integrated' => true)
expect(setting.reload.integrated).to be_truthy
end
end
end
context 'without a project setting' do
let(:project) { project_without_setting }
before do
project.add_maintainer(user)
end
it_behaves_like 'returns no project settings'
end
context "when ::Projects::Operations::UpdateService responds with an error" do
before do
allow_next_instance_of(::Projects::Operations::UpdateService) do |service|
allow(service)
.to receive(:execute)
.and_return({ status: :error, message: 'An error occurred', http_status: :forbidden })
end
end
context "when integrated" do
let(:integrated) { true }
it_behaves_like 'returns error from UpdateService'
end
context "without integrated" do
it_behaves_like 'returns error from UpdateService'
end
end
end
context 'when authenticated as developer' do
before do
project.add_developer(user)
end
it_behaves_like 'returns 403'
end
context 'when authenticated as non-member' do
it_behaves_like 'returns 404'
end
context 'when unauthenticated' do
let(:user) { nil }
it_behaves_like 'returns 401'
end
end
describe "GET /projects/:id/error_tracking/settings" do
def make_request
get api("/projects/#{project.id}/error_tracking/settings", user)
end
context 'when authenticated as maintainer' do
before do
project.add_maintainer(user)
end
it_behaves_like 'returns project settings'
context 'when integrated_error_tracking feature disabled' do
before do
stub_feature_flags(integrated_error_tracking: false)
end
it_behaves_like 'returns project settings with false for integrated'
end
end
context 'without a project setting' do
let(:project) { project_without_setting }
before do
project.add_maintainer(user)
end
it_behaves_like 'returns no project settings'
end
context 'when authenticated as developer' do
before do
project.add_developer(user)
end
it_behaves_like 'returns 403'
end
context 'when authenticated as non-member' do
it_behaves_like 'returns 404'
end
context 'when unauthenticated' do
let(:user) { nil }
it_behaves_like 'returns 401'
end
end
describe "PUT /projects/:id/error_tracking/settings" do
let(:params) { { active: active, integrated: integrated } }
let(:active) { true }
let(:integrated) { true }
def make_request
put api("/projects/#{project.id}/error_tracking/settings", user), params: params
end
context 'when authenticated' do
context 'as maintainer' do
before do
project.add_maintainer(user)
end
context "when integrated" do
context "with existing setting" do
let(:project) { setting.project }
let(:setting) { create(:project_error_tracking_setting, :integrated) }
let(:active) { false }
it "updates a setting" do
expect { make_request }.not_to change { ErrorTracking::ProjectErrorTrackingSetting.count }
expect(response).to have_gitlab_http_status(:ok)
expect(json_response).to eq(
"active" => false,
"api_url" => nil,
"integrated" => integrated,
"project_name" => nil,
"sentry_external_url" => nil
)
end
end
context "without setting" do
let(:project) { project_without_setting }
let(:active) { true }
it "creates a setting" do
expect { make_request }.to change { ErrorTracking::ProjectErrorTrackingSetting.count }
expect(response).to have_gitlab_http_status(:ok)
expect(json_response).to eq(
"active" => true,
"api_url" => nil,
"integrated" => true,
"project_name" => nil,
"sentry_external_url" => nil
)
end
end
context "when ::Projects::Operations::UpdateService responds with an error" do
before do
allow_next_instance_of(::Projects::Operations::UpdateService) do |service|
allow(service)
.to receive(:execute)
.and_return({ status: :error, message: 'An error occurred', http_status: :forbidden })
end
end
it_behaves_like 'returns error from UpdateService'
end
end
context "when integrated_error_tracking feature disabled" do
before do
stub_feature_flags(integrated_error_tracking: false)
end
it_behaves_like 'returns 404'
end
context "when integrated param is invalid" do
let(:params) { { active: active, integrated: 'invalid_string' } }
it_behaves_like 'returns 400 with `integrated` param required or invalid', 'integrated is invalid'
end
context "when integrated param is missing" do
let(:params) { { active: active } }
it_behaves_like 'returns 400 with `integrated` param required or invalid', 'integrated is missing'
end
end
context "as developer" do
before do
project.add_developer(user)
end
it_behaves_like 'returns 403'
end
context 'as non-member' do
it_behaves_like 'returns 404'
end
end
context "when unauthorized" do
let(:user) { nil }
it_behaves_like 'returns 401'
end
end
end
|