Welcome to mirror list, hosted at ThFree Co, Russian Federation.

resources_spec.rb « catalog « ci « graphql « api « requests « spec - gitlab.com/gitlab-org/gitlab-foss.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
blob: 49a3f3be1d78a59409f317195820a26e318498cf (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
# frozen_string_literal: true

require 'spec_helper'

RSpec.describe 'Query.ciCatalogResources', feature_category: :pipeline_composition do
  include GraphqlHelpers

  let_it_be(:user) { create(:user) }
  let_it_be(:namespace) { create(:group) }
  let_it_be(:project2) { create(:project, namespace: namespace) }

  let_it_be(:project1) do
    create(
      :project, :with_avatar, :custom_repo,
      name: 'Component Repository',
      description: 'A simple component',
      namespace: namespace,
      star_count: 1,
      files: { 'README.md' => '**Test**' }
    )
  end

  let_it_be(:public_project) do
    create(
      :project, :with_avatar, :custom_repo, :public,
      name: 'Public Component',
      description: 'A public component',
      files: { 'README.md' => '**Test**' }
    )
  end

  let_it_be(:resource1) do
    create(:ci_catalog_resource, :published, project: project1, latest_released_at: '2023-01-01T00:00:00Z')
  end

  let_it_be(:public_resource) { create(:ci_catalog_resource, :published, project: public_project) }

  let(:query) do
    <<~GQL
      query {
        ciCatalogResources {
          nodes {
            id
            name
            description
            icon
            webPath
            latestReleasedAt
            starCount
            readmeHtml
          }
        }
      }
    GQL
  end

  subject(:post_query) { post_graphql(query, current_user: user) }

  shared_examples 'avoids N+1 queries' do
    it do
      ctx = { current_user: user }

      control_count = ActiveRecord::QueryRecorder.new(skip_cached: false) do
        run_with_clean_state(query, context: ctx)
      end

      create(:ci_catalog_resource, :published, project: project2)

      expect do
        run_with_clean_state(query, context: ctx)
      end.not_to exceed_query_limit(control_count)
    end
  end

  it_behaves_like 'avoids N+1 queries'

  it 'returns the resources with the expected data' do
    namespace.add_developer(user)

    post_query

    expect(graphql_data_at(:ciCatalogResources, :nodes)).to contain_exactly(
      a_graphql_entity_for(
        resource1, :name, :description,
        icon: project1.avatar_path,
        webPath: "/#{project1.full_path}",
        starCount: project1.star_count,
        readmeHtml: a_string_including('Test</strong>'),
        latestReleasedAt: resource1.latest_released_at
      ),
      a_graphql_entity_for(public_resource)
    )
  end

  describe 'versions' do
    before_all do
      namespace.add_developer(user)
    end

    let(:query) do
      <<~GQL
        query {
          ciCatalogResources {
            nodes {
              id
              versions {
                nodes {
                  id
                  tagName
                  releasedAt
                  author {
                    id
                    name
                    webUrl
                  }
                }
              }
            }
          }
        }
      GQL
    end

    it 'limits the request to 1 resource at a time' do
      create(:ci_catalog_resource, :published, project: project2)

      post_query

      expect_graphql_errors_to_include \
        [/"versions" field can be requested only for 1 CiCatalogResource\(s\) at a time./]
    end
  end

  describe 'latestVersion' do
    let_it_be(:author1) { create(:user, name: 'author1') }
    let_it_be(:author2) { create(:user, name: 'author2') }

    let_it_be(:latest_version1) do
      create(:release, :with_catalog_resource_version, project: project1, released_at: '2023-02-01T00:00:00Z',
        author: author1).catalog_resource_version
    end

    let_it_be(:latest_version2) do
      create(:release, :with_catalog_resource_version, project: public_project, released_at: '2023-02-01T00:00:00Z',
        author: author2).catalog_resource_version
    end

    let(:query) do
      <<~GQL
        query {
          ciCatalogResources {
            nodes {
              id
              latestVersion {
                id
                tagName
                releasedAt
                author {
                  id
                  name
                  webUrl
                }
              }
            }
          }
        }
      GQL
    end

    before_all do
      namespace.add_developer(user)

      # Previous versions of the catalog resources
      create(:release, :with_catalog_resource_version, project: project1, released_at: '2023-01-01T00:00:00Z',
        author: author1)
      create(:release, :with_catalog_resource_version, project: public_project, released_at: '2023-01-01T00:00:00Z',
        author: author2)
    end

    it 'returns all resources with the latest version data' do
      post_query

      expect(graphql_data_at(:ciCatalogResources, :nodes)).to contain_exactly(
        a_graphql_entity_for(
          resource1,
          latestVersion: a_graphql_entity_for(
            latest_version1,
            tagName: latest_version1.name,
            releasedAt: latest_version1.released_at,
            author: a_graphql_entity_for(author1, :name)
          )
        ),
        a_graphql_entity_for(
          public_resource,
          latestVersion: a_graphql_entity_for(
            latest_version2,
            tagName: latest_version2.name,
            releasedAt: latest_version2.released_at,
            author: a_graphql_entity_for(author2, :name)
          )
        )
      )
    end

    it_behaves_like 'avoids N+1 queries'
  end

  describe 'openIssuesCount' do
    before_all do
      namespace.add_developer(user)
    end

    before_all do
      create(:issue, :opened, project: project1)
      create(:issue, :opened, project: project1)

      create(:issue, :opened, project: public_project)
    end

    let(:query) do
      <<~GQL
        query {
          ciCatalogResources {
            nodes {
              openIssuesCount
            }
          }
        }
      GQL
    end

    it 'returns the correct count' do
      post_query

      expect(graphql_data_at(:ciCatalogResources, :nodes)).to contain_exactly(
        a_graphql_entity_for(openIssuesCount: 2),
        a_graphql_entity_for(openIssuesCount: 1)
      )
    end

    it_behaves_like 'avoids N+1 queries'
  end

  describe 'openMergeRequestsCount' do
    before_all do
      namespace.add_developer(user)
    end

    before_all do
      create(:merge_request, :opened, source_project: project1)
      create(:merge_request, :opened, source_project: public_project)
    end

    let(:query) do
      <<~GQL
        query {
          ciCatalogResources {
            nodes {
              openMergeRequestsCount
            }
          }
        }
      GQL
    end

    it 'returns the correct count' do
      post_query

      expect(graphql_data_at(:ciCatalogResources, :nodes)).to contain_exactly(
        a_graphql_entity_for(openMergeRequestsCount: 1),
        a_graphql_entity_for(openMergeRequestsCount: 1)
      )
    end

    it_behaves_like 'avoids N+1 queries'
  end

  # TODO: https://gitlab.com/gitlab-org/gitlab/-/issues/429636
  context 'when using `projectPath` (legacy) to fetch resources' do
    let(:query) do
      <<~GQL
        query {
          ciCatalogResources(projectPath: "#{project1.full_path}") {
            nodes {
              #{all_graphql_fields_for('CiCatalogResource', max_depth: 1)}
            }
          }
        }
      GQL
    end

    context 'when the current user has permission to read the namespace catalog' do
      before_all do
        namespace.add_developer(user)
      end

      it 'returns catalog resources with the expected data' do
        resource2 = create(:ci_catalog_resource, :published, project: project2)
        _resource_in_another_namespace = create(:ci_catalog_resource, :published)

        post_query

        expect(graphql_data_at(:ciCatalogResources, :nodes)).to contain_exactly(
          a_graphql_entity_for(resource1),
          a_graphql_entity_for(
            resource2, :name, :description,
            icon: project2.avatar_path,
            webPath: "/#{project2.full_path}",
            starCount: project2.star_count,
            readmeHtml: '',
            latestReleasedAt: resource2.latest_released_at
          )
        )
      end

      it_behaves_like 'avoids N+1 queries'
    end

    context 'when the current user does not have permission to read the namespace catalog' do
      it 'returns no resources' do
        post_query

        expect(graphql_data_at(:ciCatalogResources, :nodes)).to be_empty
      end
    end
  end
end