1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe 'Query.project(fullPath).inheritedCiVariables', feature_category: :secrets_management do
include GraphqlHelpers
let_it_be(:user) { create(:user) }
let_it_be(:group) { create(:group) }
let_it_be(:subgroup) { create(:group, parent: group) }
let_it_be(:project) { create(:project, group: subgroup) }
let(:query) do
%(
query {
project(fullPath: "#{project.full_path}") {
inheritedCiVariables {
nodes {
id
key
environmentScope
groupName
groupCiCdSettingsPath
masked
protected
raw
variableType
}
}
}
}
)
end
def create_variables
create(:ci_group_variable, group: group)
create(:ci_group_variable, group: subgroup)
end
context 'when user is not a project maintainer' do
before do
project.add_developer(user)
end
it 'returns nothing' do
post_graphql(query, current_user: user)
expect(graphql_data.dig('project', 'inheritedCiVariables')).to be_nil
end
end
context 'when user is a project maintainer' do
before do
project.add_maintainer(user)
end
it "returns the project's CI variables inherited from its parent group and ancestors" do
group_var = create(:ci_group_variable, group: group, key: 'GROUP_VAR_A',
environment_scope: 'production', masked: false, protected: true, raw: true)
subgroup_var = create(:ci_group_variable, group: subgroup, key: 'SUBGROUP_VAR_B',
masked: true, protected: false, raw: false, variable_type: 'file')
post_graphql(query, current_user: user)
expect(graphql_data.dig('project', 'inheritedCiVariables', 'nodes')).to eq([
{
'id' => group_var.to_global_id.to_s,
'key' => 'GROUP_VAR_A',
'environmentScope' => 'production',
'groupName' => group.name,
'groupCiCdSettingsPath' => group_var.group_ci_cd_settings_path,
'masked' => false,
'protected' => true,
'raw' => true,
'variableType' => 'ENV_VAR'
},
{
'id' => subgroup_var.to_global_id.to_s,
'key' => 'SUBGROUP_VAR_B',
'environmentScope' => '*',
'groupName' => subgroup.name,
'groupCiCdSettingsPath' => subgroup_var.group_ci_cd_settings_path,
'masked' => true,
'protected' => false,
'raw' => false,
'variableType' => 'FILE'
}
])
end
it 'avoids N+1 database queries' do
create_variables
baseline = ActiveRecord::QueryRecorder.new do
run_with_clean_state(query, context: { current_user: user })
end
create_variables
multi = ActiveRecord::QueryRecorder.new do
run_with_clean_state(query, context: { current_user: user })
end
expect(multi).not_to exceed_query_limit(baseline)
end
end
end
|
