1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe 'Creating the container registry protection rule', :aggregate_failures, feature_category: :container_registry do
include GraphqlHelpers
let_it_be(:project) { create(:project) }
let_it_be(:user) { create(:user, maintainer_projects: [project]) }
let(:container_registry_protection_rule_attributes) do
build_stubbed(:container_registry_protection_rule, project: project)
end
let(:kwargs) do
{
project_path: project.full_path,
container_path_pattern: container_registry_protection_rule_attributes.container_path_pattern,
push_protected_up_to_access_level: 'MAINTAINER',
delete_protected_up_to_access_level: 'MAINTAINER'
}
end
let(:mutation) do
graphql_mutation(:create_container_registry_protection_rule, kwargs,
<<~QUERY
containerRegistryProtectionRule {
id
containerPathPattern
}
clientMutationId
errors
QUERY
)
end
let(:mutation_response) { graphql_mutation_response(:create_container_registry_protection_rule) }
subject { post_graphql_mutation(mutation, current_user: user) }
shared_examples 'a successful response' do
it { subject.tap { expect_graphql_errors_to_be_empty } }
it do
subject
expect(mutation_response).to include(
'errors' => be_blank,
'containerRegistryProtectionRule' => {
'id' => be_present,
'containerPathPattern' => kwargs[:container_path_pattern]
}
)
end
it 'creates container registry protection rule in the database' do
expect { subject }.to change { ::ContainerRegistry::Protection::Rule.count }.by(1)
expect(::ContainerRegistry::Protection::Rule.where(project: project,
container_path_pattern: kwargs[:container_path_pattern])).to exist
end
end
shared_examples 'an erroneous response' do
it { expect { subject }.not_to change { ::ContainerRegistry::Protection::Rule.count } }
end
it_behaves_like 'a successful response'
context 'with invalid input fields `pushProtectedUpToAccessLevel` and `deleteProtectedUpToAccessLevel`' do
let(:kwargs) do
super().merge(
push_protected_up_to_access_level: 'UNKNOWN_ACCESS_LEVEL',
delete_protected_up_to_access_level: 'UNKNOWN_ACCESS_LEVEL'
)
end
it_behaves_like 'an erroneous response'
it {
subject
expect_graphql_errors_to_include([/pushProtectedUpToAccessLevel/, /deleteProtectedUpToAccessLevel/])
}
end
context 'with invalid input field `containerPathPattern`' do
let(:kwargs) do
super().merge(container_path_pattern: '')
end
it_behaves_like 'an erroneous response'
it { subject.tap { expect_graphql_errors_to_be_empty } }
it {
subject.tap do
expect(mutation_response['errors']).to eq ["Container path pattern can't be blank"]
end
}
end
context 'with existing containers protection rule' do
let_it_be(:existing_container_registry_protection_rule) do
create(:container_registry_protection_rule, project: project,
push_protected_up_to_access_level: Gitlab::Access::DEVELOPER)
end
context 'when container name pattern is slightly different' do
let(:kwargs) do
# The field `container_path_pattern` is unique; this is why we change the value in a minimum way
super().merge(
container_path_pattern: "#{existing_container_registry_protection_rule.container_path_pattern}-unique"
)
end
it_behaves_like 'a successful response'
it 'adds another container registry protection rule to the database' do
expect { subject }.to change { ::ContainerRegistry::Protection::Rule.count }.from(1).to(2)
end
end
context 'when field `container_path_pattern` is taken' do
let(:kwargs) do
super().merge(container_path_pattern: existing_container_registry_protection_rule.container_path_pattern,
push_protected_up_to_access_level: 'MAINTAINER')
end
it_behaves_like 'an erroneous response'
it { subject.tap { expect_graphql_errors_to_be_empty } }
it 'returns without error' do
subject
expect(mutation_response['errors']).to eq ['Container path pattern has already been taken']
end
it 'does not create new container protection rules' do
expect(::ContainerRegistry::Protection::Rule.where(project: project,
container_path_pattern: kwargs[:container_path_pattern],
push_protected_up_to_access_level: Gitlab::Access::MAINTAINER)).not_to exist
end
end
end
context 'when user does not have permission' do
let_it_be(:developer) { create(:user).tap { |u| project.add_developer(u) } }
let_it_be(:reporter) { create(:user).tap { |u| project.add_reporter(u) } }
let_it_be(:guest) { create(:user).tap { |u| project.add_guest(u) } }
let_it_be(:anonymous) { create(:user) }
where(:user) do
[ref(:developer), ref(:reporter), ref(:guest), ref(:anonymous)]
end
with_them do
it_behaves_like 'an erroneous response'
it { subject.tap { expect_graphql_errors_to_include(/you don't have permission to perform this action/) } }
end
end
context "when feature flag ':container_registry_protected_containers' disabled" do
before do
stub_feature_flags(container_registry_protected_containers: false)
end
it_behaves_like 'an erroneous response'
it { subject.tap { expect(::ContainerRegistry::Protection::Rule.where(project: project)).not_to exist } }
it 'returns error of disabled feature flag' do
subject.tap do
expect_graphql_errors_to_include(/'container_registry_protected_containers' feature flag is disabled/)
end
end
end
end
|
