blob: a5be2a95c8bb2f89d467f45d1d44f26d721b8e1f (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe 'Setting reviewers of a merge request', :assume_throttled, feature_category: :code_review do
include GraphqlHelpers
let_it_be(:project) { create(:project, :repository) }
let_it_be(:current_user) { create(:user, developer_projects: [project]) }
let_it_be(:reviewer) { create(:user) }
let_it_be(:reviewer2) { create(:user) }
let_it_be_with_reload(:merge_request) { create(:merge_request, source_project: project) }
let(:input) { { reviewer_usernames: [reviewer.username] } }
let(:expected_result) do
[{ 'username' => reviewer.username }]
end
let(:mutation) do
variables = {
project_path: project.full_path,
iid: merge_request.iid.to_s
}
graphql_mutation(:merge_request_set_reviewers, variables.merge(input),
<<-QL.strip_heredoc
clientMutationId
errors
mergeRequest {
id
reviewers {
nodes {
username
}
}
}
QL
)
end
def mutation_response
graphql_mutation_response(:merge_request_set_reviewers)
end
def mutation_reviewer_nodes
mutation_response['mergeRequest']['reviewers']['nodes']
end
def run_mutation!
post_graphql_mutation(mutation, current_user: current_user)
end
before do
project.add_developer(reviewer)
project.add_developer(reviewer2)
merge_request.update!(reviewers: [])
end
it 'returns an error if the user is not allowed to update the merge request' do
post_graphql_mutation(mutation, current_user: create(:user))
expect(graphql_errors).not_to be_empty
end
context 'when the current user does not have permission to add reviewers' do
let(:current_user) { create(:user) }
it 'does not change the reviewers' do
project.add_guest(current_user)
expect { run_mutation! }.not_to change { merge_request.reset.reviewers.pluck(:id) }
expect(graphql_errors).not_to be_empty
end
end
context 'with reviewers already assigned' do
before do
merge_request.reviewers = [reviewer2]
merge_request.save!
end
it 'replaces the reviewer' do
run_mutation!
expect(response).to have_gitlab_http_status(:success)
expect(mutation_reviewer_nodes).to match_array(expected_result)
end
end
context 'when passing an empty list of reviewers' do
let(:input) { { reviewer_usernames: [] } }
before do
merge_request.reviewers = [reviewer2]
merge_request.save!
end
it 'removes reviewer' do
run_mutation!
expect(response).to have_gitlab_http_status(:success)
expect(mutation_reviewer_nodes).to eq([])
end
end
end
|