1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe 'Destroying multiple packages', feature_category: :package_registry do
using RSpec::Parameterized::TableSyntax
include GraphqlHelpers
let_it_be(:project1) { create(:project) }
let_it_be(:project2) { create(:project) }
let_it_be(:user) { create(:user) }
let_it_be_with_reload(:packages1) { create_list(:package, 3, project: project1) }
let_it_be_with_reload(:packages2) { create_list(:package, 2, project: project2) }
let(:ids) { packages1.append(packages2).flatten.map(&:to_global_id).map(&:to_s) }
let(:query) do
<<~GQL
errors
GQL
end
let(:params) do
{
ids: ids
}
end
let(:mutation) { graphql_mutation(:destroy_packages, params, query) }
describe 'post graphql mutation' do
subject(:mutation_request) { post_graphql_mutation(mutation, current_user: user) }
shared_examples 'destroying the packages' do
it 'marks the packages as pending destruction' do
expect { mutation_request }.to change { ::Packages::Package.pending_destruction.count }.by(5)
end
it_behaves_like 'returning response status', :success
context 'when npm package' do
let_it_be_with_reload(:packages1) { create_list(:npm_package, 3, project: project1, name: 'test-package-1') }
let_it_be_with_reload(:packages2) { create_list(:npm_package, 2, project: project2, name: 'test-package-2') }
it 'enqueues the worker to sync a metadata cache' do
arguments = []
expect(Packages::Npm::CreateMetadataCacheWorker)
.to receive(:bulk_perform_async_with_contexts).and_wrap_original do |original_method, *args|
packages = args.first
arguments = packages.map(&args.second[:arguments_proc]).uniq
original_method.call(*args)
end
mutation_request
expect(arguments).to contain_exactly([project1.id, 'test-package-1'], [project2.id, 'test-package-2'])
end
end
end
shared_examples 'denying the mutation request' do
|response = ::Gitlab::Graphql::Authorize::AuthorizeResource::RESOURCE_ACCESS_ERROR|
it 'does not mark the packages as pending destruction' do
expect { mutation_request }.not_to change { ::Packages::Package.pending_destruction.count }
expect_graphql_errors_to_include(response)
end
it_behaves_like 'returning response status', :success
end
context 'with valid params' do
where(:user_role, :shared_examples_name) do
:maintainer | 'destroying the packages'
:developer | 'denying the mutation request'
:reporter | 'denying the mutation request'
:guest | 'denying the mutation request'
:not_in_project | 'denying the mutation request'
end
with_them do
before do
unless user_role == :not_in_project
project1.send("add_#{user_role}", user)
project2.send("add_#{user_role}", user)
end
end
it_behaves_like params[:shared_examples_name]
end
context 'for over the limit' do
before do
project1.add_maintainer(user)
project2.add_maintainer(user)
stub_const("Mutations::Packages::BulkDestroy::MAX_PACKAGES", 2)
end
it_behaves_like 'denying the mutation request', ::Mutations::Packages::BulkDestroy::TOO_MANY_IDS_ERROR
end
context 'with packages outside of the project' do
before do
project1.add_maintainer(user)
end
it_behaves_like 'denying the mutation request'
end
end
context 'with invalid params' do
let(:ids) { 'foo' }
it_behaves_like 'denying the mutation request', 'invalid value for id'
end
context 'with multi mutations' do
let(:package1) { packages1.first }
let(:package2) { packages2.first }
let(:query) do
<<~QUERY
mutation {
a: destroyPackages(input: { ids: ["#{package1.to_global_id}"]}) {
errors
}
b: destroyPackages(input: { ids: ["#{package2.to_global_id}"]}) {
errors
}
}
QUERY
end
subject(:mutation_request) { post_graphql(query, current_user: user) }
before do
project1.add_maintainer(user)
project2.add_maintainer(user)
end
it 'executes the first mutation but not the second one' do
expect { mutation_request }.to change { package1.reload.status }.from('default').to('pending_destruction')
.and not_change { package2.reload.status }
expect_graphql_errors_to_include('"destroyPackages" field can be requested only for 1 Mutation(s) at a time.')
end
end
end
end
|
