1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe JwksController, feature_category: :system_access do
describe 'Endpoints from the parent Doorkeeper::OpenidConnect::DiscoveryController' do
it 'respond successfully' do
[
"/oauth/discovery/keys",
"/.well-known/openid-configuration",
"/.well-known/webfinger?resource=#{create(:user).email}"
].each do |endpoint|
get endpoint
expect(response).to have_gitlab_http_status(:ok)
end
end
end
describe 'GET /-/jwks' do
let_it_be(:ci_jwt_signing_key) { OpenSSL::PKey::RSA.generate(3072) }
let_it_be(:ci_jwk) { ci_jwt_signing_key.to_jwk }
let_it_be(:oidc_jwk) { OpenSSL::PKey::RSA.new(Rails.application.secrets.openid_connect_signing_key).to_jwk }
before do
stub_application_setting(ci_jwt_signing_key: ci_jwt_signing_key.to_s)
end
it 'returns signing keys used to sign CI_JOB_JWT' do
get jwks_url
expect(response).to have_gitlab_http_status(:ok)
ids = json_response['keys'].map { |jwk| jwk['kid'] }
expect(ids).to contain_exactly(ci_jwk['kid'], oidc_jwk['kid'])
end
it 'includes the OIDC signing key ID' do
get jwks_url
expect(response).to have_gitlab_http_status(:ok)
ids = json_response['keys'].map { |jwk| jwk['kid'] }
expect(ids).to include(Doorkeeper::OpenidConnect.signing_key_normalized.symbolize_keys[:kid])
end
it 'does not leak private key data' do
get jwks_url
aggregate_failures do
json_response['keys'].each do |jwk|
expect(jwk.keys).to contain_exactly('kty', 'kid', 'e', 'n', 'use', 'alg')
expect(jwk['use']).to eq('sig')
expect(jwk['alg']).to eq('RS256')
end
end
end
it 'has cache control header' do
get jwks_url
expect(response).to have_gitlab_http_status(:ok)
expect(response.headers['Cache-Control']).to include('max-age=86400', 'public', 'must-revalidate', 'no-transform')
end
context 'when cache_control_headers_for_openid_jwks feature flag is disabled' do
before do
stub_feature_flags(cache_control_headers_for_openid_jwks: false)
end
it 'does not have cache control header' do
get jwks_url
expect(response).to have_gitlab_http_status(:ok)
expect(response.headers['Cache-Control']).not_to include('max-age=86400', 'public',
'no-transform')
end
end
end
end
|
