1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe Projects::Ml::CandidatesController, feature_category: :mlops do
let_it_be(:project) { create(:project, :repository) }
let_it_be(:user) { project.first_owner }
let_it_be(:experiment) { create(:ml_experiments, project: project, user: user) }
let_it_be(:candidate) do
create(:ml_candidates, experiment: experiment, user: user, project: project).tap do |c|
c.update!(ci_build: create(:ci_build))
end
end
let(:ff_value) { true }
let(:candidate_iid) { candidate.iid }
let(:read_model_experiments) { true }
let(:write_model_experiments) { true }
before do
allow(Ability).to receive(:allowed?).and_call_original
allow(Ability).to receive(:allowed?)
.with(user, :read_model_experiments, project)
.and_return(read_model_experiments)
allow(Ability).to receive(:allowed?)
.with(user, :write_model_experiments, project)
.and_return(write_model_experiments)
sign_in(user)
end
shared_examples 'renders 404' do
it 'renders 404' do
expect(response).to have_gitlab_http_status(:not_found)
end
end
shared_examples '404 if candidate does not exist' do
context 'when experiment does not exist' do
let(:candidate_iid) { non_existing_record_id }
it_behaves_like 'renders 404'
end
end
shared_examples 'requires read_model_experiments' do
context 'when user does not have access' do
let(:read_model_experiments) { false }
it_behaves_like 'renders 404'
end
end
describe 'GET show' do
let(:can_read_build) { true }
before do
allow(Ability).to receive(:allowed?)
.with(user, :read_build, candidate.ci_build)
.and_return(can_read_build)
show_candidate
end
it 'renders the template' do
expect(response).to render_template('projects/ml/candidates/show')
end
it 'does not perform N+1 sql queries' do
control_count = ActiveRecord::QueryRecorder.new(skip_cached: false) { show_candidate }
create_list(:ml_candidate_params, 3, candidate: candidate)
create_list(:ml_candidate_metrics, 3, candidate: candidate)
expect { show_candidate }.not_to exceed_all_query_limit(control_count)
end
context 'when user has permission to read the build' do
it 'includes ci build info' do
expect(assigns[:include_ci_info]).to eq(true)
end
end
context 'when user has no permission to read the build' do
let(:can_read_build) { false }
it 'sets include_ci_job to false' do
expect(assigns[:include_ci_info]).to eq(false)
end
end
it_behaves_like '404 if candidate does not exist'
it_behaves_like 'requires read_model_experiments'
end
describe 'DELETE #destroy' do
let_it_be(:candidate_for_deletion) do
create(:ml_candidates, project: project, experiment: experiment, user: user)
end
let(:candidate_iid) { candidate_for_deletion.iid }
before do
destroy_candidate
end
it 'deletes the experiment', :aggregate_failures do
expect(response).to have_gitlab_http_status(:found)
expect(flash[:notice]).to eq('Candidate removed')
expect(response).to redirect_to("/#{project.full_path}/-/ml/experiments/#{experiment.iid}")
expect { Ml::Candidate.find(id: candidate_for_deletion.id) }.to raise_error(ActiveRecord::RecordNotFound)
end
it_behaves_like '404 if candidate does not exist'
describe 'requires write_model_experiments' do
let(:write_model_experiments) { false }
it 'is 404' do
expect(response).to have_gitlab_http_status(:not_found)
end
end
end
private
def show_candidate
get project_ml_candidate_path(project, iid: candidate_iid)
end
def destroy_candidate
delete project_ml_candidate_path(project, candidate_iid)
end
end
|
