Welcome to mirror list, hosted at ThFree Co, Russian Federation.

json_spec.rb « gitlab « cop « rubocop « spec - gitlab.com/gitlab-org/gitlab-foss.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
blob: 70f63a78dd1f88be824f822a7e16e6d403790f90 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
# frozen_string_literal: true

require 'rubocop_spec_helper'
require_relative '../../../../rubocop/cop/gitlab/json'

RSpec.describe RuboCop::Cop::Gitlab::Json do
  context 'when ::JSON is called' do
    it 'registers an offense and autocorrects' do
      expect_offense(<<~RUBY)
        class Foo
          def bar
            JSON.parse('{ "foo": "bar" }')
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Prefer `Gitlab::Json` over calling `JSON` directly. [...]
          end
        end
      RUBY

      expect_correction(<<~RUBY)
        class Foo
          def bar
            Gitlab::Json.parse('{ "foo": "bar" }')
          end
        end
      RUBY
    end
  end

  context 'when ::JSON is called in EE' do
    it 'registers an offense and autocorrects' do
      expect_offense(<<~RUBY, '/path/to/ee/foo.rb')
        class Foo
          def bar
            JSON.parse('{ "foo": "bar" }')
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Prefer `Gitlab::Json` over calling `JSON` directly. [...]
          end
        end
      RUBY

      expect_correction(<<~RUBY)
        class Foo
          def bar
            ::Gitlab::Json.parse('{ "foo": "bar" }')
          end
        end
      RUBY
    end
  end

  context 'when ActiveSupport::JSON is called' do
    it 'registers an offense and autocorrects' do
      expect_offense(<<~RUBY)
        class Foo
          def bar
            ActiveSupport::JSON.parse('{ "foo": "bar" }')
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Prefer `Gitlab::Json` over calling `JSON` directly. [...]
          end
        end
      RUBY

      expect_correction(<<~RUBY)
        class Foo
          def bar
            Gitlab::Json.parse('{ "foo": "bar" }')
          end
        end
      RUBY
    end
  end
end