spec/services/ci/job_artifacts/destroy_batch_service_spec.rb


1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91

# frozen_string_literal: true

require 'spec_helper'

RSpec.describe Ci::JobArtifacts::DestroyBatchService do
  let(:artifacts) { Ci::JobArtifact.all }
  let(:service) { described_class.new(artifacts, pick_up_at: Time.current) }

  describe '.execute' do
    subject(:execute) { service.execute }

    let_it_be(:artifact, refind: true) do
      create(:ci_job_artifact)
    end

    context 'when the artifact has a file attached to it' do
      before do
        artifact.file = fixture_file_upload(Rails.root.join('spec/fixtures/ci_build_artifacts.zip'), 'application/zip')
        artifact.save!
      end

      it 'creates a deleted object' do
        expect { subject }.to change { Ci::DeletedObject.count }.by(1)
      end

      it 'does not remove the files' do
        expect { execute }.not_to change { artifact.file.exists? }
      end

      it 'reports metrics for destroyed artifacts' do
        expect_next_instance_of(Gitlab::Ci::Artifacts::Metrics) do |metrics|
          expect(metrics).to receive(:increment_destroyed_artifacts_count).with(1).and_call_original
          expect(metrics).to receive(:increment_destroyed_artifacts_bytes).with(107464).and_call_original
        end

        execute
      end

      context 'ProjectStatistics' do
        it 'resets project statistics' do
          expect(ProjectStatistics).to receive(:increment_statistic).once
            .with(artifact.project, :build_artifacts_size, -artifact.file.size)
            .and_call_original

          execute
        end

        context 'with update_stats: false' do
          it 'does not update project statistics' do
            expect(ProjectStatistics).not_to receive(:increment_statistic)

            service.execute(update_stats: false)
          end

          it 'returns size statistics' do
            expect(service.execute(update_stats: false)).to match(
              a_hash_including(statistics_updates: { artifact.project => -artifact.file.size }))
          end
        end
      end
    end

    context 'when failed to destroy artifact' do
      context 'when the import fails' do
        before do
          expect(Ci::DeletedObject)
            .to receive(:bulk_import)
            .once
            .and_raise(ActiveRecord::RecordNotDestroyed)
        end

        it 'raises an exception and stop destroying' do
          expect { execute }.to raise_error(ActiveRecord::RecordNotDestroyed)
                            .and not_change { Ci::JobArtifact.count }.from(1)
        end
      end
    end

    context 'when there are no artifacts' do
      let(:artifacts) { Ci::JobArtifact.none }

      it 'does not raise error' do
        expect { execute }.not_to raise_error
      end

      it 'reports the number of destroyed artifacts' do
        is_expected.to eq(destroyed_artifacts_count: 0, statistics_updates: {}, status: :success)
      end
    end
  end
end