1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe Ci::PipelineSchedules::VariablesUpdateService, feature_category: :continuous_integration do
let_it_be(:reporter) { create(:user) }
let_it_be_with_reload(:user) { create(:user) }
let_it_be_with_reload(:developer) { create(:user) }
let_it_be_with_reload(:project) { create(:project, :public, :repository) }
let(:pipeline_schedule) { create(:ci_pipeline_schedule, project: project, owner: user) }
let(:pipeline_schedule_variable) { create(:ci_pipeline_schedule_variable, pipeline_schedule: pipeline_schedule) }
subject(:service) { described_class.new(pipeline_schedule_variable, user, params) }
before_all do
project.add_maintainer(user)
project.add_developer(developer)
project.add_reporter(reporter)
end
describe 'execute' do
context 'when user does not have permission' do
subject(:service) { described_class.new(pipeline_schedule_variable, reporter, {}) }
it 'returns ServiceResponse.error' do
result = service.execute
expect(result).to be_a(ServiceResponse)
expect(result.error?).to be(true)
error_message = _('The current user is not authorized to update the pipeline schedule variables')
expect(result.message).to match_array([error_message])
expect(result.payload.errors).to match_array([error_message])
end
end
context 'when user limited with permission on a project' do
let(:pipeline_schedule) { create(:ci_pipeline_schedule, project: project, owner: developer) }
subject(:service) { described_class.new(pipeline_schedule_variable, developer, {}) }
before do
project.update!(restrict_user_defined_variables: true)
end
it 'returns ServiceResponse.error' do
result = service.execute
expect(result).to be_a(ServiceResponse)
expect(result.error?).to be(true)
error_message = _('The current user is not authorized to set pipeline schedule variables')
expect(result.message).to match_array([error_message])
expect(result.payload.errors).to match_array([error_message])
end
end
context 'when user has permissions' do
let(:params) do
{
key: 'variable1',
value: 'value1',
variable_type: 'file'
}
end
subject(:service) { described_class.new(pipeline_schedule_variable, user, params) }
it 'saves variable with passed params' do
result = service.execute
expect(result.payload).to have_attributes(
key: 'variable1',
value: 'value1',
variable_type: 'file'
)
end
it 'returns ServiceResponse.success' do
result = service.execute
expect(result).to be_a(ServiceResponse)
expect(result.success?).to be(true)
end
end
context 'when schedule save fails' do
subject(:service) { described_class.new(pipeline_schedule_variable, user, {}) }
before do
allow(pipeline_schedule_variable).to receive(:save).and_return(false)
errors = ActiveModel::Errors.new(project)
errors.add(:base, 'An error occurred')
allow(pipeline_schedule_variable).to receive(:errors).and_return(errors)
end
it 'returns ServiceResponse.error' do
result = service.execute
expect(result).to be_a(ServiceResponse)
expect(result.error?).to be(true)
expect(result.message).to match_array(['An error occurred'])
end
end
end
end
|
