1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe ::DependencyProxy::ImageTtlGroupPolicies::UpdateService, feature_category: :dependency_proxy do
using RSpec::Parameterized::TableSyntax
let_it_be_with_reload(:group) { create(:group) }
let_it_be(:user) { create(:user) }
let_it_be(:params) { {} }
describe '#execute' do
subject { described_class.new(container: group, current_user: user, params: params).execute }
shared_examples 'returning a success' do
it 'returns a success' do
result = subject
expect(result.payload[:dependency_proxy_image_ttl_policy]).to be_present
expect(result).to be_success
end
end
shared_examples 'returning an error' do |message, http_status|
it 'returns an error' do
result = subject
expect(result).to have_attributes(
message: message,
status: :error,
http_status: http_status
)
end
end
shared_examples 'updating the dependency proxy image ttl policy' do
it_behaves_like 'updating the dependency proxy image ttl policy attributes',
from: { enabled: true, ttl: 90 },
to: { enabled: false, ttl: 2 }
it_behaves_like 'returning a success'
context 'with invalid params' do
let_it_be(:params) { { enabled: nil } }
it_behaves_like 'not creating the dependency proxy image ttl policy'
it "doesn't update" do
expect { subject }
.not_to change { ttl_policy.reload.enabled }
end
it_behaves_like 'returning an error', 'Enabled is not included in the list', 400
end
end
shared_examples 'denying access to dependency proxy image ttl policy' do
context 'with existing dependency proxy image ttl policy' do
it_behaves_like 'not creating the dependency proxy image ttl policy'
it_behaves_like 'returning an error', 'Access Denied', 403
end
end
# To be removed when raise_group_admin_package_permission_to_owner FF is removed
shared_examples 'disabling admin_package feature flag' do |action:|
before do
stub_feature_flags(raise_group_admin_package_permission_to_owner: false)
end
it_behaves_like "#{action} the dependency proxy image ttl policy"
end
before do
stub_config(dependency_proxy: { enabled: true })
end
context 'with existing dependency proxy image ttl policy' do
let_it_be(:ttl_policy) { create(:image_ttl_group_policy, group: group) }
let_it_be(:params) { { enabled: false, ttl: 2 } }
where(:user_role, :shared_examples_name) do
:owner | 'updating the dependency proxy image ttl policy'
:maintainer | 'denying access to dependency proxy image ttl policy'
:developer | 'denying access to dependency proxy image ttl policy'
:reporter | 'denying access to dependency proxy image ttl policy'
:guest | 'denying access to dependency proxy image ttl policy'
:anonymous | 'denying access to dependency proxy image ttl policy'
end
with_them do
before do
group.send("add_#{user_role}", user) unless user_role == :anonymous
end
it_behaves_like params[:shared_examples_name]
it_behaves_like 'disabling admin_package feature flag', action: :updating if params[:user_role] == :maintainer
end
end
context 'without existing dependency proxy image ttl policy' do
let_it_be(:ttl_policy) { group.dependency_proxy_image_ttl_policy }
where(:user_role, :shared_examples_name) do
:owner | 'creating the dependency proxy image ttl policy'
:maintainer | 'denying access to dependency proxy image ttl policy'
:developer | 'denying access to dependency proxy image ttl policy'
:reporter | 'denying access to dependency proxy image ttl policy'
:guest | 'denying access to dependency proxy image ttl policy'
:anonymous | 'denying access to dependency proxy image ttl policy'
end
with_them do
before do
group.send("add_#{user_role}", user) unless user_role == :anonymous
end
it_behaves_like params[:shared_examples_name]
it_behaves_like 'disabling admin_package feature flag', action: :creating if params[:user_role] == :maintainer
end
context 'when the policy is not found' do
%i[owner maintainer].each do |role|
context "when user is #{role}" do
before do
group.send("add_#{role}", user)
stub_feature_flags(raise_group_admin_package_permission_to_owner: false)
expect(group).to receive(:dependency_proxy_image_ttl_policy).and_return nil
end
it_behaves_like 'returning an error', 'Dependency proxy image TTL Policy not found', 404
end
end
end
end
end
end
|
