1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe MergeRequests::RemoveAttentionRequestedService do
let_it_be(:current_user) { create(:user) }
let_it_be(:user) { create(:user) }
let_it_be(:assignee_user) { create(:user) }
let_it_be(:merge_request) { create(:merge_request, reviewers: [user], assignees: [assignee_user]) }
let(:reviewer) { merge_request.find_reviewer(user) }
let(:assignee) { merge_request.find_assignee(assignee_user) }
let(:project) { merge_request.project }
let(:service) do
described_class.new(
project: project,
current_user: current_user,
merge_request: merge_request,
user: user
)
end
let(:result) { service.execute }
before do
allow(SystemNoteService).to receive(:remove_attention_request)
project.add_developer(current_user)
project.add_developer(user)
end
describe '#execute' do
context 'when current user cannot update merge request' do
let(:service) do
described_class.new(
project: project,
current_user: create(:user),
merge_request: merge_request,
user: user
)
end
it 'returns an error' do
expect(result[:status]).to eq :error
end
end
context 'when user is not a reviewer nor assignee' do
let(:service) do
described_class.new(
project: project,
current_user: current_user,
merge_request: merge_request,
user: create(:user)
)
end
it 'returns an error' do
expect(result[:status]).to eq :error
end
end
context 'when user is a reviewer' do
before do
reviewer.update!(state: :attention_requested)
end
it 'returns success' do
expect(result[:status]).to eq :success
end
it 'updates reviewer state' do
service.execute
reviewer.reload
expect(reviewer.state).to eq 'reviewed'
end
it 'creates a remove attention request system note' do
expect(SystemNoteService)
.to receive(:remove_attention_request)
.with(merge_request, merge_request.project, current_user, user)
service.execute
end
it_behaves_like 'invalidates attention request cache' do
let(:users) { [user] }
end
end
context 'when user is an assignee' do
let(:service) do
described_class.new(
project: project,
current_user: current_user,
merge_request: merge_request,
user: assignee_user
)
end
before do
assignee.update!(state: :attention_requested)
end
it 'returns success' do
expect(result[:status]).to eq :success
end
it 'updates assignee state' do
service.execute
assignee.reload
expect(assignee.state).to eq 'reviewed'
end
it_behaves_like 'invalidates attention request cache' do
let(:users) { [assignee_user] }
end
it 'creates a remove attention request system note' do
expect(SystemNoteService)
.to receive(:remove_attention_request)
.with(merge_request, merge_request.project, current_user, assignee_user)
service.execute
end
end
context 'when user is an assignee and reviewer at the same time' do
let_it_be(:merge_request) { create(:merge_request, reviewers: [user], assignees: [user]) }
let(:assignee) { merge_request.find_assignee(user) }
let(:service) do
described_class.new(
project: project,
current_user: current_user,
merge_request: merge_request,
user: user
)
end
before do
reviewer.update!(state: :attention_requested)
assignee.update!(state: :attention_requested)
end
it 'returns success' do
expect(result[:status]).to eq :success
end
it 'updates reviewers and assignees state' do
service.execute
reviewer.reload
assignee.reload
expect(reviewer.state).to eq 'reviewed'
expect(assignee.state).to eq 'reviewed'
end
end
context 'when state is already not attention_requested' do
before do
reviewer.update!(state: :reviewed)
end
it 'does not change state' do
service.execute
reviewer.reload
expect(reviewer.state).to eq 'reviewed'
end
it 'does not create a remove attention request system note' do
expect(SystemNoteService).not_to receive(:remove_attention_request)
service.execute
end
end
end
end
|
