1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe Projects::GroupLinks::CreateService, '#execute', feature_category: :groups_and_projects do
let_it_be(:user) { create :user }
let_it_be(:group) { create :group }
let_it_be(:project) { create(:project, namespace: create(:namespace, :with_namespace_settings)) }
let_it_be(:group_user) { create(:user).tap { |user| group.add_guest(user) } }
let(:opts) do
{
link_group_access: Gitlab::Access::DEVELOPER,
expires_at: nil
}
end
subject { described_class.new(project, group, user, opts) }
shared_examples_for 'not shareable' do
it 'does not share and returns an error' do
expect do
result = subject.execute
expect(result[:status]).to eq(:error)
expect(result[:http_status]).to eq(404)
end.not_to change { project.project_group_links.count }
end
end
shared_examples_for 'shareable' do
it 'adds group to project' do
expect do
result = subject.execute
expect(result[:status]).to eq(:success)
end.to change { project.project_group_links.count }.from(0).to(1)
end
end
context 'when user has proper permissions to share a project with a group' do
before do
group.add_guest(user)
end
context 'when the user is a MAINTAINER in the project' do
before do
project.add_maintainer(user)
end
it_behaves_like 'shareable'
it 'updates authorization', :sidekiq_inline do
expect { subject.execute }.to(
change { Ability.allowed?(group_user, :read_project, project) }
.from(false).to(true))
end
context 'with specialized project_authorization workers' do
let_it_be(:other_user) { create(:user) }
before do
group.add_developer(other_user)
end
it 'schedules authorization update for users with access to group' do
stub_feature_flags(do_not_run_safety_net_auth_refresh_jobs: false)
expect(AuthorizedProjectsWorker).not_to(
receive(:bulk_perform_async)
)
expect(AuthorizedProjectUpdate::ProjectRecalculateWorker).to(
receive(:perform_async)
.with(project.id)
.and_call_original
)
expect(AuthorizedProjectUpdate::UserRefreshFromReplicaWorker).to(
receive(:bulk_perform_in).with(
1.hour,
array_including([user.id], [other_user.id]),
batch_delay: 30.seconds, batch_size: 100
).and_call_original
)
subject.execute
end
end
context 'when sharing outside the hierarchy is disabled' do
let_it_be(:shared_group_parent) do
create(:group,
namespace_settings: create(:namespace_settings, prevent_sharing_groups_outside_hierarchy: true)
)
end
let_it_be(:project, reload: true) { create(:project, group: shared_group_parent) }
it_behaves_like 'not shareable'
context 'when group is inside hierarchy' do
let(:group) { create(:group, :private, parent: shared_group_parent) }
it_behaves_like 'shareable'
end
end
context 'when sharing it to a group with OWNER access' do
let(:opts) do
{
link_group_access: Gitlab::Access::OWNER,
expires_at: nil
}
end
it 'does not share and returns a forbiden error' do
expect do
result = subject.execute
expect(result[:status]).to eq(:error)
expect(result[:http_status]).to eq(403)
end.not_to change { project.reload.project_group_links.count }
end
end
end
context 'when the user is an OWNER in the project' do
before do
project.add_owner(user)
end
it_behaves_like 'shareable'
context 'when sharing it to a group with OWNER access' do
let(:opts) do
{
link_group_access: Gitlab::Access::OWNER,
expires_at: nil
}
end
it_behaves_like 'shareable'
end
end
end
context 'when user does not have permissions to share the project with a group' do
it_behaves_like 'not shareable'
context 'when the user has less than MAINTAINER access in the project' do
before do
group.add_guest(user)
project.add_developer(user)
end
it_behaves_like 'not shareable'
end
end
context 'when group is blank' do
let(:group) { nil }
it_behaves_like 'not shareable'
end
end
|
