blob: fab8b0c61fa272caf8c290bced882dbc0f2b2885 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
|
# frozen_string_literal: true
require 'gitlab-dangerfiles'
require 'gitlab/dangerfiles/spec_helper'
require_relative '../../../tooling/danger/product_intelligence'
require_relative '../../../tooling/danger/project_helper'
RSpec.describe Tooling::Danger::ProductIntelligence do
include_context "with dangerfile"
subject(:product_intelligence) { fake_danger.new(helper: fake_helper) }
let(:fake_danger) { DangerSpecHelper.fake_danger.include(described_class) }
let(:previous_label_to_add) { 'label_to_add' }
let(:labels_to_add) { [previous_label_to_add] }
let(:ci_env) { true }
let(:has_product_intelligence_label) { true }
before do
allow(fake_helper).to receive(:changed_lines).and_return(changed_lines)
allow(fake_helper).to receive(:labels_to_add).and_return(labels_to_add)
allow(fake_helper).to receive(:ci?).and_return(ci_env)
allow(fake_helper).to receive(:mr_has_labels?).with('product intelligence').and_return(has_product_intelligence_label)
end
describe '#check!' do
subject { product_intelligence.check! }
let(:markdown_formatted_list) { 'markdown formatted list' }
let(:review_pending_label) { 'product intelligence::review pending' }
let(:approved_label) { 'product intelligence::approved' }
let(:changed_files) { ['metrics/counts_7d/test_metric.yml'] }
let(:changed_lines) { ['+tier: ee'] }
before do
allow(fake_helper).to receive(:all_changed_files).and_return(changed_files)
allow(fake_helper).to receive(:changes_by_category).and_return(product_intelligence: changed_files, database: ['other_files.yml'])
allow(fake_helper).to receive(:markdown_list).with(changed_files).and_return(markdown_formatted_list)
end
shared_examples "doesn't add new labels" do
it "doesn't add new labels" do
subject
expect(labels_to_add).to match_array [previous_label_to_add]
end
end
shared_examples "doesn't add new warnings" do
it "doesn't add new warnings" do
expect(product_intelligence).not_to receive(:warn)
subject
end
end
shared_examples 'adds new labels' do
it 'adds new labels' do
subject
expect(labels_to_add).to match_array [previous_label_to_add, review_pending_label]
end
end
context 'with growth experiment label' do
before do
allow(fake_helper).to receive(:mr_has_labels?).with('growth experiment').and_return(true)
end
include_examples "doesn't add new labels"
include_examples "doesn't add new warnings"
end
context 'without growth experiment label' do
before do
allow(fake_helper).to receive(:mr_has_labels?).with('growth experiment').and_return(false)
end
context 'with approved label' do
let(:mr_labels) { [approved_label] }
include_examples "doesn't add new labels"
include_examples "doesn't add new warnings"
end
context 'without approved label' do
include_examples 'adds new labels'
it 'warns with proper message' do
expect(product_intelligence).to receive(:warn).with(%r{#{markdown_formatted_list}})
subject
end
end
context 'with product intelligence::review pending label' do
let(:mr_labels) { ['product intelligence::review pending'] }
include_examples "doesn't add new labels"
end
context 'with product intelligence::approved label' do
let(:mr_labels) { ['product intelligence::approved'] }
include_examples "doesn't add new labels"
end
context 'with the product intelligence label' do
let(:has_product_intelligence_label) { true }
context 'with ci? false' do
let(:ci_env) { false }
include_examples "doesn't add new labels"
end
context 'with ci? true' do
include_examples 'adds new labels'
end
end
end
end
describe '#check_affected_scopes!' do
let(:fixture_dir_glob) { Dir.glob(File.join('spec', 'tooling', 'fixtures', 'metrics', '*.rb')) }
let(:changed_lines) { ['+ scope :active, -> { iwhere(email: Array(emails)) }'] }
before do
allow(Dir).to receive(:glob).and_return(fixture_dir_glob)
allow(fake_helper).to receive(:markdown_list).with({ 'active' => fixture_dir_glob }).and_return('a')
end
context 'when a model was modified' do
let(:modified_files) { ['app/models/super_user.rb'] }
context 'when a scope is changed' do
context 'and a metrics uses the affected scope' do
it 'producing warning' do
expect(product_intelligence).to receive(:warn).with(%r{#{modified_files}})
product_intelligence.check_affected_scopes!
end
end
context 'when no metrics using the affected scope' do
let(:changed_lines) { ['+scope :foo, -> { iwhere(email: Array(emails)) }'] }
it 'doesnt do anything' do
expect(product_intelligence).not_to receive(:warn)
product_intelligence.check_affected_scopes!
end
end
end
end
context 'when an unrelated model with matching scope was modified' do
let(:modified_files) { ['app/models/post_box.rb'] }
it 'doesnt do anything' do
expect(product_intelligence).not_to receive(:warn)
product_intelligence.check_affected_scopes!
end
end
context 'when models arent modified' do
let(:modified_files) { ['spec/app/models/user_spec.rb'] }
it 'doesnt do anything' do
expect(product_intelligence).not_to receive(:warn)
product_intelligence.check_affected_scopes!
end
end
end
end
|
