1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe Gitlab::GithubImport::ObjectImporter, :aggregate_failures, feature_category: :importers do
let(:worker) do
Class.new do
def self.name
'DummyWorker'
end
include(Gitlab::GithubImport::ObjectImporter)
def object_type
:dummy
end
def representation_class
MockRepresantation
end
end.new
end
let_it_be(:project) { create(:project, :import_started, import_url: 'https://github.com/foo/baz.git') }
let(:importer_class) { double(:importer_class, name: 'klass_name') }
let(:importer_instance) { double(:importer_instance) }
let(:client) { double(:client) }
let(:github_identifiers) do
{
some_id: 1,
some_type: '_some_type_',
object_type: 'dummy'
}
end
let(:representation_class) do
Class.new do
include Gitlab::GithubImport::Representation::ToHash
include Gitlab::GithubImport::Representation::ExposeAttribute
def self.from_json_hash(raw_hash)
new(Gitlab::GithubImport::Representation.symbolize_hash(raw_hash))
end
attr_reader :attributes
def initialize(attributes)
@attributes = attributes
end
def github_identifiers
{
some_id: 1,
some_type: '_some_type_',
object_type: 'dummy'
}
end
end
end
let(:stubbed_representation) { representation_class }
before do
stub_const('MockRepresantation', stubbed_representation)
end
describe '#import', :clean_gitlab_redis_cache do
before do
expect(worker)
.to receive(:importer_class)
.at_least(:once)
.and_return(importer_class)
end
it 'imports the object' do
expect(importer_class)
.to receive(:new)
.with(instance_of(MockRepresantation), project, client)
.and_return(importer_instance)
expect(importer_instance)
.to receive(:execute)
expect(Gitlab::GithubImport::Logger)
.to receive(:info)
.with(
{
github_identifiers: github_identifiers,
message: 'starting importer',
project_id: project.id,
importer: 'klass_name'
}
)
expect(Gitlab::GithubImport::Logger)
.to receive(:info)
.with(
{
github_identifiers: github_identifiers,
message: 'importer finished',
project_id: project.id,
importer: 'klass_name'
}
)
worker.import(project, client, { 'number' => 10, 'github_id' => 1 })
expect(Gitlab::GithubImport::ObjectCounter.summary(project)).to eq({
'fetched' => {},
'imported' => { 'dummy' => 1 }
})
end
it 'does not execute importer if import state is not in progress' do
allow(project.import_state).to receive(:status).and_return('failed')
expect(importer_class).not_to receive(:new)
expect(importer_instance).not_to receive(:execute)
expect(Gitlab::GithubImport::Logger)
.to receive(:info)
.with(
{
github_identifiers: nil,
message: 'Project import is no longer running. Stopping worker.',
project_id: project.id,
importer: 'klass_name',
import_status: 'failed'
}
)
worker.import(project, client, { 'number' => 11, 'github_id' => 2 } )
end
it 'logs error when the import fails' do
expect(importer_class)
.to receive(:new)
.with(instance_of(MockRepresantation), project, client)
.and_return(importer_instance)
exception = StandardError.new('some error')
expect(importer_instance)
.to receive(:execute)
.and_raise(exception)
expect(Gitlab::GithubImport::Logger)
.to receive(:info)
.with(
{
github_identifiers: github_identifiers,
message: 'starting importer',
project_id: project.id,
importer: 'klass_name'
}
)
expect(Gitlab::Import::ImportFailureService)
.to receive(:track)
.with(
project_id: project.id,
exception: exception,
error_source: 'klass_name',
fail_import: false
)
.and_call_original
expect { worker.import(project, client, { 'number' => 10, 'github_id' => 1 }) }
.to raise_error(exception)
expect(project.import_state.reload.status).to eq('started')
expect(project.import_failures).not_to be_empty
expect(project.import_failures.last.exception_class).to eq('StandardError')
expect(project.import_failures.last.exception_message).to eq('some error')
end
context 'without github_identifiers defined' do
let(:stubbed_representation) { representation_class.instance_eval { undef_method :github_identifiers } }
it 'logs error when representation does not have a github_id' do
expect(importer_class).not_to receive(:new)
expect(Gitlab::Import::ImportFailureService)
.to receive(:track)
.with(
project_id: project.id,
exception: a_kind_of(NoMethodError),
error_source: 'klass_name',
fail_import: true
)
.and_call_original
expect { worker.import(project, client, { 'number' => 10 }) }
.to raise_error(NoMethodError, /^undefined method `github_identifiers/)
end
end
context 'when the record is invalid' do
let(:exception) { ActiveRecord::RecordInvalid.new }
before do
expect(importer_class)
.to receive(:new)
.with(instance_of(MockRepresantation), project, client)
.and_return(importer_instance)
expect(importer_instance)
.to receive(:execute)
.and_raise(exception)
end
it 'logs an error' do
expect(Gitlab::GithubImport::Logger)
.to receive(:info)
.with(
{
github_identifiers: github_identifiers,
message: 'starting importer',
project_id: project.id,
importer: 'klass_name'
}
)
expect(Gitlab::Import::ImportFailureService)
.to receive(:track)
.with(
project_id: project.id,
exception: exception,
error_source: 'klass_name',
fail_import: false
)
.and_call_original
worker.import(project, client, { 'number' => 10, 'github_id' => 1 })
end
it 'updates external_identifiers of the correct failure' do
worker.import(project, client, { 'number' => 10, 'github_id' => 1 })
import_failures = project.import_failures
expect(import_failures.count).to eq(1)
expect(import_failures.first.external_identifiers).to eq(github_identifiers.with_indifferent_access)
end
end
end
describe '#increment_object_counter?' do
let(:issue) { double(:issue, pull_request?: true) }
it 'returns true' do
expect(worker).to be_increment_object_counter(issue)
end
end
describe '.sidekiq_retries_exhausted' do
let(:correlation_id) { 'abc' }
let(:job) do
{
'args' => [project.id, { number: 123, state: 'open' }, '123abc'],
'jid' => '123',
'correlation_id' => correlation_id
}
end
subject(:sidekiq_retries_exhausted) { worker.class.sidekiq_retries_exhausted_block.call(job, StandardError.new) }
context 'when all arguments are given' do
it 'notifies the JobWaiter' do
expect(Gitlab::JobWaiter)
.to receive(:notify)
.with(
job['args'].last,
job['jid']
)
sidekiq_retries_exhausted
end
end
context 'when not all arguments are given' do
let(:job) do
{
'args' => [project.id, { number: 123, state: 'open' }],
'jid' => '123',
'correlation_id' => correlation_id
}
end
it 'does not notify the JobWaiter' do
expect(Gitlab::JobWaiter).not_to receive(:notify)
sidekiq_retries_exhausted
end
end
it 'updates external_identifiers of the correct failure' do
failure_1, failure_2 = create_list(:import_failure, 2, project: project)
failure_2.update_column(:correlation_id_value, correlation_id)
sidekiq_retries_exhausted
expect(failure_1.reload.external_identifiers).to be_empty
expect(failure_2.reload.external_identifiers).to eq(github_identifiers.with_indifferent_access)
end
end
end
|