1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe MergeRequests::MergeabilityCheckBatchWorker, feature_category: :code_review_workflow do
subject { described_class.new }
let_it_be(:user) { create(:user) }
describe '#perform' do
context 'when some merge_requests do not exist' do
it 'ignores unknown merge request ids' do
expect(MergeRequests::MergeabilityCheckService).not_to receive(:new)
expect(Sidekiq.logger).not_to receive(:error)
subject.perform([1234, 5678], user.id)
end
end
context 'when some merge_requests needs mergeability checks' do
let(:merge_request_1) { create(:merge_request, merge_status: :unchecked) }
let(:merge_request_2) { create(:merge_request, merge_status: :unchecked) }
let(:merge_request_3) { create(:merge_request, merge_status: :can_be_merged) }
before do
merge_request_1.project.add_developer(user)
merge_request_2.project.add_reporter(user)
merge_request_3.project.add_developer(user)
end
it 'executes MergeabilityCheckService on merge requests that needs to be checked' do
expect_next_instance_of(MergeRequests::MergeabilityCheckService, merge_request_1) do |service|
expect(service).to receive(:execute).and_return(ServiceResponse.success)
end
expect(MergeRequests::MergeabilityCheckService).not_to receive(:new).with(merge_request_2.id)
expect(MergeRequests::MergeabilityCheckService).not_to receive(:new).with(merge_request_3.id)
expect(MergeRequests::MergeabilityCheckService).not_to receive(:new).with(1234)
subject.perform([merge_request_1.id, merge_request_2.id, merge_request_3.id, 1234], user.id)
end
it 'structurally logs a failed mergeability check' do
expect_next_instance_of(MergeRequests::MergeabilityCheckService, merge_request_1) do |service|
expect(service).to receive(:execute).and_return(ServiceResponse.error(message: "solar flares"))
end
expect(Sidekiq.logger).to receive(:error).once
.with(
merge_request_id: merge_request_1.id,
worker: described_class.to_s,
message: 'Failed to check mergeability of merge request: solar flares')
subject.perform([merge_request_1.id], user.id)
end
context 'when user is nil' do
let(:user) { nil }
it 'does not run any mergeability checks' do
expect(MergeRequests::MergeabilityCheckService).not_to receive(:new).with(merge_request_1.id)
expect(MergeRequests::MergeabilityCheckService).not_to receive(:new).with(merge_request_2.id)
expect(MergeRequests::MergeabilityCheckService).not_to receive(:new).with(merge_request_3.id)
expect(MergeRequests::MergeabilityCheckService).not_to receive(:new).with(1234)
subject.perform([merge_request_1.id, merge_request_2.id, merge_request_3.id, 1234], user&.id)
end
end
end
it_behaves_like 'an idempotent worker' do
let(:merge_request) { create(:merge_request) }
let(:job_args) { [[merge_request.id], user.id] }
it 'is mergeable' do
subject
expect(merge_request).to be_mergeable
end
end
end
end
|
