1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe ProcessCommitWorker, feature_category: :source_code_management do
let_it_be(:user) { create(:user) }
let(:project) { create(:project, :public, :repository) }
let(:issue) { create(:issue, project: project, author: user) }
let(:commit) { project.commit }
let(:worker) { described_class.new }
it "is deduplicated" do
expect(described_class.get_deduplicate_strategy).to eq(:until_executed)
expect(described_class.get_deduplication_options).to include(feature_flag: :deduplicate_process_commit_worker)
end
describe '#perform' do
subject(:perform) { worker.perform(project_id, user_id, commit.to_hash, default) }
let(:project_id) { project.id }
let(:user_id) { user.id }
before do
allow(Commit).to receive(:build_from_sidekiq_hash).and_return(commit)
end
context 'when pushing to the default branch' do
let(:default) { true }
context 'when project does not exist' do
let(:project_id) { -1 }
it 'does not close related issues' do
expect { perform }.to change { Issues::CloseWorker.jobs.size }.by(0)
perform
end
end
context 'when user does not exist' do
let(:user_id) { -1 }
it 'does not close related issues' do
expect { perform }.not_to change { Issues::CloseWorker.jobs.size }
perform
end
end
include_examples 'an idempotent worker' do
before do
allow(commit).to receive(:safe_message).and_return("Closes #{issue.to_reference}")
issue.metrics.update!(first_mentioned_in_commit_at: nil)
end
subject do
perform_multiple([project.id, user.id, commit.to_hash], worker: worker)
end
it 'closes related issues' do
expect { perform }.to change { Issues::CloseWorker.jobs.size }.by(1)
subject
end
end
context 'when commit is not a merge request merge commit' do
context 'when commit has issue reference' do
before do
allow(commit).to receive(:safe_message).and_return("Closes #{issue.to_reference}")
end
it 'closes issues that should be closed per the commit message' do
expect { perform }.to change { Issues::CloseWorker.jobs.size }.by(1)
end
it 'creates cross references' do
expect(commit).to receive(:create_cross_references!).with(user, [issue])
perform
end
describe 'issue metrics', :clean_gitlab_redis_cache do
context 'when issue has no first_mentioned_in_commit_at set' do
before do
issue.metrics.update!(first_mentioned_in_commit_at: nil)
end
it 'updates issue metrics' do
expect { perform }.to change { issue.metrics.reload.first_mentioned_in_commit_at }
.to(commit.committed_date)
end
end
context 'when issue has first_mentioned_in_commit_at earlier than given committed_date' do
before do
issue.metrics.update!(first_mentioned_in_commit_at: commit.committed_date - 1.day)
end
it "doesn't update issue metrics" do
expect { perform }.not_to change { issue.metrics.reload.first_mentioned_in_commit_at }
end
end
context 'when issue has first_mentioned_in_commit_at later than given committed_date' do
before do
issue.metrics.update!(first_mentioned_in_commit_at: commit.committed_date + 1.day)
end
it 'updates issue metrics' do
expect { perform }.to change { issue.metrics.reload.first_mentioned_in_commit_at }
.to(commit.committed_date)
end
end
end
end
context 'when commit has no issue references' do
before do
allow(commit).to receive(:safe_message).and_return("Lorem Ipsum")
end
describe 'issue metrics' do
it "doesn't execute any queries with false conditions" do
expect { perform }.not_to make_queries_matching(/WHERE (?:1=0|0=1)/)
end
end
end
end
context 'when commit is a merge request merge commit' do
let(:merge_request) do
create(
:merge_request,
description: "Closes #{issue.to_reference}",
source_branch: 'feature-merged',
target_branch: 'master',
source_project: project
)
end
let(:commit) do
project.repository.create_branch('feature-merged', 'feature')
project.repository.after_create_branch
MergeRequests::MergeService
.new(project: project, current_user: merge_request.author, params: { sha: merge_request.diff_head_sha })
.execute(merge_request)
merge_request.reload.merge_commit
end
it 'does not close any issues from the commit message' do
expect { perform }.not_to change { Issues::CloseWorker.jobs.size }
perform
end
it 'still creates cross references' do
expect(commit).to receive(:create_cross_references!).with(commit.author, [])
perform
end
end
end
context 'when pushing to a non-default branch' do
let(:default) { false }
before do
allow(commit).to receive(:safe_message).and_return("Closes #{issue.to_reference}")
end
it 'does not close any issues from the commit message' do
expect { perform }.not_to change { Issues::CloseWorker.jobs.size }
perform
end
it 'still creates cross references' do
expect(commit).to receive(:create_cross_references!).with(user, [])
perform
end
end
end
end
|
