Welcome to mirror list, hosted at ThFree Co, Russian Federation.

gitlab.com/gitlab-org/gitlab-pages.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJaime Martinez <jmartinez@gitlab.com>2021-09-30 06:33:53 +0300
committerJaime Martinez <jmartinez@gitlab.com>2021-09-30 06:36:45 +0300
commit25eeea495282065e82d7e72c6d8ffd01a6f79602 (patch)
treed6be61b2e9a2fcdf054a3d55a3894569ca0a869d
parent59913b292288277aa1192439fdfa97b1f59d03c5 (diff)
chore: update test names and default burst
-rw-r--r--internal/ratelimiter/ratelimiter.go4
-rw-r--r--internal/ratelimiter/ratelimiter_test.go4
2 files changed, 4 insertions, 4 deletions
diff --git a/internal/ratelimiter/ratelimiter.go b/internal/ratelimiter/ratelimiter.go
index 0753e187..e1cf076d 100644
--- a/internal/ratelimiter/ratelimiter.go
+++ b/internal/ratelimiter/ratelimiter.go
@@ -15,8 +15,8 @@ const (
// The default value is 20 requests per second.
DefaultSourceIPLimitPerSecond = 20.0
// DefaultSourceIPBurstSize is the maximum burst allowed per rate limiter.
- // E.g. The first 20 requests within 1s will succeed, but the 21st will fail.
- DefaultSourceIPBurstSize = 20
+ // E.g. The first 100 requests within 1s will succeed, but the 101st will fail.
+ DefaultSourceIPBurstSize = 100
// based on an avg ~4,000 unique IPs per minute
// https://log.gprd.gitlab.net/app/lens#/edit/f7110d00-2013-11ec-8c8e-ed83b5469915?_g=h@e78830b
diff --git a/internal/ratelimiter/ratelimiter_test.go b/internal/ratelimiter/ratelimiter_test.go
index 5b4a52fd..cdf12fe6 100644
--- a/internal/ratelimiter/ratelimiter_test.go
+++ b/internal/ratelimiter/ratelimiter_test.go
@@ -17,7 +17,7 @@ func mockNow() time.Time {
return validTime
}
-func TestDomainAllowed(t *testing.T) {
+func TestSourceIPAllowed(t *testing.T) {
t.Parallel()
tcs := map[string]struct {
@@ -70,7 +70,7 @@ func TestDomainAllowed(t *testing.T) {
}
}
-func TestSingleRateLimiterWithMultipleDomains(t *testing.T) {
+func TestSingleRateLimiterWithMultipleSourceIPs(t *testing.T) {
rate := 10 * time.Millisecond
rl := New(
WithSourceIPLimitPerSecond(float64(1/rate)),