diff options
| author | Jaime Martinez <jmartinez@gitlab.com> | 2020-05-21 03:52:19 +0300 |
|---|---|---|
| committer | Jaime Martinez <jmartinez@gitlab.com> | 2020-05-28 04:10:14 +0300 |
| commit | f6dfa5d0043aeaa616c16f8babb64c0d0e8f72dd (patch) | |
| tree | f8cbab7f2c4a30c07f827a50d7877c388e18616f /Makefile.build.mk | |
| parent | 559311801a1e9114f8dee71faa388dcefab3dcbe (diff) | |
Add .golangci.yml linter configuration
As part of https://gitlab.com/gitlab-org/gitlab-pages/-/issues/385
we have introduced the use of a custom `.golangci.yml` file with some
custom rules for linting.
This replaces the need of downloading and using `golint`, `gofmt`
`go vet` and `gocyclo` manually. We take advantage of the custom
`golangci-lint` docker image as stated in the [Automatic lintinb]
(https://docs.gitlab.com/ee/development/go_guide/#automatic-linting)
section of the Go standards and style guidelines.
This iteration enables a subset of linters, with the remaining
of them enabled on a separate MR as described in the issue above.
The main changes introduced by this linter include:
- gosec: potential hardcoded credentials
- goconst: DRY by declaring and using constants
- gosimple: reduce statements complexity and improve return statements
Diffstat (limited to 'Makefile.build.mk')
| -rw-r--r-- | Makefile.build.mk | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/Makefile.build.mk b/Makefile.build.mk index 24c2ec39..9a40f68b 100644 --- a/Makefile.build.mk +++ b/Makefile.build.mk @@ -3,10 +3,7 @@ all: gitlab-pages setup: clean .GOPATH/.ok - go get golang.org/x/tools/cmd/goimports@v0.0.0-20191010201905-e5ffc44a6fee - go get golang.org/x/lint/golint@v0.0.0-20190930215403-16217165b5de go get github.com/wadey/gocovmerge@v0.0.0-20160331181800-b5bfa59ec0ad - go get github.com/fzipp/gocyclo@v0.0.0-20150627053110-6acd4345c835 go get github.com/golang/mock/mockgen@v1.3.1 generate-mocks: .GOPATH/.ok |