diff options
author | Vladimir Shushlin <vshushlin@gitlab.com> | 2021-06-22 04:08:41 +0300 |
---|---|---|
committer | Jaime Martinez <jmartinez@gitlab.com> | 2021-06-22 04:08:41 +0300 |
commit | 400f47ee1e230202fbcad6b39ec31f36fe4d2f11 (patch) | |
tree | 95c135e4f0482dffa0d07cb68c3d15510ba9c61f /app.go | |
parent | acb3ab3e87e16e6f2fa5d7d03c43a7d0220e7775 (diff) |
Apply 2 suggestion(s) to 1 file(s)
Diffstat (limited to 'app.go')
-rw-r--r-- | app.go | 7 |
1 files changed, 3 insertions, 4 deletions
@@ -514,11 +514,10 @@ func runApp(config *cfg.Config) { a.Handlers = handlers.New(a.Auth, a.Artifact) - // TODO: This check is a side effect of defining `-gitlab-server` or not which seems wrong. - // Maybe we need an extra flag to disable it https://gitlab.com/gitlab-org/gitlab-pages/-/issues/582 - // and enable it by default now that we will always use the API + // TODO: This if was introduced when `gitlab-server` wasn't a required parameter + // once we completely remove support for legacy architecture and make it required + // we can just remove this if statement https://gitlab.com/gitlab-org/gitlab-pages/-/issues/581 if config.GitLab.Server != "" { - // TODO: use config.GitLab.InternalServer https://gitlab.com/gitlab-org/gitlab-pages/-/issues/581 a.AcmeMiddleware = &acme.Middleware{GitlabURL: config.GitLab.Server} } |