Apply suggestions from feedback

Update metric name

1 files changed, 3 insertions, 18 deletions

diff --git a/internal/httptransport/transport.go b/internal/httptransport/transport.go
index 4f177914..8f8fa387 100644
--- a/internal/httptransport/transport.go
+++ b/internal/httptransport/transport.go
@@ -31,9 +31,6 @@ type meteredRoundTripper struct {
 	counter   *prometheus.CounterVec
 }
 
-// Option setting for metered round tripper
-type Option func(*meteredRoundTripper)
-
 func newInternalTransport() *http.Transport {
 	return &http.Transport{
 		DialTLS: func(network, addr string) (net.Conn, error) {
@@ -49,25 +46,13 @@ func newInternalTransport() *http.Transport {
 
 // NewTransportWithMetrics will create a custom http.RoundTripper that can be used with an http.Client.
 // The RoundTripper will report metrics based on the collectors passed.
-func NewTransportWithMetrics(gaugeVec *prometheus.GaugeVec, counterVec *prometheus.CounterVec, options ...Option) http.RoundTripper {
-	mtr := &meteredRoundTripper{
+func NewTransportWithMetrics(name string, gaugeVec *prometheus.GaugeVec, counterVec *prometheus.CounterVec) http.RoundTripper {
+	return &meteredRoundTripper{
 		next:      InternalTransport,
+		name:      name,
 		durations: gaugeVec,
 		counter:   counterVec,
 	}
-
-	for _, option := range options {
-		option(mtr)
-	}
-
-	return mtr
-}
-
-// WithMeteredRoundTripperName adds a name to the meteredRoundTripper instance
-func WithMeteredRoundTripperName(name string) func(*meteredRoundTripper) {
-	return func(tripper *meteredRoundTripper) {
-		tripper.name = name
-	}
 }
 
 // This is here because macOS does not support the SSL_CERT_FILE and