diff options
| author | Jaime Martinez <jmartinez@gitlab.com> | 2020-09-16 07:02:14 +0300 |
|---|---|---|
| committer | Vladimir Shushlin <v.shushlin@gmail.com> | 2020-09-21 13:53:18 +0300 |
| commit | e283476fefd47fc7a51a3e8b8ab69a0e29f257b1 (patch) | |
| tree | fb2d5e123e2eb0cd191ed63dcde38d7efdf76ab7 /internal/vfs/zip/archive.go | |
| parent | a50ef3415d0f48f102983b409115b2da60e19504 (diff) | |
Add to-do references
Diffstat (limited to 'internal/vfs/zip/archive.go')
| -rw-r--r-- | internal/vfs/zip/archive.go | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/internal/vfs/zip/archive.go b/internal/vfs/zip/archive.go index 09bd2497..77448d2c 100644 --- a/internal/vfs/zip/archive.go +++ b/internal/vfs/zip/archive.go @@ -45,6 +45,7 @@ type zipArchive struct { archive *zip.Reader err error + // TODO: add metrics https://gitlab.com/gitlab-org/gitlab-pages/-/issues/423 files map[string]*zip.File } @@ -100,6 +101,7 @@ func (a *zipArchive) readArchive(ctx context.Context) { return } + // TODO: Improve preprocessing of zip archives https://gitlab.com/gitlab-org/gitlab-pages/-/issues/432 for _, file := range a.archive.File { if !strings.HasPrefix(file.Name, dirPrefix) { continue @@ -132,6 +134,7 @@ func (a *zipArchive) Open(ctx context.Context, name string) (vfs.File, error) { return nil, os.ErrNotExist } + // TODO: cache dataOffsets of files https://gitlab.com/gitlab-org/gitlab-pages/-/issues/461 dataOffset, err := file.DataOffset() if err != nil { return nil, err |