diff options
| author | Jaime Martinez <jmartinez@gitlab.com> | 2020-09-29 10:50:43 +0300 |
|---|---|---|
| committer | Jaime Martinez <jmartinez@gitlab.com> | 2020-09-30 07:33:28 +0300 |
| commit | 7bd5df3e66acab70f89dca0a2d23d63f957f40d0 (patch) | |
| tree | 8c23c011074a50f5c7aa14dbdb9f64eac8543afe /metrics | |
| parent | 8dcfd518cf1a1a5f570fe43718a3cff8d8cd5ca0 (diff) | |
Add tests for new metrics
DRY transport.
Add buckets to responsiveness metric.
Diffstat (limited to 'metrics')
| -rw-r--r-- | metrics/metrics.go | 11 |
1 files changed, 6 insertions, 5 deletions
diff --git a/metrics/metrics.go b/metrics/metrics.go index b1d10f2f..6f46c6c2 100644 --- a/metrics/metrics.go +++ b/metrics/metrics.go @@ -113,11 +113,12 @@ var ( Help: "The time (in seconds) it takes to get a response from the Object Storage provider for zip file serving", }, []string{"status_code"}) - // ObjectStorageResponsiveness Object Storage request responsiveness for different stages of an http request - // see httptrace.ClientTrace + // ObjectStorageResponsiveness Object Storage request responsiveness in ms for different stages of an http request + // see httptrace.ClientTrac ObjectStorageResponsiveness = prometheus.NewHistogramVec(prometheus.HistogramOpts{ - Name: "gitlab_pages_object_storage_backend_request_responsiveness", - Help: "Object Storage request responsiveness for different stages (TLS Handshake,response write, etc)", + Name: "gitlab_pages_object_storage_backend_request_responsiveness_ms", + Help: "Object Storage request responsiveness for different stages (TLS Handshake,response write, etc)", + Buckets: []float64{1, 5, 10, 20, 50, 100, 250, 500, 1000, 2000, 5000, 10000, 20000}, }, []string{"request_stage"}) // ZipServingOpenArchivesTotal is the number of zip archives that have been opened @@ -137,7 +138,7 @@ var ( Name: "gitlab_pages_object_storage_files_per_zip_archive", Help: "The number of files per zip archive", // squared buckets up to 2^13 - Buckets: prometheus.ExponentialBuckets(2, 2, 13), + Buckets: prometheus.ExponentialBuckets(1, 2, 14), }) // ZipServingArchiveCacheHit is the number of zip archive cache hits |