Welcome to mirror list, hosted at ThFree Co, Russian Federation.

gitlab.com/gitlab-org/gitlab-pages.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authoryigithankardas <root>2022-02-16 16:34:05 +0300
committeryigithankardas <root>2022-02-16 16:34:05 +0300
commitd8f645df7f1fb711698ecc31f71b577b3f8dc617 (patch)
treeff4b8dcc1bf5933e91caf790b285f056ee93a7e4 /test/acceptance/zip_test.go
parentd4a251ae1bb492fee8af0d3d3619bdd3f5bfc1c0 (diff)
reset: go back to initial commit.
Diffstat (limited to 'test/acceptance/zip_test.go')
-rw-r--r--test/acceptance/zip_test.go13
1 files changed, 7 insertions, 6 deletions
diff --git a/test/acceptance/zip_test.go b/test/acceptance/zip_test.go
index dcb831e7..5bb2a0d1 100644
--- a/test/acceptance/zip_test.go
+++ b/test/acceptance/zip_test.go
@@ -10,6 +10,8 @@ import (
"time"
"github.com/stretchr/testify/require"
+
+ "gitlab.com/gitlab-org/gitlab-pages/internal/testhelpers"
)
func TestZipServing(t *testing.T) {
@@ -85,8 +87,7 @@ func TestZipServing(t *testing.T) {
t.Run(name, func(t *testing.T) {
response, err := GetPageFromListener(t, httpListener, tt.host, tt.urlSuffix)
require.NoError(t, err)
- defer response.Body.Close()
-
+ testhelpers.Close(t, response.Body)
require.Equal(t, tt.expectedStatusCode, response.StatusCode)
if tt.expectedStatusCode == http.StatusOK {
@@ -217,7 +218,7 @@ func TestZipServingCache(t *testing.T) {
// send a request to get the ETag
response, err := GetPageFromListener(t, httpListener, tt.host, tt.urlSuffix)
require.NoError(t, err)
- defer response.Body.Close()
+ testhelpers.Close(t, response.Body)
require.Equal(t, http.StatusOK, response.StatusCode)
etag := response.Header.Get("ETag")
@@ -231,7 +232,7 @@ func TestZipServingCache(t *testing.T) {
body, err := io.ReadAll(rsp.Body)
require.NoError(t, err)
- defer rsp.Body.Close()
+ testhelpers.Close(t, rsp.Body)
require.Equal(t, tt.expectedContent, string(body), "content mismatch")
})
}
@@ -308,7 +309,7 @@ func TestZipServingFromDisk(t *testing.T) {
t.Run(name, func(t *testing.T) {
response, err := GetPageFromListener(t, httpListener, tt.host, tt.urlSuffix)
require.NoError(t, err)
- defer response.Body.Close()
+ testhelpers.Close(t, response.Body)
require.Equal(t, tt.expectedStatusCode, response.StatusCode)
@@ -333,7 +334,7 @@ func TestZipServingConfigShortTimeout(t *testing.T) {
response, err := GetPageFromListener(t, httpListener, "zip.gitlab.io", "/")
require.NoError(t, err)
- defer response.Body.Close()
+ testhelpers.Close(t, response.Body)
require.Equal(t, http.StatusInternalServerError, response.StatusCode, "should fail to serve")
}