diff options
| author | feistel <6742251-feistel@users.noreply.gitlab.com> | 2021-08-10 19:44:16 +0300 |
|---|---|---|
| committer | feistel <6742251-feistel@users.noreply.gitlab.com> | 2021-10-07 16:40:43 +0300 |
| commit | dc7d694f00eadd078a05991bff7c78cb29efeff4 (patch) | |
| tree | ca2c07cc40a46e67623c598a6735d49458a2e157 /test | |
| parent | 64f914a804a4da8a521c5cbe7df1b8cb73f45a4f (diff) | |
refactor: stop running gitlab-pages as root
We have now disabled chroot by default since %14.1, and
recently removed support for disk-based configuration
coming in %14.3. And we've also removed the chroot
completely from Pages.
Since nginx can do TCP proxying and there's no need to use
privileged ports, Pages has been confirmed to run as non-root
in k8s environment without any issues.
This MR removes support for the gitlab-pages daemon completely.
Changelog: removed
Diffstat (limited to 'test')
| -rw-r--r-- | test/acceptance/helpers_test.go | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/test/acceptance/helpers_test.go b/test/acceptance/helpers_test.go index b8181dca..8ad0166f 100644 --- a/test/acceptance/helpers_test.go +++ b/test/acceptance/helpers_test.go @@ -381,10 +381,6 @@ func getPagesDaemonArgs(t *testing.T) []string { t.Log("Running pages as a daemon") - // This triggers the drop-privileges-and-chroot code in the pages daemon - out = append(out, "-daemon-uid", "0") - out = append(out, "-daemon-gid", "65534") - return out } |