Age | Commit message (Collapse) | Author | |
---|---|---|---|
2020-06-05 | Use histograms instead of gagues | Jaime Martinez | |
Removed test assertion for metric as histograms are not collectors so we can't really test it. Left the test though as it's still valuable. | |||
2020-06-04 | Add serving time metric for all files | Jaime Martinez | |
2020-06-01 | Enable the remaining linters | Jaime Martinez | |
- ineffassign - misspell - structcheck - typecheck - unconvert - unused - varcheck - whitespace | |||
2020-06-01 | Enable deadcode linter | Jaime Martinez | |
2020-05-28 | Add .golangci.yml linter configuration | Jaime Martinez | |
As part of https://gitlab.com/gitlab-org/gitlab-pages/-/issues/385 we have introduced the use of a custom `.golangci.yml` file with some custom rules for linting. This replaces the need of downloading and using `golint`, `gofmt` `go vet` and `gocyclo` manually. We take advantage of the custom `golangci-lint` docker image as stated in the [Automatic lintinb] (https://docs.gitlab.com/ee/development/go_guide/#automatic-linting) section of the Go standards and style guidelines. This iteration enables a subset of linters, with the remaining of them enabled on a separate MR as described in the issue above. The main changes introduced by this linter include: - gosec: potential hardcoded credentials - goconst: DRY by declaring and using constants - gosimple: reduce statements complexity and improve return statements | |||
2020-05-07 | go fmt | Igor Wiedler | |
2020-05-07 | Merge remote-tracking branch 'origin/master' into update-labkit | Igor Wiedler | |
2020-05-04 | Add a prometheus counter for GitLab API call failures | Grzegorz Bizon | |
2020-04-28 | add newline to /readiness success response | Igor Wiedler | |
2020-04-27 | app is in main package, no need to pass VERSION through | Igor Wiedler | |
2020-04-27 | use labkit monitoring.Start() to get auto pprof on metrics port | Igor Wiedler | |
2020-02-28 | Extract health check in its own middleware | Krasimir Angelov | |
This way we short-circuit health check requests and avoid doing domain lookup for them. We also do not report them in exported Prometheus metrics and this way avoid trigger alerts during deploys. Related to: * https://gitlab.com/gitlab-org/gitlab-pages/issues/350 * https://gitlab.com/gitlab-com/gl-infra/production/issues/1681 | |||
2020-02-19 | Remove request.WithHTTPSFlag and set directly in tests | Jaime Martinez | |
2020-02-03 | use gorilla/handlers.ProxyHeaders to get the X-Forwarded-* headers and set ↵ | Jaime Martinez | |
them in the appropriate http.Request fields | |||
2019-12-08 | Add support for the port component in the Host header | Grzegorz Bizon | |
2019-12-04 | Improve error reporting in the main package | Grzegorz Bizon | |
2019-12-02 | Improve error handing when creating new domains config source | Grzegorz Bizon | |
2019-11-25 | Make it possible to pass client config to gitlab source | Grzegorz Bizon | |
2019-11-24 | Respond with 502 if a domain can not be retrieved from a source | Grzegorz Bizon | |
2019-11-23 | Implement a transitional domains source | Grzegorz Bizon | |
2019-11-23 | Add note about transitional domain source interface | Grzegorz Bizon | |
2019-10-07 | Remove unused Admin gRPC API | Krasimir Angelov | |
It was ever used. See gitlab-org/omnibus-gitlab/merge_requests/3444#note_194217889 for more details. Done as part of https://gitlab.com/gitlab-org/gitlab/issues/28781. | |||
2019-10-02 | Merge branch 'master' into backstage/gb/domain-serving-refactoring | Grzegorz Bizon | |
2019-10-02 | Merge branch 'backstage/gb/separate-domain-source-storage' into 'master' | Nick Thomas | |
Separate domain config source See merge request gitlab-org/gitlab-pages!188 | |||
2019-10-01 | Remove references to `Project` | Kamil Trzciński | |
Always uses `LookupPath`. The `project` is local to `source/disk`. | |||
2019-09-27 | Create a factory method for Domains to handle mutex better | Grzegorz Bizon | |
2019-09-27 | Create a factory method for Domains to handle mutex better | Grzegorz Bizon | |
2019-09-26 | Add support for previewing artifacts that are not public | Tuomo Ala-Vannesluoma | |
Remove some duplicate logic on Auth module Separate handling artifact to own handlers package Unit test handlers by mocking auth and artifact modules Add generate-mock step to Makefile Use additional handler func to simplify TryMakeRequest return type Always try with token if exists Do not log RequestURI, log path only Remove not used logRequest func | |||
2019-09-24 | Remove refactoring support comments and improve app.go | Grzegorz Bizon | |
2019-09-24 | Encapsulate groups config in the source package | Grzegorz Bizon | |
2019-09-22 | Separate domain config source from a domain | Grzegorz Bizon | |
2019-09-13 | Rename confusing domain struct from D to Domain | Grzegorz Bizon | |
2019-08-30 | Refactoring to reduce cyclometric complexity | Andrew Newdigate | |
2019-08-30 | Add full HTTP metrics and logging to GitLab pages using LabKit | Andrew Newdigate | |
2019-08-22 | Refactor to use pluggable http.Handler middlewaresan-use-middleware-handlers | Andrew Newdigate | |
2019-08-21 | Fix https downgrade for pages behind proxy | Vladimir Shushlin | |
We can't rely on r.TLS when pages are served behind proxy So we save https flag to a context for later usage Right now I'm trying to keep changes to a minimum since I'm planning to backport this to older versions That's why https flag is not refactored throughout the codebase The alternative way would be to use gorilla's proxy headers I'm planning to refactor to that version later | |||
2019-08-08 | Use simplified Prometheus handler func. | Ben Kochie | |
2019-07-12 | feat: add flag to define custom response headers | Max Wittig | |
2019-07-10 | Revert "chore: vendor complete dependency tree" | Max Wittig | |
This reverts commit 27bd4d83cade6a721330e8583874e7c715bf3a26. | |||
2019-06-03 | Redirect unknown ACME challenges to the GitLab instance | Vladimir Shushlin | |
2019-05-28 | Add config flags to specify TLS versions | Krasimir Angelov | |
Introduce two new configuration options -tls-min-version and -tls-max-version to control which TLS versions will be supported by the server. Accepted values are ssl3, tls1.0, tls1.1, tls1.2, and tls1.3. Closing https://gitlab.com/gitlab-org/gitlab-pages/issues/187 | |||
2019-05-16 | Disable 3DES and other insecure cipher suites | Krasimir Angelov | |
Supported cipher suites: tls.TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305 tls.TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305 tls.TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 tls.TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256 tls.TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 tls.TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384 Closes https://gitlab.com/gitlab-org/gitlab-pages/issues/150. | |||
2019-04-02 | Prepare pages auth logs for production rollout | Vladimir Shushlin | |
Mostly escalate log levels Add new logs and fields to existing logs | |||
2018-10-26 | Allow the maximum connection concurrency to be specified | Nick Thomas | |
2018-10-02 | Fix comparing the domain and log request information as well. Removed ↵ | Tuomo Ala-Vannesluoma | |
invalid comment and fixed one else case. | |||
2018-09-30 | Fix returning and calling function | Tuomo Ala-Vannesluoma | |
2018-09-22 | Add special handling for namespace projects to avoid existence leak | Tuomo Ala-Vannesluoma | |
2018-09-10 | Fix handling the projects with not updated configuration | Tuomo Ala-Vannesluoma | |
2018-08-18 | Add missing return call | Tuomo Ala-Vannesluoma | |
2018-08-10 | Allow auth proxying only for configured domains and everything under pages ↵ | Tuomo Ala-Vannesluoma | |
domain |