Age | Commit message (Collapse) | Author |
|
|
|
When the artifacts server is enabled, GitLab Rails links certain files
(e.g. HTML) to the GitLab Pages server so that the file can be rendered
instead of downloaded. However, if public pipelines are not enabled for
a public project and the user never authenticated with the Pages server,
the GitLab Artifacts API would return a 403 error. This error would be
forwarded to the user, and Pages would halt further processing.
To fix this problem, when we encounter a 403 error, we attempt to
authenticate the user if no token is available.
Relates to https://gitlab.com/gitlab-org/gitlab/-/issues/25192
Changelog: fixed
|
|
|
|
nolint is added when the body is nil or if
the body can't be closed
|
|
- ineffassign
- misspell
- structcheck
- typecheck
- unconvert
- unused
- varcheck
- whitespace
|
|
|
|
Remove some duplicate logic on Auth module
Separate handling artifact to own handlers package
Unit test handlers by mocking auth and artifact modules
Add generate-mock step to Makefile
Use additional handler func to simplify TryMakeRequest return type
Always try with token if exists
Do not log RequestURI, log path only
Remove not used logRequest func
|